Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1649989179.git.Sandor.yu@nxp.com>
In-Reply-To: <cover.1649989179.git.Sandor.yu@nxp.com>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Tue, 19 Apr 2022 18:32:32 +0200
Message-ID: <CAG3jFyuhe9CJBLuqKH9u9NSujkqkOhh4NJ59xOD8xEVNO7gnEg@mail.gmail.com>
Subject: Re: [PATCH v3 0/4] DRM: Bridge: DW_HDMI: Add new features and bug fix
To:     Sandor.yu@nxp.com
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        andrzej.hajda@intel.com, narmstrong@baylibre.com,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, hverkuil-cisco@xs4all.nl,
        shengjiu.wang@nxp.com, cai.huoqing@linux.dev, maxime@cerno.tech,
        harry.wentland@amd.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 15 Apr 2022 at 04:43, <Sandor.yu@nxp.com> wrote:
>
> From: Sandor Yu <Sandor.yu@nxp.com>
>
> This is new features and bug fix patch set for DW_HDMI DRM bridge driver
> that has verified by NXP i.MX8MPlus.
> Two new feature added:
> 1. Add GPA interface for DW_HDMI Audio.
> 3. New API for reset PHY Gen1.
> Two bugs fixed:
> 1. Enable overflow workaround for all IP versions later than v1.30a.
> 2. Clear GCP_Auto bit for 24-bit color depth to pass CTS.
>
> v1->v2:
> 1. Save CEC interrupt registers in struct dw_hdmi_cec
> 2. Restore CEC logical address register by cec->addresses.
> 3. Default enable overflow workaround for all versions later than v1.30a.
> 4. Add clear_gcp_auto flag to clear gcp_auto bit for all 24-bit color.
> 5. Remove i.MX8MPlus specific reference.
>
> v2->v3:
> 1. Drop the patch of Add CEC Suspend/Resume to restore registers.
> Because it is not a general feature for other SOCs, their CEC engine are
> enabled in suspend for CEC wakeup.
> 2. More detail comments for patch GCP only for Deep Color.
> 3. Address coments for patch GPA driver and move enable_audio/disable_audio
> from dw_hdmi_phy_ops to dw_hdmi_plat_data.
>
> Sandor Yu (4):
>   drm: bridge: dw_hdmi: default enable workaround to clear the overflow
>   drm: bridge: dw_hdmi: Enable GCP only for Deep Color
>   drm: bridge: dw_hdmi: add reset function for PHY GEN1
>   drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver
>
>  drivers/gpu/drm/bridge/synopsys/Kconfig       |  10 +
>  drivers/gpu/drm/bridge/synopsys/Makefile      |   1 +
>  .../drm/bridge/synopsys/dw-hdmi-gp-audio.c    | 199 ++++++++++++++++++
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c     | 186 ++++++++++++++--
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.h     |  16 +-
>  drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c        |   2 +-
>  include/drm/bridge/dw_hdmi.h                  |  11 +-
>  7 files changed, 400 insertions(+), 25 deletions(-)
>  create mode 100644 drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c

Fixed two checkpatch --strict formatting warnings.

Applied to drm-misc-next.