Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Yihao Han <hanyihao@vivo.com>
Cc:     Hannes Reinecke <hare@suse.de>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@vivo.com
Subject: Re: [PATCH] scsi: fcoe: simplify if-if to if-else
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq135i9aifi.fsf@ca-mkp.ca.oracle.com>
References: <20220408081237.14037-1-hanyihao@vivo.com>
Date:   Mon, 18 Apr 2022 22:58:01 -0400
In-Reply-To: <20220408081237.14037-1-hanyihao@vivo.com> (Yihao Han's message
        of "Fri, 8 Apr 2022 01:12:37 -0700")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ia/slzh8ARhnUvR5kd4GW/eSM5BVCzn9kKOBLrUGcy5D0hT4j0Ls9hagG7Fl?=
 =?us-ascii?Q?G+q8mqL+YOhV5vxjdn3ZIQcHV0jVIOdQEclzz3O9mJlxNQWF8SmfdBODMcUA?=
 =?us-ascii?Q?5Syjpv96kWiPnm9137ty5LhTPo/2sy/hB8a54naOAA1i/9fHJk9QfnQJO5de?=
 =?us-ascii?Q?dUPA1MoifxA4cKwbCtxIac3uz6K7V10VMyxVXOMr4rvk+Z1+4mVVRsWXP9MJ?=
 =?us-ascii?Q?eTMKrT99LfDNB6vLRCQ2+uWPEEVVUfoafVr4hGUuvP6HnMMSGQqjPrYjPjnj?=
 =?us-ascii?Q?y2i0UhEamoXJDC5A47Qeq2fWfo/3dLBZlRvi4N951E+jz8+BETbI/BMGWlQQ?=
 =?us-ascii?Q?dZqLnJ5YCG9xpsYJ4q7I+767gp8jS8LTWM2ARP5/iRP+mZBMYprYGbRywlqu?=
 =?us-ascii?Q?Bt9q8fYyii0kllyLePtxti1LdPsX6nMPoc8OLPG2tSd+kOQxDacqKELnHKUT?=
 =?us-ascii?Q?ZU4NriQsAKFnjFOcwB1/TAFspopbf561VHOTZrkOPmtXEkEWa5B/nlfXOBRE?=
 =?us-ascii?Q?En8tOXIRAZSekmuvxyQzSpYwkgFlSnBvyjT5cU80grU0tgyDoscoQ0R0V2vN?=
 =?us-ascii?Q?T5Z9J8B/VsMVt+JPJMSEYhzSEcWO2JUcNDWXW4whG7U13Dx5FX3TNxPeofcH?=
 =?us-ascii?Q?O0vqn4GXggyL+hCGYJJ5cYjDWyhyJdc7N+rNpf6t0y/t8Uw3Cmx07vp3pUEE?=
 =?us-ascii?Q?hT/sbLTw2xBl3zMKtb0UoHOZOiU1vllmI2Sd2FFrE1BHvl9p5EBFc6PtkPzO?=
 =?us-ascii?Q?0cF48X4y/WH5YCbjkFW3PRmNZN9cEzXHrrNhz+UQKffh9W2kb9kIOEFPI3/U?=
 =?us-ascii?Q?93lO2sjDeQLZPGx0g6Ov9mbioyF6Cetawk6NPltt7iQ5GO7w8116cXKP4hXm?=
 =?us-ascii?Q?SsAnNokKmrVSvfcPnC3blbMO6fLaxnHUQu8m8TzDh3+vEYo6Y4OtkmMIftrI?=
 =?us-ascii?Q?DnuTsib6uQLBRpK3VPcDvvWoeCNv68xIIRTOPUTipz01O3PU/sfYn8yHHqBu?=
 =?us-ascii?Q?4zSQhdoOqJWWoLovp6ASJaBuCE6Z9OODSW2sC04IxVJb8vgkalAKQLH1vms9?=
 =?us-ascii?Q?QDr9J60gxiEo7BlXC3AQFVpT7E3dOk8xxv0rCNOGonoNRNFMTH+N8YW1jDNa?=
 =?us-ascii?Q?/nyWcKDTw23hW4q6dzTCvfDuBayRPqnLphjnMyCPW4rZUwR1R4jjhmOVtqRy?=
 =?us-ascii?Q?SutbhjRtOXms7X3jtwZLzGW5+0g1tZU/CzMQrbBNy+Q2K1u2Vp35CQ26SsEz?=
 =?us-ascii?Q?pxrKy0LPpEYTcImXdS8yEYoYTIwJ3GBao/pJK5mEnKA6iKolc92R4C5f643d?=
 =?us-ascii?Q?HGZLGAj3vtsV6BiVmaSv3b9Ge3T75UYYBnyKeCBq6U6QfDWRGiqidRZsHFAJ?=
 =?us-ascii?Q?ixZVLSryEu6V7n6ZLd6MjPi9T0vBQfPELRHPymvBYx8jpGJKshWWLpBwDQqt?=
 =?us-ascii?Q?SDikLS0++n8t34k1jL6WSWlNq06KAalEh6tOI9Y4pvgUJDePeM73BTLgQajt?=
 =?us-ascii?Q?KtIfzDbysP8HPhGTedM/dglxXL5Qm1HLJFfnX63jpH4WZojFQTz5GVWVvkLO?=
 =?us-ascii?Q?x6oKIsxH9o1jly0Uw3KPOlO+l6gMhFzWp+LFsIzPAZvdVlQ72nJvrI1+q4Ph?=
 =?us-ascii?Q?W+0s1GCPP+jSfbZtYWa859A/JIE7TgK/PQWk36qpjdjTBhiGJGR8tSHsVaEn?=
 =?us-ascii?Q?X0YxisHa+itUsigUkAtBP0PnByDzKcJTFTILky6DFsqJrSCc5Wjw8EieS8wB?=
 =?us-ascii?Q?UPqFQxdys2sszF4T0azkCLmzVeYkTUk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c517d8b1-f4d3-47fe-77b7-08da21b06c33
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 02:58:04.0556
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SvMEULuTj/meKT9XtiserU8U8RK0PxKQ5IDIFcWHo2q7l7HpFjUxDY9up7mCyOhmiz9y0pOMA6EdCMm6o7mx4f/0P7jI5af6bd8pEuG+7IA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1755
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-19_01:2022-04-15,2022-04-19 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0
 malwarescore=0 mlxlogscore=610 adultscore=0 mlxscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204190012
X-Proofpoint-ORIG-GUID: p9EEpFXvSZpDaacfzU6IHoUrJ3h3toIh
X-Proofpoint-GUID: p9EEpFXvSZpDaacfzU6IHoUrJ3h3toIh
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Yihao,

> Replace `if (!is_zero_ether_addr(mac))` with `else` for simplification
> and add curly brackets according to the kernel coding style:

Applied to 5.19/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering