Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Apr 2022 15:55:43 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Satya Priya <quic_c_skakit@quicinc.com>,
        Lee Jones <lee.jones@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, quic_collinsd@quicinc.com,
        quic_subbaram@quicinc.com, quic_jprakash@quicinc.com
Subject: Re: [PATCH V10 7/9] regulator: Add a regulator driver for the PM8008
 PMIC
Message-ID: <Yl7Nb0mNjt7kV3uV@sirena.org.uk>
References: <1649939418-19861-1-git-send-email-quic_c_skakit@quicinc.com>
 <1649939418-19861-8-git-send-email-quic_c_skakit@quicinc.com>
 <CAE-0n533obTi995x_rJG_ihUUquF3MQLJt6VMf7=oxyzMUL5DQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="xgIXoV2XBfJmzGtV"
Content-Disposition: inline
In-Reply-To: <CAE-0n533obTi995x_rJG_ihUUquF3MQLJt6VMf7=oxyzMUL5DQ@mail.gmail.com>
Precedence: bulk


--xgIXoV2XBfJmzGtV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Apr 14, 2022 at 05:25:49PM -0700, Stephen Boyd wrote:
> Quoting Satya Priya (2022-04-14 05:30:16)

> > +static struct platform_driver pm8008_regulator_driver = {
> > +       .driver = {
> > +               .name           = "qcom-pm8008-regulator",

> I'd prefer to use an of_device_id table here. That would let us populate
> a "qcom,pm8008-regulators" node that had the ldo nodes as children and
> avoid mfd cells.

That's encoding the current Linux way of splitting up drivers into the
DT rather than describing the hardware.

--xgIXoV2XBfJmzGtV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJezW8ACgkQJNaLcl1U
h9CHlQf/SfDYm+bgiFNO/+eLj38zgXokwbbiT9deWgN2aYkZy60/A2Ps2Noi2dtT
bZ7untJiUelfBeNawv1WOu1iI1Gr4eRYBMK1r3stWu6gwLlQZKrou5B6Qfi7hEcI
/4P5co/b0g6XbKUYGfcTwmMDiCzcycwwmhK9CFL7wOuHaPseV9Zqy+AhzZL/A85W
TRqLznvoEfS3IMFxP0lnsEZkCpzKcOC8UK0qkFdUI7uPtRA73dEbQU8R5k8BAgXt
kvjcDWbUkVWNwr/tswF2oehY+OKlSTMlx2rlVJB/FCQpm/XvfCE1gHH/0nwa6qqb
OT/OxrogzuEuEtz7rmkyhzCF5lNIFw==
=lzLV
-----END PGP SIGNATURE-----

--xgIXoV2XBfJmzGtV--