Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Apr 2022 22:04:18 +0100
From:   Phillip Potter <phil@philpotter.co.uk>
To:     Jens Axboe <axboe@kernel.dk>, Enze Li <lienze@kylinos.cn>
Cc:     linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] cdrom: do not print info list when there is no cdrom
 device
Message-ID: <Yl3SUr9+qzoRlQt8@equinox>
References: <20220408084221.1681592-1-lienze@kylinos.cn>
 <25390602-cfa0-dba3-bfbc-a35ed6b44bcf@kernel.dk>
 <20220409122530.60353fcd@asus>
 <YlFA7USiCtqsFvVD@equinox>
 <f74b6933-5357-6b2c-3127-7a3465dadbdf@kylinos.cn>
 <226c4072-a3ca-a5a4-1b7f-f7104b43af03@kernel.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <226c4072-a3ca-a5a4-1b7f-f7104b43af03@kernel.dk>
Precedence: bulk

On Mon, Apr 11, 2022 at 10:51:28AM -0600, Jens Axboe wrote:
> >   20  -- Modify sysctl/proc interface. I plan on having one directory per                 
> >   21  drive, with entries for outputing general drive information, and sysctl             
> >   22  based tunable parameters such as whether the tray should auto-close for             
> >   23  that drive. Suggestions (or patches) for this welcome!
> > ================================================
> > I'd like to know if the relevant patches are still welcome?
> > 
> > IIUC, the TODO List says that we need to implement a modification of the
> > following form:
> > ----------------------------------------------------------------------------------------------------------
> > $ tree /proc/sys/dev/cdrom
> > /proc/sys/dev/cdrom
> > |--sr0--autoclose
> > |       |-autoeject
> > |       |-check_media
> > |       |-debug
> > |       |-info
> > |       |-lock
> > |
> > |--sr1--autoclose
> > |       |-autoeject
> > |       |-check_media
> > |       |-debug
> > |       |-info
> > |       |-lock
> > |
> > |--sr2 ...
> > .
> > .
> > .
> > ----------------------------------------------------------------------------------------------------------
> > I would appreciate it if you could give me some advice.
> 
> Let's not do that, this advice is perhaps 20 years old. /proc isn't to
> be used for anything like that these days.
> 
> -- 
> Jens Axboe
>

Hi Both,

I will send a patch alongside others during the next merge window to
remove this TODO section for now. It was part of the initial mainline
git commit (17 years and two days ago), so it (as Jens says) is almost
certainly even older than this.

Regards,
Phil