Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Apr 2022 22:18:26 +0000
To:     Guenter Roeck <linux@roeck-us.net>
From:   wujek dev <dev_public@wujek.eu>
Cc:     Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Reply-To: wujek dev <dev_public@wujek.eu>
Subject: Re: [PATCH] hwmon: (pmbus) allow to use a custom read_byte_data function for PMBUS_CAPABILITY
Message-ID: <zhBIzasdu7Dys33upjpvrg4Ho_-MGpd1dAPkMdfwnelzg8KC-lI6KE7o-6Thz6OF_rOuZYUgMlbneKAxPJtMilcpgJCV9tu5fD2vpdcnlX0=@wujek.eu>
In-Reply-To: <23a10930-e78b-d795-056e-879e52e2b45f@roeck-us.net>
References: <20220419215149.309760-1-dev_public@wujek.eu> <23a10930-e78b-d795-056e-879e52e2b45f@roeck-us.net>
Feedback-ID: 23425257:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

------- Original Message -------
On Wednesday, April 20th, 2022 at 00:08, Guenter Roeck <linux@roeck-us.net>=
 wrote:


>
>
> On 4/19/22 14:52, Adam Wujek wrote:
>
> > Some devices returns a wrong value in PMBUS_CAPABILITY register.
> > Allow the use of read_byte_data function defined in a driver for
> > a specific device.
>
>
> Those devices should set PMBUS_NO_CAPABILITY.
>
> Guenter
Yes, you're correct. I was working with the older kernel. Please ignore thi=
s patch.

Adam
>
> > Signed-off-by: Adam Wujek dev_public@wujek.eu
> > ---
> > drivers/hwmon/pmbus/pmbus_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmb=
us_core.c
> > index f8ca36759b0a..ef9989be8f89 100644
> > --- a/drivers/hwmon/pmbus/pmbus_core.c
> > +++ b/drivers/hwmon/pmbus/pmbus_core.c
> > @@ -2011,7 +2011,7 @@ static int pmbus_init_common(struct i2c_client *c=
lient, struct pmbus_data *data,
> > }
> >
> > /* Enable PEC if the controller supports it */
> > - ret =3D i2c_smbus_read_byte_data(client, PMBUS_CAPABILITY);
> > + ret =3D _pmbus_read_byte_data(client, -1, PMBUS_CAPABILITY);
> > if (ret >=3D 0 && (ret & PB_CAPABILITY_ERROR_CHECK))
> > client->flags |=3D I2C_CLIENT_PEC;
> > else
> > --
> > 2.17.1