Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp4707404pxb; Wed, 20 Apr 2022 08:32:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxnGq+2L01+pEGmT7HaIo2jkj7BZzUDDd/lDXq+X1jFP0tN7VeBh3RGaf7yJQgXKypItOu X-Received: by 2002:a17:90a:b307:b0:1bd:37f3:f0fc with SMTP id d7-20020a17090ab30700b001bd37f3f0fcmr5158199pjr.132.1650468769081; Wed, 20 Apr 2022 08:32:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650468769; cv=none; d=google.com; s=arc-20160816; b=dFzrPuq7+a/5xNK54AHlXvT3Tne/0ALVNss9TxDuO6DwhpPPm4wcZ8mW8gzfyguKpL NDPbsYf385gnwMGTK/vTrYpyY2mrw7TteXKgGm+9ISz0OsO5Kw+KSGpzvUF+6Z5ZWjHX jJF97wb11Sk0J929VliyEp4y2QfbeZuscf+8CLDyhJn2bsTRXvc2wqgp443st69Eqv5f RfkaxXVUqmEGmLrX4PycC6B4EZMNKxGgD9VKgRrtIplezgRmGb2nwKjH5WvymWRbSn9W uY6eBa/4U51hNmhUr6J0pCapdfLbxePwJ9PtilIiB0F2smpBYGQKZ9+es7Pl4mwGW0ik MiwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:references:in-reply-to:from :organization:dkim-signature; bh=PrrNuS+foM693GJvOCbAI1vgpisQh65cvvQgte9kMSQ=; b=WBjEekNkGuOLJ/7y7VQ/lQhworhcsKltFnzcJZL9B3rGMbOl1g3kMWl6GwQaKsUEaZ qmMI8rdTvyx30go6tldGiy4hm/9MRAvJK1bdrYdMDxHAYBM6iPKsmTT1i2OOkRNNa8/o JvpsKUN6PDXaEuL3Vtg1v2Kma/gorJUsv34CzXekHbc6WcI1z4g4gBZTn8nx6FCCrIBH EDlzIUlnnRrRkOHyqRHSBz6kGgAxsqeLLD6nK6ldEW9T1m/R6royFfTPKstb81/Eitb0 QiSJrLhlLL7pkmNs9XlWYJAWj3CLLyvBif9oA4nxG7UPZoGSJTBlXRIxeJn4BqO1dqJa /mYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DHXUTqmg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h16-20020a056a00231000b004fae00be7c5si2609057pfh.40.2022.04.20.08.32.29; Wed, 20 Apr 2022 08:32:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DHXUTqmg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344638AbiDSQAV (ORCPT + 99 others); Tue, 19 Apr 2022 12:00:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354159AbiDSQAK (ORCPT ); Tue, 19 Apr 2022 12:00:10 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 872C724583 for ; Tue, 19 Apr 2022 08:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650383846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PrrNuS+foM693GJvOCbAI1vgpisQh65cvvQgte9kMSQ=; b=DHXUTqmgrYNahua/2dcmUaMtlnaFTAireYS3jvkyKYXMucEWo426RNRyenTlUYyKTxW+kC Se/8d+Zgynti3QEySiBluJqxGjn8JZcJeDqoXAAiBB2UU0X5ZKFvNOwIGLsi7pqn7oAndp Da5BQn/TCO22inDH7buH+mf9Rc2kGS8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-19-IrbSQAUOPmGKYLFhBloLAg-1; Tue, 19 Apr 2022 11:57:23 -0400 X-MC-Unique: IrbSQAUOPmGKYLFhBloLAg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 200DA83397D; Tue, 19 Apr 2022 15:56:50 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6471AC159B3; Tue, 19 Apr 2022 15:56:49 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: To: Max Kellermann Cc: dhowells@redhat.com, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: fscache corruption in Linux 5.17? MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <507517.1650383808.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Tue, 19 Apr 2022 16:56:48 +0100 Message-ID: <507518.1650383808@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Max Kellermann wrote: > - * For these first content media elements, the `loading= ` attribute will be omitted. By default, this is the case > + * For these first content media elements, the `loading= ` efault, this is the case > * for only the very first content media element. > * > * @since 5.9.0 > @@ -5377,3 +5377,4 @@ > = > return $content_media_count; > } > +^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@ This is weird. It looks like content got slid down by 31 bytes and 31 zer= o bytes got added at the end. I'm not sure how fscache would achieve that - nfs's implementation should only be dealing with pages. David