Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Apr 2022 09:21:14 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
        James Clark <james.clark@arm.com>,
        German Gomez <german.gomez@arm.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] perf report: Set PERF_SAMPLE_DATA_SRC bit for Arm SPE
 event
Message-ID: <20220419012114.GF166256@leoy-ThinkPad-X240s>
References: <20220414123201.842754-1-leo.yan@linaro.org>
 <Yl3eisj26sHBjokV@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yl3eisj26sHBjokV@kernel.org>
Precedence: bulk

On Mon, Apr 18, 2022 at 06:56:26PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Apr 14, 2022 at 08:32:01PM +0800, Leo Yan escreveu:
> > Since commit bb30acae4c4d ("perf report: Bail out --mem-mode if mem info
> > is not available") "perf mem report" and "perf report --mem-mode"
> > don't report result if the PERF_SAMPLE_DATA_SRC bit is missed in sample
> > type.
> > 
> > The commit ffab48705205 ("perf: arm-spe: Fix perf report --mem-mode")
> > partially fixes the issue.  It adds PERF_SAMPLE_DATA_SRC bit for Arm SPE
> > event, this allows the perf data file generated by kernel v5.18-rc1 or
> > later version can be reported properly.
> > 
> > On the other hand, perf tool still fails to be backward compatibility
> > for a data file recorded by an older version's perf which contains Arm
> > SPE trace data.  This patch is a workaround in reporting phase, when
> > detects ARM SPE PMU event and without PERF_SAMPLE_DATA_SRC bit, it will
> > force to set the bit in the sample type and give a warning info.
> 
> Thanks, applied.

Thank you, Arnaldo!

Leo