Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20bac605-97e6-e5cd-c4e4-83a8121645d8@amd.com>
Date:   Tue, 19 Apr 2022 16:07:44 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA
Content-Language: en-US
To:     Cai Huoqing <cai.huoqing@linux.dev>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org
References: <20220419135908.39606-1-cai.huoqing@linux.dev>
 <20220419135908.39606-3-cai.huoqing@linux.dev>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220419135908.39606-3-cai.huoqing@linux.dev>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVFFZHBsODAxQUJrZmZYb21CTCtZV0pUOEI4YlJTaXQwUm9wNkxjN0JSYjVM?=
 =?utf-8?B?YUtxekQvS1dQVTZGcWozYzhNeHpMclRRRVBUWG14VjRpTkJ6UmdpVjIzN1hz?=
 =?utf-8?B?bmZWRXJ1dDgvWDlkNHdMMlZ6RTUrUS9NNVJ4SDRsT0hJYnp4QWZ1K1dreGNF?=
 =?utf-8?B?eUI1QklDM21obXQzTmwrazRtMm92R2ozRkNQeitWYUo5djFPRXQxdDE0ZERG?=
 =?utf-8?B?T1N2QVlNME5ORXVsSmY4UWRtZ21BNkh4aEc5ODM4bk9jc0I4ZDRRb05vSFlH?=
 =?utf-8?B?S1ByaU1jWGk0enJBeGRnR2tGT2JUMWRPaUdJaWFNRGtCcTRMTkIvVGcvWjM4?=
 =?utf-8?B?d0ZLaWI2amVHamhCR21FT3ppYTlsSWk3Y1RBUHpLZk9DZlh4ZGczYVo4bk5B?=
 =?utf-8?B?aEFxdEF1MGVJZHh0SnFQNjF1c3hlVlFRQUY2MFdXbVlhVVFwVnlCOHZ2WGx1?=
 =?utf-8?B?VmNLM0ptTGs1MEpLUHJXQ3E5QUtHQStKYkFvUWJoUEtQODEyRGRQQmlxemFx?=
 =?utf-8?B?R2NweUovNzY0UlJGdTJVdkFSV1NXeVRQOVVHS0pXS3RQcWY1Mzh1Y25YR0tL?=
 =?utf-8?B?eGR1RTQ1RWpOQi9yTVZMWWpWVDZKQjl4VC9vTTdEU25kZDNmS1phcGlrd2RS?=
 =?utf-8?B?OUdxTXJlcDUya3BSSXRvbk1JNkErdHEwWW0vaHdFQ2UwNHNSVHdpZzdNVENz?=
 =?utf-8?B?MjE3QjBqUWhDN2ZmclJMREx0WWlpVzBsbjMvSDJkZkpyK0VpUFEzR0pmdGJn?=
 =?utf-8?B?TGo3bVV1VDFlZ25PNm5zclh6K1RBZGh5WmNhVklMKzNtM3VNZTdYUkxxaTA3?=
 =?utf-8?B?d1hDS3VjdWdLUXYrSnJxMXZtTVU0VlZEaEdyTWtnNC9UQVhUcFpXY2NucDR5?=
 =?utf-8?B?bnlkdkFHVjRIeFB2VzFFeEh3L2JoWWl6N0NMaVgxRFlkNDlNN3FVWlJMQ01v?=
 =?utf-8?B?WHdOd1BUQk9zZWYzSVlhTXlVSTBDM1F6QjM1QUNMUEdVRDBhMXl6K1NXbitq?=
 =?utf-8?B?VFpuVnh2dkNucjREYzAvUUZuL1NEbUdEcnM4YUlMQ2c0WC96VURYVlJJSWN0?=
 =?utf-8?B?UkM4NkZ4TGhqYzd3blBySmtaYWtUeDFFUnFpbWZuekFyeUczT09CSlJUaU1p?=
 =?utf-8?B?TWd4aEd1MzVaNVByemlUenQrOVdLaWdyM3ZqaHZuRC9RNTZLb1NKa0xLYTRn?=
 =?utf-8?B?RHEyMlR0MTFXZ3FFT0x1OFZJbHdqVVB1RGlzanUzUFFmSFZYckNiTldoYzlh?=
 =?utf-8?B?VUNSSU5IQWV2T0dxaDROTmhrS3JHbWsyNXlNY3lpT1libHFKV2h3Mmx4WExi?=
 =?utf-8?B?WXk4WWFzMTBDMGswQ05jeU5qemhUcG5ISFZKempNS09NMlpJa3M1b3doNllH?=
 =?utf-8?B?UjFmdlVXV3B6RW0vY1NTR01Rd0tlYWVhSG9mZm12N2d1T0xlb0t5ZVFudFNN?=
 =?utf-8?B?dDJhcTdsUlhtVVhqRVFJRHJ0Q20wQW9lcVYxUG1nc21HNmRGc3o5Q0VEU0N6?=
 =?utf-8?B?anJZTlc5RzFDNXJmdEFnd3ZFTmdjaXRuMDR0am51UmFINnRFbmNsZnA2ZWhT?=
 =?utf-8?B?aWpWWlhSWlVQeHZtSVR1ZFJjQ1ZlM0p4dFlFaUNvcnF0ajdZY2ZJeEZidU50?=
 =?utf-8?B?R3JlWERMQ1czUEUxWEo3U0lBdU9QamtxbHZsRFlDU202MzJIRTZuNmFTMWR2?=
 =?utf-8?B?REZ3STBVKzAyYUVSRnphb3puQ2NXOE5rWDJxa3dSN3N5MXlpR3hvNXRxelNt?=
 =?utf-8?B?Mm5TZHQwZU9rYU9nOU5ucUNFM0cyOFdhanJPeWhsMVgrY2NQQm5nTlNlWERM?=
 =?utf-8?B?VWw1eFJVUnlKci9SbytaRUlOdUpOdzlrNlFNY1ZTSlU3TzBDVGV0V0x1eTdS?=
 =?utf-8?B?bFk1U3AwT3BCRXdGTE5qTlNDZ1N5QVpqeWJTOHVMK0NlNndrR2oxYnA0aFB5?=
 =?utf-8?B?dHFRYUdqeXRrNnFQWkdaUFlIWXRUQTNkTEZJcDJ4aTRtTDc4eHIxOGdUd09T?=
 =?utf-8?B?VGVlVmlVK2dURklScDJmU0hLTkVsQnFlWFFOc3RucE5FY3MwQWNBelYwQ3d3?=
 =?utf-8?B?ZDhCRTY5N1Q0cHFrcGt2ZU8wVXpwMFNEZHdYWkg1ZnZiRWVISDVxcE9HVmdZ?=
 =?utf-8?B?cW4zcDZvcEV1QU5reGhiT3M5M3VieFJXakNWNWx4YWhvWTlpeHZTUjVKb2gw?=
 =?utf-8?B?UnkrQjlWNGVINkNHNjB1ZnNxSWZvTjl0enhWdmsybFFHaHh3Q3A0SHd3TDNW?=
 =?utf-8?B?bXJHck5HQkpSSW90WmcrV1V6OFUxdGI4T0k0clBlcmtMcEQzUDkxLzBqS2VI?=
 =?utf-8?B?ODVZdUd5WEpucVhHekNhNmI3ZXRBUm5ENlB4VHVLWEdrSGNNTG9RRElDck5Q?=
 =?utf-8?Q?zF4gvbLMx50xvZR6OSNu6ycx8I0SbKEq7zxnAkrfVbuPE?=
X-MS-Exchange-AntiSpam-MessageData-1: seHKmdpjES02qw==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7533b2ae-cfce-453c-f919-08da220dfd94
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 14:07:51.2851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nBYI4MuLvzNv3wxZ61q6vpPP5/OE/i5BJRHNgAvpGHzVmYRO12jX/9d6/E58l+EY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0017
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 19.04.22 um 15:59 schrieb Cai Huoqing:
> The NVIDIA Deep Learning Accelerator (NVDLA) is an open source IP
> which is integrated into NVIDIA Jetson AGX Xavier,
> so add driver support for this accelerator.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
>

Well doesn't looks so bad on first glance (regarding coding style etc..)

But am I blind or isn't there any UAPI for the driver? I mean adding a 
DRM driver without any change to include/uapi/drm is really odd.

Regards,
Christian.