Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 20 Apr 2022 14:04:24 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Pratyush Yadav <p.yadav@ti.com>
Cc:     Tudor Ambarus <tudor.ambarus@microchip.com>,
        Michael Walle <michael@walle.cc>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Takahiro Kuwano <tkuw584924@gmail.com>,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] spi: spi-mem: check if data buffers are on stack
Message-ID: <YmAE2IVRgPyWxmbn@sirena.org.uk>
References: <20220420102022.3310970-1-p.yadav@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="aiCEfvR0m8oWhfqc"
Content-Disposition: inline
In-Reply-To: <20220420102022.3310970-1-p.yadav@ti.com>
Precedence: bulk


--aiCEfvR0m8oWhfqc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 20, 2022 at 03:50:22PM +0530, Pratyush Yadav wrote:
> The buffers passed in the data phase must be DMA-able. Programmers often
> don't realise this requirement and pass in buffers that reside on the
> stack. This can be hard to spot when reviewing code. Reject ops if their
> data buffer is on the stack to avoid this.
>=20
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> Acked-by: Mark Brown <broonie@kernel.org>
> ---
>=20
> Changes in v2:
> - Include task_stack.h. It might not get included indirectly on some
>   platforms and can cause build failures.
> - Add a WARN_ON_ONCE() for debuggability.
> - Add Mark's Ack.

Since this is now an isolated patch does that mean whatever meant that I
acked rather than applying this patch has gone in and I can now apply it
directly?

--aiCEfvR0m8oWhfqc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJgBNcACgkQJNaLcl1U
h9AVUAf/Thouk4ikZ3+sC6mFcLBnUb0rdoYUyN/9GyPZwVx0Bu6Bj3KLvfMdR2HI
+tn5BCsE8epyRgcCG0tiCfD0Mmv/CV68z8GPMnDdQGtvnMVRSKy9VsBhAuzvy68x
e9lQdmScs6JUJezqCJIGHW+ElYAGR8lymrCHbfFsI1/0+WTj6LueWOAR4m4e3F9P
KNkk50p8ulvfQBu++34jUgHOOJF1HktB5DfqpY4UabmP+iUMvm10Cj6WytRZoztG
CcpugWP1yiqoiLjEQQal8tYvLMIWMmSlGPYl2nylVGxGCzf07TZNtk17R1CIGQjN
zMcrx5SUsSY7THkrvpdybENmrvUVow==
=CnG+
-----END PGP SIGNATURE-----

--aiCEfvR0m8oWhfqc--