Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <25c1d514-360e-3031-2138-8c6db7761192@suse.com>
Date:   Tue, 19 Apr 2022 09:21:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] net: cdc-ncm: Move spin_lock_bh() to spin_lock()
Content-Language: en-US
To:     Yunbo Yu <yuyunbo519@gmail.com>, oliver@neukum.org,
        davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com
Cc:     linux-usb@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220418141812.1241307-1-yuyunbo519@gmail.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20220418141812.1241307-1-yuyunbo519@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1FyTXU3cGRleTJIeGwrbHo5emhBSE4xNHErM1JuSitaUlg4cVA3M2VuYXhi?=
 =?utf-8?B?UGdlUGg0Q1lQVlZ6dTFCbG9QSlBFMjdFUVMyRjBEcS85TWxRNXQ1Uk9UM3U2?=
 =?utf-8?B?czE1YVRoOG0xTTJlYURaOGtGRmVuWCs5aExiRnJhTmN6YmFZamNMaXArVlNp?=
 =?utf-8?B?Q0dWcVVYTWxiei9IM1FKb2NTaTBFaVJBSStaNHVYWm1Ma3NSZkRneFR0cExS?=
 =?utf-8?B?TTJNTnZCNE5HU050UEdmdnM1azFqQmwwZTB3TnRhVnpQVGxDakNQWG5nZ29q?=
 =?utf-8?B?c0w0SVAzd0dwcEpialFkZlBUSi8vU04xWUhCMCtQTjJQaFRsU3VWVEQ2bnNT?=
 =?utf-8?B?d3VnTkJGSFg1RFM2TlUrVllQcmk5cEs3Y3FwVEtmTmYvZ0pITDlOTVc5WWRs?=
 =?utf-8?B?eE9oS05LMk9ZTndQKzZWNStFNDUyWE5uYUdnbi81M0RHWlhVQ2J6R3VZN0ZP?=
 =?utf-8?B?RVBHQlVlWXdpdnFHMTZjOUV4TWNLeXJ4SFIwVXR5Tjl0d2xhbmRDN2Jnc2cy?=
 =?utf-8?B?QmVOeU1YQkhGbVFPYU1GakpISGFXTlBkbU9iQ0QxM0JRRTVhMHN5OWVmbExO?=
 =?utf-8?B?OE82MDZvcnpGcUVCb3NuOUt4SDRkcWlMVE1QUVFMSk9aTS8rVW5iZXZ2V08z?=
 =?utf-8?B?QzFVaUJFSCtoZTQxaHdQNlZBc0JkeHRxNis0VGVmaTMyMERwalM5WERRL0ll?=
 =?utf-8?B?czhvNkhCTHlQbUsxUS92bVF6ZVRoWHRNTVd5VnVRQk5RL212c3MwTTBhMlhi?=
 =?utf-8?B?SFk0M1FWZm9sZEV5dkRURmhjelRPbGJJYUgvMTY5WFRhVU1XcXpjOU5xNFVL?=
 =?utf-8?B?YlR4QzVnbk9pcG42Yno4YXI2K1ZtWDUyK1M0ZDJGS1dETXczcmd4TUduMzU4?=
 =?utf-8?B?b2h0NWNFQytxVi9teTBZelIrWUVEdlIrd05YZHBOQjhLZlBTUDR0NDA1WGhJ?=
 =?utf-8?B?b1BHSzN2c3FvcmxzUTl2bTJPcDA5UXU0VytZck1EVmpoNVc5QkcvdzNxOHBz?=
 =?utf-8?B?eXpZMmoyNGRjaGFaczFOZ01LV3ZaY1VESzhSMzV1dERYSk16ZDVMaEl1d09M?=
 =?utf-8?B?clY0VTJmaW5ZSW1HZnB0S3lnNm8yMmVxcnBrd045bjZtTHBycklyTW51Q1RI?=
 =?utf-8?B?UnRFZVhHZzdQenpwQ3docC96UnlqWHl1MnAwc293bHFuTlFYMzJOenE2MjhX?=
 =?utf-8?B?SU55NnQvQ1VmU2pHS1ZoT0x4elRWSk02d29BWXk5dmRUTjV3alN4bVh0OG1y?=
 =?utf-8?B?UXR4eDlTREdvbms4RTRsTVMxa01DYmZvSTFEbnAwL1M5akxRR2NJWjg5dHYx?=
 =?utf-8?B?WXdRV1RjaW41Ym5qdVlvajBSNTRNK1dFQWNnSGdOQ3JqVXk3a2FWb2JRbVNj?=
 =?utf-8?B?dWwwc00zLzRYUmJkKzBpQmVKYXV4b3pZakh6SnlFSnZSMXp1eTF4M2xjRkNj?=
 =?utf-8?B?TW9iYmFLays5Q1Bwang0MFFsbTh4aU13aWczMzZudEI4MzZ6VWNHQjJLYWc2?=
 =?utf-8?B?UnpuUkNFcHhzdmZJUkprQnJlaWo5NEhIRzkwSHYycGV3cUI0eDViMllIbjFN?=
 =?utf-8?B?U24xMXZHREQvNWo4djJOT1BEL094dHhlK0lDWVk4dGlRS0RyMzU5d21OQjRT?=
 =?utf-8?B?UjZKK3NSaHpJTWRyRmZyZ29oWFE3RGdVOWduc2tEdTNZUE9sYm5TV0pFdkcw?=
 =?utf-8?B?VHdRQlV0NXYyQ1ovUXJHSGFMQUFJSEgzTjFTY0wzTjFiVDZUM3VDQ1VRZmoy?=
 =?utf-8?B?Z1B2MjBvL1J6RVM4ZHJkT2NyWkZwaDdGcGlDRlFSZ3cxWkxzb3BZbng5bkhI?=
 =?utf-8?B?ZGZ1YTZUQUNoK1NWeGlmMmtqT3lRNDM3TjRvUlRDa2VFNHR3L0Z6cGpBVDRT?=
 =?utf-8?B?S3llZ0htUi8rdSt6OXhGYWc1VDlOMXJxa3MrL09ndExSWGtlZnY2bnJOSmVw?=
 =?utf-8?B?bWphZ244Rk9QVGNRQnZvVlpBVWo4NDdoS2xvMUowRkRodEQwL2ZYMnExbVla?=
 =?utf-8?B?aHdHT0I5RFJZU2xFR1hjNW4xdW55eVNDbE1NaEFyNktRbDFjNXl4TnA4Mmtq?=
 =?utf-8?B?TkZDbEZ5Q0ErRUNLeW1JNnVha202STN1ZE1MRWU5OEhnM0ZsN3ZTWU1sOWth?=
 =?utf-8?B?VWRXdndWS3dSUjQrQmFsQ09TeUhLME9oc0hucHpMMThhWS85d2ZvOEVoZWd0?=
 =?utf-8?B?bzdWbmc1TjQyelc4bVpISVIwSFJnQXR0VzI3K2NDbVVvN0xaU0ZkYjRZSVNT?=
 =?utf-8?B?MElaR3hYWHF0QlhNQmZQb2owQm9jZG5rd2x5Q281OFY2aGo1WGJrQnB3cEhT?=
 =?utf-8?B?YW5ITFdvazNoSk1VRzJrSUo0TnA2aHYwWkFrT21UR2JqZkFlZWJBUm1jWG1L?=
 =?utf-8?Q?+ednBVuOa7WLqK/vq+cWxlJP839Xgjs5ba9IPj0UAmYyV?=
X-MS-Exchange-AntiSpam-MessageData-1: hgUVHm6+ah8SgA==
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69e8a85f-ae4d-4233-cf10-08da21d52d9e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2526.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 07:21:10.6604
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: igMbDUsZOrFMIq4kpIfz18eDLutwSIYs826VxkYbsqW+EhbjgEUjwBPlnyH7tbbXIYZScJvarou1RWBvgQ5RWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5091
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 18.04.22 16:18, Yunbo Yu wrote:
> It is unnecessary to call spin_lock_bh() for you are already in a tasklet.
>
> Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>
>
Acked-by: Oliver Neukum <oneukum@suse.com>