Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220419071855.23338-1-guozhengkui@vivo.com> <7cb4d3be-925f-05bd-78fe-67a69dfee18d@deltatee.com>
In-Reply-To: <7cb4d3be-925f-05bd-78fe-67a69dfee18d@deltatee.com>
From:   Alexander Fomichev <fomichev.ru@gmail.com>
Date:   Wed, 20 Apr 2022 11:46:28 +0300
Message-ID: <CAEKnZG4qTOn8mbTNPaaHbkttnfLz9Nc88DpCcm84T32hiPA5uQ@mail.gmail.com>
Subject: Re: [PATCH] ntb_perf: fix doubletest cocci warning
To:     Logan Gunthorpe <logang@deltatee.com>
Cc:     Guo Zhengkui <guozhengkui@vivo.com>, Jon Mason <jdmason@kudzu.us>,
        Dave Jiang <dave.jiang@intel.com>,
        Allen Hubbe <allenbh@gmail.com>,
        Yang Li <yang.lee@linux.alibaba.com>,
        Serge Semin <fancer.lancer@gmail.com>,
        "open list:NTB DRIVER CORE" <ntb@lists.linux.dev>,
        open list <linux-kernel@vger.kernel.org>,
        zhengkui_guo@outlook.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thanks, nice catch.
I'll include it into the next patch version.

Regards,
Alexander.

=D0=B2=D1=82, 19 =D0=B0=D0=BF=D1=80. 2022 =D0=B3. =D0=B2 18:50, Logan Gunth=
orpe <logang@deltatee.com>:
>
>
>
> On 2022-04-19 01:18, Guo Zhengkui wrote:
> > `!data->ops.init` has been repeated triple. The original logic is to
> > check whether `.init`, `.run` and `.clear` callbacks are NULL or not.
> >
> > Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
>
> This appears to be a patch against Alexander's patch which has not been
> accepted yet. Posting a note on his patch so he fixes it for the next
> posting would be preferable.
>
> Logan
>
> > ---
> >  drivers/ntb/test/ntb_perf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> > index c106c3a5097e..dcae4be91365 100644
> > --- a/drivers/ntb/test/ntb_perf.c
> > +++ b/drivers/ntb/test/ntb_perf.c
> > @@ -1451,7 +1451,7 @@ static void perf_ext_lat_work(struct work_struct =
*work)
> >  {
> >       struct perf_ext_lat_data *data =3D to_ext_lat_data(work);
> >
> > -     if (!data->ops.init || !data->ops.init || !data->ops.init) {
> > +     if (!data->ops.init || !data->ops.run || !data->ops.clear) {
> >               struct perf_ctx *perf =3D data->perf;
> >
> >               data->status =3D -EFAULT;