Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp173916pxb; Wed, 20 Apr 2022 19:15:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSdtufNw5XXu4p/wmCCrMDgRXBcvQiyK4z6gE1hRdKfivGaowkb1D1lG5SD6xFQjO2ohW5 X-Received: by 2002:a05:6a00:4104:b0:50a:b521:5bc9 with SMTP id bu4-20020a056a00410400b0050ab5215bc9mr9486821pfb.52.1650507315679; Wed, 20 Apr 2022 19:15:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650507315; cv=none; d=google.com; s=arc-20160816; b=kE+89iFmJ2nwCsvTd2g+N87hVmEB2PQg4WFyAouMDd46wWfHBkKHzqXbo5mmIg03mU QEBHVUvMOESa+1uZqWflbjg1Mw4ZGjWDh5yWXyAOXSCuGoqyNRT4rq2nkbOd6PypXID6 ikgnHPU4tb+IR1uTYkUAoyWz8y/KrVnYn4u1gb/6LYOhh/wjdDj8TBIOKLq0HiMuTQaD FCvvUNzFBTXlAGMPZt3eqFuKLh0D0/TeeA16bW0RkBIpX1ipZd4OuCPsBi/x7AoYzkhO BiZWVtHRrO4OdRSFyW9XAJo/BqyzNioQ5+cQO0XoIDpoOZ/R7mTkCkLnU+r4eZNwWLTo +69g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=z/KP4/KkpMP6MJbyckq/HXRre8Q+pFR1YmktFnJPFjI=; b=Z/hTV5UZpuIhE3Yc3Esu6nBz+viodCh7ZkFVtfxUlXwI6RLYCWy52RoAWoljYZXAsH zAE/DHIxxfLBG3xWnUajj0v6HgLbTWcJk0nov4G1AU4Rg8uPh7Qlm9Wvan6h+gCcb95D avXZPY39zbibPTufkDQKGZD+YJc1G64UNH0dYar2GTdCoW0k2Rxu8fr88KDfE51TpMAq 15WXDDEw6cGtB5eeTwIZKyZpausLWPVatpt1F6YwQaNKx+Cy+AGe5OfA7Mj5nRlmyoZr OlWVvpQO0cp97D6giAtFnwVL/6zZ4+QyDm97DYAOKi/BAGbskOSfphMRd3v1IVS8j0VU LENg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y13-20020a056a00180d00b004fa3a8dff4dsi4106518pfa.4.2022.04.20.19.14.27; Wed, 20 Apr 2022 19:15:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353900AbiDSPid (ORCPT + 99 others); Tue, 19 Apr 2022 11:38:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353862AbiDSPia (ORCPT ); Tue, 19 Apr 2022 11:38:30 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B12D13F28 for ; Tue, 19 Apr 2022 08:35:47 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngpt7-0003su-Fg; Tue, 19 Apr 2022 17:35:33 +0200 Received: from pengutronix.de (2a03-f580-87bc-d400-53ed-3d96-8b26-5d5d.ip6.dokom21.de [IPv6:2a03:f580:87bc:d400:53ed:3d96:8b26:5d5d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 9BC3166BF1; Tue, 19 Apr 2022 15:35:30 +0000 (UTC) Date: Tue, 19 Apr 2022 17:35:30 +0200 From: Marc Kleine-Budde To: Pavel Pisa Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org, Oliver Hartkopp , Wolfgang Grandegger , David Miller , Rob Herring , mark.rutland@arm.com, Carsten Emde , armbru@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Marin Jerabek , Ondrej Ille , Jiri Novak , Jaroslav Beran , Petr Porazil , Pavel Machek , Drew Fustini , Mataj Vasilevski Subject: Re: [PATCH v8 0/7] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation Message-ID: <20220419153530.w2iovki72udt4o6q@pengutronix.de> References: <202203220918.33033.pisa@cmp.felk.cvut.cz> <20220322092212.f5eaxm5k45j5khra@pengutronix.de> <202204061020.42943.pisa@cmp.felk.cvut.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="han226cj42x6fohc" Content-Disposition: inline In-Reply-To: <202204061020.42943.pisa@cmp.felk.cvut.cz> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --han226cj42x6fohc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 06.04.2022 10:20:42, Pavel Pisa wrote: > Hello Marc and others, >=20 > On Tuesday 22 of March 2022 10:22:12 Marc Kleine-Budde wrote: > > On 22.03.2022 09:18:32, Pavel Pisa wrote: > > > > The driver looks much better now. Good work. Please have a look at = the > > > > TX path of the mcp251xfd driver, especially the tx_stop_queue and > > > > tx_wake_queue in mcp251xfd_start_xmit() and mcp251xfd_handle_tefif(= ). A > > > > lockless implementation should work in your hardware, too. > > > > > > Is this blocker for now? I would like to start with years tested base. > > > > Makes sense. >=20 > I have missed timing for 5.18 but v5.18-rc1 is out so I would be > happy if we do not miss 5.19 merge window at least with minimal version. I've taken the patch (almost) as is, I marked both can_bittiming_const static, as sparse complained about that and I changed the order of two variable declarations to look nicer :) Looking forward for more patches! regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --han226cj42x6fohc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmJe1r8ACgkQrX5LkNig 012gmQf/cwPZqvtOnsCpr8islfiXx2a2TAZ8CfYj/LmEqyHKv9BOzaEdM6mRQfKO e6PZz8SEJsQOfD+p5/a701EoqSGRVv/tzUyN49hsYT8aCHYzwMylpDZr6+t1Fafv 9RID31WTw8Lt4MsQlpnLgDEoLc7BdcRZZdFfIUcXbAdDKIcivk9n+6Y08Mwh8ORA wpE1xQ3lyFYPTASD1hfELoJnGFyY6zMfZ6f1Ahjz+T6Am7SQOKrNVk8lfSFKgvuj u5XS8l+eW3QKI0RFIGzLv9AMHswDDsSHy83lu2xpNt6mbudToZAxOA+RmH3cNyOl +nk/MhI6ljXPoL3gLsZGWvQTsyWxBQ== =HGSt -----END PGP SIGNATURE----- --han226cj42x6fohc--