Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Apr 2022 17:45:21 +0800
From:   Xu Yilun <yilun.xu@intel.com>
To:     Nava kishore Manne <navam@xilinx.com>
Cc:     Joe Perches <joe@perches.com>, "mdf@kernel.org" <mdf@kernel.org>,
        "hao.wu@intel.com" <hao.wu@intel.com>,
        "trix@redhat.com" <trix@redhat.com>,
        Michal Simek <michals@xilinx.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>, git <git@xilinx.com>
Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues
Message-ID: <20220419094521.GA322948@yilunxu-OptiPlex-7050>
References: <20220416133719.3382895-1-nava.manne@xilinx.com>
 <20220416133719.3382895-3-nava.manne@xilinx.com>
 <ac22068dad06fd61f2e82c0bf7c0f58a4e5df050.camel@perches.com>
 <SN6PR02MB45763D1B949353F99AAFE7D8C2F39@SN6PR02MB4576.namprd02.prod.outlook.com>
 <d56ad1bc0ef918cc8395b7c0ec7bdd10baf4c1f6.camel@perches.com>
 <SN6PR02MB45761359B029B065092F8691C2F29@SN6PR02MB4576.namprd02.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <SN6PR02MB45761359B029B065092F8691C2F29@SN6PR02MB4576.namprd02.prod.outlook.com>
Precedence: bulk

On Tue, Apr 19, 2022 at 08:15:57AM +0000, Nava kishore Manne wrote:
> Hi Joe,
> 
> 	Please find my response inline.
> 
> > -----Original Message-----
> > From: Joe Perches <joe@perches.com>
> > Sent: Monday, April 18, 2022 6:04 PM
> > To: Nava kishore Manne <navam@xilinx.com>; mdf@kernel.org;
> > hao.wu@intel.com; yilun.xu@intel.com; trix@redhat.com; Michal Simek
> > <michals@xilinx.com>; linux-fpga@vger.kernel.org; linux-
> > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; git
> > <git@xilinx.com>
> > Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues
> > 
> > On Mon, 2022-04-18 at 09:54 +0000, Nava kishore Manne wrote:
> > > Hi Joe,
> > >
> > > 	Please find my response inline.
> > >
> > > > -----Original Message-----
> > > > From: Joe Perches <joe@perches.com>
> > > > Sent: Saturday, April 16, 2022 10:29 PM
> > 
> > > > On Sat, 2022-04-16 at 19:07 +0530, Nava kishore Manne wrote:
> > > > > fixes the below checks reported by checkpatch.pl Lines should not
> > > > > end with a '('
> > > > > Alignment should match open parenthesis
> > > >
> > > > in fpga-mgr:
> > > > 	Another possibillty would be to change the function arguments
> > > >
> 
> This API is there for a long back. Not sure changing the function arguments is fine or Not.
> @yilun: Is it ok to change the function arguments?

Joe's example code below doesn't actually change any function definition.
It just tries to store the value of 'min(mgr->mops->initial_header_size, count)'
in 'count', thus to reduce the length of the 'fpga_mgr_write_init(...)'
expression.

So I think it is OK.

Thanks,
Yilun

> 
> > > > and
> > > >
> > > > in fpga-region:
> > > > 	Ideally keep the include declaration and definition styles synced
> > >
> 
> Will fix it in next version.
> 
> Regards,
> Navakishore.