Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Apr 2022 11:11:35 -0700
From:   Jacob Pan <jacob.jun.pan@linux.intel.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>
Cc:     "zhangfei.gao@foxmail.com" <zhangfei.gao@foxmail.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        jean-philippe <jean-philippe@linaro.org>,
        "Peter Zijlstra" <peterz@infradead.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        x86 <x86@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        iommu <iommu@lists.linux-foundation.org>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "Lutomirski, Andy" <luto@kernel.org>,
        "Poimboe, Josh" <jpoimboe@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID
 allocation and free it on mm exit
Message-ID: <20220418111135.6260d450@jacob-builder>
In-Reply-To: <BN9PR11MB52765490BFC5F08CD4F7A9208CF39@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <tencent_9920B633D50E9B80D3A41A723BCE06972309@qq.com>
        <f439dde5-0eaa-52e4-9cf7-2ed1f62ea07f@intel.com>
        <tencent_F73C11A7DBAC6AF24D3369DF0DCA1D7E8308@qq.com>
        <a139dbad-2f42-913b-677c-ef35f1eebfed@intel.com>
        <tencent_B683AC1146DB6A6ABB4D73697C0D6A1D7608@qq.com>
        <YlWBkyGeb2ZOGLKl@fyu1.sc.intel.com>
        <tencent_A9458C6CEBAADD361DA765356477B00E920A@qq.com>
        <tencent_8B6D7835F62688B4CD069C0EFC41B308B407@qq.com>
        <YllADL6uMoLllzQo@fyu1.sc.intel.com>
        <99bcb9f5-4776-9c40-a776-cdecfa9e1010@foxmail.com>
        <YllN/OmjpYdT1tO9@otcwcpicx3.sc.intel.com>
        <tencent_CD35B6A6FBB48186B38EF641F088BAED1407@qq.com>
        <20220415140002.7c12b0d2@jacob-builder>
        <BN9PR11MB52765490BFC5F08CD4F7A9208CF39@BN9PR11MB5276.namprd11.prod.outlook.com>
Organization: OTC
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Kevin,

On Mon, 18 Apr 2022 06:34:19 +0000, "Tian, Kevin" <kevin.tian@intel.com>
wrote:

> > From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > Sent: Saturday, April 16, 2022 5:00 AM
> > 
> > Hi zhangfei.gao@foxmail.com,
> > 
> > On Fri, 15 Apr 2022 19:52:03 +0800, "zhangfei.gao@foxmail.com"
> > <zhangfei.gao@foxmail.com> wrote:
> >   
> > > >>> A PASID might be still used even though it is freed on mm exit.
> > > >>>
> > > >>> process A:
> > > >>> 	sva_bind();
> > > >>> 	ioasid_alloc() = N; // Get PASID N for the mm
> > > >>> 	fork(): // spawn process B
> > > >>> 	exit();
> > > >>> 	ioasid_free(N);
> > > >>>
> > > >>> process B:
> > > >>> 	device uses PASID N -> failure
> > > >>> 	sva_unbind();
> > > >>>
> > > >>> Dave Hansen suggests to take a refcount on the mm whenever
> > > >>> binding  
> > the  
> > > >>> PASID to a device and drop the refcount on unbinding. The mm
> > > >>> won't  
> > be  
> > > >>> dropped if the PASID is still bound to it.
> > > >>>
> > > >>> Fixes: 701fac40384f ("iommu/sva: Assign a PASID to mm on PASID
> > > >>> allocation and free it on mm exit")
> > > >>>  
> > Is process A's mm intended to be used by process B? Or you really should
> > use PASID N on process B's mm? If the latter, it may work for a while
> > until B changes mapping.
> > 
> > It seems you are just extending the life of a defunct mm?
> >   
> 
> IMHO the intention is not to allow B to access A's mm.
> 
> The problem is that PASID N is released on exit() of A and then
> reallocated to B before iommu driver gets the chance to quiesce
> the device and clear the PASID entry. According to the discussion
> the quiesce operation must be done when driver calls unbind()
> instead of in mm exit. In this case a failure is reported when
> B tries to call bind() on PASID N due to an already-present entry.
> 
> Dave's patch extending the life of A's mm until unbind() is called.
> With it B either gets a different PASID before A's unbind() is 
> completed or same PASID N pointing to B's mm after A's unbind().
> 
As long as B gets a different PASID, that is fine. It seems PASID N has no
use then.

> Thanks
> Kevin


Thanks,

Jacob