Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f6c24447-2ed5-163a-8853-d70253eed0e8@linux.ibm.com>
Date:   Wed, 20 Apr 2022 20:31:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH v8 1/2] s390x: KVM: guest support for topology function
Content-Language: en-US
To:     Heiko Carstens <hca@linux.ibm.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc:     kvm@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org, borntraeger@de.ibm.com,
        frankja@linux.ibm.com, cohuck@redhat.com, david@redhat.com,
        thuth@redhat.com, gor@linux.ibm.com, wintera@linux.ibm.com,
        seiden@linux.ibm.com, nrb@linux.ibm.com
References: <20220420113430.11876-1-pmorel@linux.ibm.com>
 <20220420113430.11876-2-pmorel@linux.ibm.com> <Yl/27Pz3pvARmIHn@osiris>
 <20220420152241.4d9edea5@p-imbrenda> <YmBQD278Uje6LXly@osiris>
From:   Pierre Morel <pmorel@linux.ibm.com>
In-Reply-To: <YmBQD278Uje6LXly@osiris>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/20/22 20:25, Heiko Carstens wrote:
> On Wed, Apr 20, 2022 at 03:22:41PM +0200, Claudio Imbrenda wrote:
>> On Wed, 20 Apr 2022 14:05:00 +0200
>> Heiko Carstens <hca@linux.ibm.com> wrote:
>>
>>>> +static inline bool kvm_s390_topology_changed(struct kvm_vcpu *vcpu)
>>>> +{
>>>> +	if (!test_kvm_facility(vcpu->kvm, 11))
>>>> +		return false;
>>>> +
>>>> +	/* A new vCPU has been hotplugged */
>>>> +	if (vcpu->arch.prev_cpu == S390_KVM_TOPOLOGY_NEW_CPU)
>>>> +		return true;
>>>> +
>>>> +	/* The real CPU backing up the vCPU moved to another socket */
>>>> +	if (cpumask_test_cpu(vcpu->cpu,
>>>> +			     topology_core_cpumask(vcpu->arch.prev_cpu)))
>>>> +		return true;
>>>> +
>>>> +	return false;
>>>> +}
>>>
>>> This seems to be wrong. I'd guess that you need
>>>
>>> 	if (cpumask_test_cpu(vcpu->cpu,
>>> 			     topology_core_cpumask(vcpu->arch.prev_cpu)))
>>> -->		return false;
>>> -->	return true;
>>
>> so if the CPU moved to a different socket, it's not a change?
>> and if nothing happened, it is a change?
> 
> How do you translate the above code to your statement?
> 

Take care that the comment is also wrong.
I will of course change it too.

-- 
Pierre Morel
IBM Lab Boeblingen