Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kavyasree.Kotagiri@microchip.com>
To:     <Horatiu.Vultur@microchip.com>, <linux-gpio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <linus.walleij@linaro.org>, <alexandre.belloni@bootlin.com>,
        <Horatiu.Vultur@microchip.com>
Subject: RE: [PATCH] pinctrl: ocelot: Fix for lan966x
Thread-Topic: [PATCH] pinctrl: ocelot: Fix for lan966x
Thread-Index: AQHYT2xgrw7CXd8+10e0lHE9OjwwDaz4YWvg
Date:   Wed, 20 Apr 2022 06:32:30 +0000
Message-ID: <CO1PR11MB4865F8C372AC4CD2E19CCAF792F59@CO1PR11MB4865.namprd11.prod.outlook.com>
References: <20220413192918.3777234-1-horatiu.vultur@microchip.com>
In-Reply-To: <20220413192918.3777234-1-horatiu.vultur@microchip.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OueL35n4MMX9xZmzKIL6nMlH+QzNAu2YdtWQSY2lepSkg53Zq4pqMOqZznKv?=
 =?us-ascii?Q?qxy2QDVV9Qv8QZWuPbQvV662an6JfnO1VsRiYxOcOp0BcqjQx5N78Ga3n82y?=
 =?us-ascii?Q?/T7rIJuJSUnQfXSvFc0Lc9Kboq/qY9RQEgJEdAZl2GtLijkPMnSvhC9iZxUQ?=
 =?us-ascii?Q?J4tWsyAQZmaK8ObFwvg/pt/W36EsB2GYQPfL04vtT4S52/I3qqGsOInLqwke?=
 =?us-ascii?Q?+iMhNghz6xBufQsdiefk0UCwxv4UsAAB7qHjShovVNX6RiesrbXqL01Oc6pB?=
 =?us-ascii?Q?Abu8YlUiLNeFfKFQjYW2E8uhlsxOtrz+Dg4LeIwcQ7PsTmv3l0qop7kpsTxd?=
 =?us-ascii?Q?QP6aD0NqrwOexlHgQC32iEEJAEL8Xv1vgz7EjhLwN/mB2i7pd+vzRDIAGC8z?=
 =?us-ascii?Q?EnrZA8np6vEmUNM4Q1Gss4o/hJ65QhJnJRnkN0kRLAO7g8JJl+ii523R/FML?=
 =?us-ascii?Q?zeiWl+G7LUjK0GCa5335IYwG2aIc6c5wSsRZph6UQMYsH/aDEzci9FcJ7dCa?=
 =?us-ascii?Q?wqV5eAQx9WUpfIuwPJGre2S9V4j4VgVdNrhOsXSfBfh153EjEPCuC1IrB7nw?=
 =?us-ascii?Q?TZdA+13JM1taEii0r5V+V/oCP9RiMO+1Z0dlm98ysy7YXcO1oDHibjn6UwWH?=
 =?us-ascii?Q?FKSqqzqqoznuaYeRsOswFgRh7mIacU9NP+zVlVk1i2MNMtCjDFc51JyC7rZ4?=
 =?us-ascii?Q?XVArkVd/5FKs3DozB5591159IQ9nhZNBVSnEXEnGBJrbijc/mz7cP5EJlrDK?=
 =?us-ascii?Q?9trPYezCGPzyPwcUwSSBGTlUNLvT3bDJ3gtbUdjhyWfey15Vf4QCuwalfhzj?=
 =?us-ascii?Q?J//wzrSdq8I+l5qVIcwW12rh554MQ+dWMAkSfNWTHtahGCyD6W+HRfNh6NO7?=
 =?us-ascii?Q?tdc3JKCjKCDI7HlTygUC8wKgCYOFHtYi0/O7SvWe5C6SNuMSvoyUcrnx2BXh?=
 =?us-ascii?Q?x9h/Wc0RD/f8C/oP2hmTH1UdMfrnK/Z+4MMWnUU9IT/EQFXo0/wbLsYivOXr?=
 =?us-ascii?Q?YGV648X+G/Lxfm4zKo6oWnZPOUBOtNUcKb9N+LDL8wPn5ewnMmJJA/fLqqos?=
 =?us-ascii?Q?DCMan5IzxVPmdY2VDgfU/zLi9JS7FEOFOpYPvwSXYp0q2AnPZjhcIqmbRXuh?=
 =?us-ascii?Q?CdRbNxyXu+zri7Vqc7I3Zd32IeBKhe4w/KZbzaQvRXvfSIOqYhhMDxXOgh+j?=
 =?us-ascii?Q?vs05p58AwuFF6q5jbHmkk8GmSwo2a3NLy2RYvmqaeQR2HL93dmJPUyoPmLb8?=
 =?us-ascii?Q?68SxQLwE3uRUA9v4e6pufBHfbJBUTIWEHX6s//D4J0Qsfx1fOnxcj2bEjY1P?=
 =?us-ascii?Q?CkYMXp85bVFB8z2NePvOQlCi0GyrzHwM8MdQirCV4HlmApNXdm8Rj6LEbOJo?=
 =?us-ascii?Q?fmVFpAdJezVQQT41owb/VbpAnIpqA3hvqHPTWm1j/Pnada/p3MWl6x/DDQYg?=
 =?us-ascii?Q?LD1oAF3gtBH78m9Q/BA5/XzhgzRdFJaxRW84HIitcOEi9UZnAwtxKpkBcSii?=
 =?us-ascii?Q?11amjj5ghJ3Bqqn9fBOBIWg3RzpIl0yF3Mvqt4dGnHbx3vlHT4piXUv43Pm/?=
 =?us-ascii?Q?Q6ygffuvAE6lw8ekcUXhZs+tDsOkp5dKoOBExyLV/KnTgwm0upnL88VKACT+?=
 =?us-ascii?Q?omj1DdEi5scDlpZVnTTGIKzgy3RRqiNcHr9ql7ED8vgb8w9WOZrbdiafYT5P?=
 =?us-ascii?Q?/I9Wiju5ALfe/0CVXgS4ZdWQSpLRtTvGmR0zX+TG538n98Kq0K7ElbnvfctZ?=
 =?us-ascii?Q?c/+c0ciQpd+u4SkeeYR7oIep+QJ7cgs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4865.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 132d1093-d668-4b26-1b8b-08da22978be3
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2022 06:32:30.8356
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uQZTpBEbvkBqIbvJRapAwTjkXys44IN/QtCSQhcc51rY5fW7wucxHVUbYdFZC7yyDLqgoW/qFLGAs+gtz+CnBt1SdArt9aBd0B1/oVXBkvV6YRqHHzYSwrsZztkPJT3E
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2720
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> For lan966x, the GPIO 35 has the wrong function for alternate mode 2.
> The mode is not none but is PTP sync.
>=20
> Fixes: 531d6ab36571c2 ("pinctrl: ocelot: Extend support for lan966x")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>

> ---
>  drivers/pinctrl/pinctrl-ocelot.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-o=
celot.c
> index 51261f1231cc..40f76e4144e4 100644
> --- a/drivers/pinctrl/pinctrl-ocelot.c
> +++ b/drivers/pinctrl/pinctrl-ocelot.c
> @@ -130,6 +130,7 @@ enum {
>  	FUNC_PTP1,
>  	FUNC_PTP2,
>  	FUNC_PTP3,
> +	FUNC_PTPSYNC_0,
>  	FUNC_PTPSYNC_1,
>  	FUNC_PTPSYNC_2,
>  	FUNC_PTPSYNC_3,
> @@ -253,6 +254,7 @@ static const char *const ocelot_function_names[] =3D =
{
>  	[FUNC_PTP1]		=3D "ptp1",
>  	[FUNC_PTP2]		=3D "ptp2",
>  	[FUNC_PTP3]		=3D "ptp3",
> +	[FUNC_PTPSYNC_0]	=3D "ptpsync_0",
>  	[FUNC_PTPSYNC_1]	=3D "ptpsync_1",
>  	[FUNC_PTPSYNC_2]	=3D "ptpsync_2",
>  	[FUNC_PTPSYNC_3]	=3D "ptpsync_3",
> @@ -984,7 +986,7 @@ LAN966X_P(31,   GPIO,   FC3_c,     CAN1,      NONE,
> OB_TRG,   RECO_b,      NON
>  LAN966X_P(32,   GPIO,   FC3_c,     NONE,   SGPIO_a,     NONE,  MIIM_Sa,
> NONE,        R);
>  LAN966X_P(33,   GPIO,   FC1_b,     NONE,   SGPIO_a,     NONE,  MIIM_Sa,
> MIIM_b,        R);
>  LAN966X_P(34,   GPIO,   FC1_b,     NONE,   SGPIO_a,     NONE,  MIIM_Sa,
> MIIM_b,        R);
> -LAN966X_P(35,   GPIO,   FC1_b,     NONE,   SGPIO_a,   CAN0_b,     NONE,
> NONE,        R);
> +LAN966X_P(35,   GPIO,   FC1_b,  PTPSYNC_0, SGPIO_a,   CAN0_b,     NONE,
> NONE,        R);
>  LAN966X_P(36,   GPIO,    NONE,  PTPSYNC_1,    NONE,   CAN0_b,     NONE,
> NONE,        R);
>  LAN966X_P(37,   GPIO, FC_SHRD0, PTPSYNC_2, TWI_SLC_GATE_AD, NONE,
> NONE,      NONE,        R);
>  LAN966X_P(38,   GPIO,    NONE,  PTPSYNC_3,    NONE,     NONE,     NONE,
> NONE,        R);
> --
> 2.33.0

Thanks,
Kavya