Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 19 Apr 2022 20:01:51 +0200
From:   Max Kellermann <mk@cm4all.com>
To:     David Howells <dhowells@redhat.com>
Cc:     Max Kellermann <mk@cm4all.com>, linux-cachefs@redhat.com,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: fscache corruption in Linux 5.17?
Message-ID: <Yl75D02pXj71kQBx@rabbit.intern.cm-ag>
References: <Yl7d++G25sNXIR+p@rabbit.intern.cm-ag>
 <YlWWbpW5Foynjllo@rabbit.intern.cm-ag>
 <507518.1650383808@warthog.procyon.org.uk>
 <509961.1650386569@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <509961.1650386569@warthog.procyon.org.uk>
Precedence: bulk

On 2022/04/19 18:42, David Howells <dhowells@redhat.com> wrote:
> Could the file have been modified by a third party?

According to our support tickets, the customers used WordPress's
built-in updater, which resulted in corrupt PHP sources.

We have configured stickiness in the load balancer; HTTP requests to
one website always go through the same web server.  Which implies that
the same web server that saw the corrupt files was the very same one
that wrote the new file contents.  This part surprises me, because
writing a page to the NFS server should update (or flush/invalidate)
the old cache page.  It would be easy for a *different* NFS client to
miss out on updated file contents, but this is not what happened.

On 2022/04/19 18:47, David Howells <dhowells@redhat.com> wrote:
> Do the NFS servers change the files that are being served - or is it
> just WordPress pushing the changes to the NFS servers for the web
> servers to then export?

I'm not sure if I understand this question correctly.  The NFS server
(a NetApp, btw.) sees the new file contents correctly; all other web
servers also see non-corrupt new files.  Only the one web server which
performed the update saw broken files.

Max