Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e4bce8f1-c6f5-cb99-8a1e-97b09ea1f840@oracle.com>
Date:   Wed, 20 Apr 2022 12:12:33 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH 2/4] xen/scsiback: use new command result macros
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Stefano Stabellini <sstabellini@kernel.org>
References: <20220420092503.11123-1-jgross@suse.com>
 <20220420092503.11123-3-jgross@suse.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220420092503.11123-3-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2lVUVNObFRHYzdRZWxjZEhZNzRUaEJURHdnWUJtc1J1NG9oZFluZ1ZJdHht?=
 =?utf-8?B?SXo3WFdFaFlIOHVyQnd1b0pOanpneW9GN1pmS3FBZDJKSFIwZndYUlFrODQ4?=
 =?utf-8?B?VHhzeERPQ3IzTjc1aHdCZVRIU2Z0VmhCUFJsaGZCVzhYTmRQMTdJaE9YUkVp?=
 =?utf-8?B?Z01pdEhXUFVsVVdlRkcxSExYekl2aGhuN213Z0ozaXpQeVllaGo1R0RZWmo1?=
 =?utf-8?B?cElkK2g5VlNWbkwrOHNpMlJhZ3RUb0h0U1NwYlBZOVZoT3VwandOeUk2andG?=
 =?utf-8?B?K2NmV1QwYks4YVpzZkVmY3Exc0owVlFQeVNNYlh4aDhOMWtXL0NHV2N3WHJP?=
 =?utf-8?B?bDBRWDdxTUVnT2Y2N09VNWJIMG9GWERCWERBbnIvMEV4YmxLaGNCMTRDRVdv?=
 =?utf-8?B?MlhDZzROandES1hoT2d4YWw5aVFheE1TbzdlK3dtWVFZajBreUcySER1OGlw?=
 =?utf-8?B?cnRDYVErdkxDaHZ4QWJkNmxNRGhFRmI1d1NEYnpVdjBnTWhnYUhJbDVaL3pr?=
 =?utf-8?B?bXZtUVZEU1Z2ZW4ycVA0OU9ZNk5pQWl5NW95bUtaRGpaazArY0RrbG9CRmpV?=
 =?utf-8?B?bHJqdXd2anVsc2VIY2phbEhBbEZMVlZ5UkpFR3pLeURTVTRKSm05b0VzZStU?=
 =?utf-8?B?RW5rWVUrVnp2QU9VZlJHT2hrUUFSMm9nQWVtRHU5NTJEWjl0NHI1ZkV1eTdQ?=
 =?utf-8?B?Y01ZcnBXcHVZNU9QdmgyRCtuckZkcElxc3B3YVUweWJPYXJ1YXZwUGhhTUFF?=
 =?utf-8?B?QmJkR29YbjI0RjBFV1BCY2pJTE0xVUtZVGQ1K2FXS2xhN2YzMzlrbS9MZGRZ?=
 =?utf-8?B?eTBQRzVhaTk0L3djOVoxRjFnMTdPVk9TODVKME1nVEdRMm1mSzFrQUVjcVZU?=
 =?utf-8?B?RmEvOW5pZ2RCSHk1SUo1VDk3YzMwUCtGOUhoeVlWK3g2c1RJemZXZjBKSXlr?=
 =?utf-8?B?ZVdzSFVqcmxidGM3QmZXVTkxTmlTaDdJMG9nOXkvc0cvSGcreXhzVnE1QS9S?=
 =?utf-8?B?R2hoRG9GbitCeThnM3RyNW81MGkzSGtWSmJzZWVJRE02c2M2NWJMWDdqYmx6?=
 =?utf-8?B?ZjUwN0x0dWtRRStiN2Yrd3dQTEZKczJYQlk0M1o1YzhHQzNQZXpkSENwZDFn?=
 =?utf-8?B?V3c2VDRvd1NGRGNFVHV6ZHJYbFpHS2dXUGdBNHo4bDFPRUEvekh5VXRaSWJ0?=
 =?utf-8?B?ZXdhaE5BS0hKeG9oMWxtc1U1NHhtOVJpOFZ6OXFuQ1NQb0pWRUpTVEtpbzBR?=
 =?utf-8?B?V2Qyb2E0aWdIeHNMZzlCdXdUNENGeFFFK0VnSzRkaitKTjI5akFlbHFBakRE?=
 =?utf-8?B?eW1BR2ZENmxCRktuNkVrR2RoWCtsUzVTUmNTcXpqRGZ0NTNadTZpa2U5a2J3?=
 =?utf-8?B?SDRZNVRZTUFsd1NPMkF1MlJQYTdKMllSb1FPWlJsZ2VuWU45UUVBN3FveDZJ?=
 =?utf-8?B?ckhvZ2EwZUUxYkUyNTVrS3RPeHVHQzVibDgvOXV4VHFGMk9NK2hpdzRyNnVU?=
 =?utf-8?B?bHJFTmREZ0RCOGVrK1VPem92cjZyM1p0NFArM2pMWHhwbkhDUTZqQitWUGpM?=
 =?utf-8?B?NzBhMmVyTDBPUGlqVUxuUlFNOEVsUHFqMjNkQ1h6a2t3ZzQvVitwaXV1OTdn?=
 =?utf-8?B?djl0ZXZTaGl5N3RnQlFiZzUzVTFkVTZWa1lMbkNXVVhxN0R0djVOc2kxazJV?=
 =?utf-8?B?aCthMFN1eVR2bkxveU9rZ0s2dUZ1MElpd0dUTUY5YllPVWp0NDVDNEl2TGtZ?=
 =?utf-8?B?cFlVSzdiNzI3clZCQW5nV0lvb2tzSDk0VXVMZHdnYk5GV3RORVp3RjVyc3k0?=
 =?utf-8?B?OVA5RUJYWDJYSEdOdGkyaG5pc1gvYUZ3NkxJZm0vZlVwNE4vYk4yLzlBVTI1?=
 =?utf-8?B?OVZndFpQYitPSVg4eFFtN0hkdTBPMTlZOEx2bVlRcEIwUXptcTZsYVVkYmpI?=
 =?utf-8?B?bmJQbVYwaGxHYi9JR0ZQZHkrNmhMd0Z2SytRTWRQTVBPRWtqOFJ1UlIwTkE2?=
 =?utf-8?B?VWROcmM4WDdKbTI5YlNmN0ZzcUcwZ3NGNTE2bHBDWXR3R245eWVsS1hQbisz?=
 =?utf-8?B?S3hrdnRacGhTcHNoZHFmTFY1UU92OG8zN3NwR0hvbXZpUExMK0tQTnZBaVZU?=
 =?utf-8?B?MUwrV3FtYzcxTE5RZk16MGtwWU9IT2dTV2t0QnF4VXZ5MU1kWTNkUHg4SURP?=
 =?utf-8?B?Z3haKzhhRWg3bEZ2NkpNczZOenB4bm9ORXBHZjVOa21JWmN2TzJZNzRrWDVF?=
 =?utf-8?B?Q2tKYkJEajBJcWw1b1U4Zm9zVzAwc2VzOXB0a0Jra09CNmRZNXNIQ0FFeWxT?=
 =?utf-8?B?WFlmM3h2ZVdIVm54ZnE5YzJkTUZ1MG9lSnF0ZFdRbWY4SFdyNDhXendkNzFO?=
 =?utf-8?Q?HQO3Wr0c7aEZSvbQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21cdc698-1749-491e-ccec-08da22e896ff
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 16:12:38.8699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: evgORJpYMo0PWFoFJ5dJuArcYc6+AH7yY88q0hKzDeUmdSR9DTYqdb9cQdJTNR9ewK2wNz3BkU2NK6J5uOaY/IaWwmC/vPFyA/RyAY5TgAs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2301
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-20_04:2022-04-20,2022-04-20 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0
 malwarescore=0 mlxlogscore=999 suspectscore=0 spamscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204200097
X-Proofpoint-GUID: DzTvsBdnHLfWy6Tgc-d-yrQb3DCjs0om
X-Proofpoint-ORIG-GUID: DzTvsBdnHLfWy6Tgc-d-yrQb3DCjs0om
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/20/22 5:25 AM, Juergen Gross wrote:
> @@ -569,7 +645,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req,
>   	wait_for_completion(&pending_req->tmr_done);
>   
>   	err = (se_cmd->se_tmr_req->response == TMR_FUNCTION_COMPLETE) ?
> -		SUCCESS : FAILED;
> +		XEN_VSCSIIF_RSLT_RESET_SUCCESS : XEN_VSCSIIF_RSLT_RESET_FAILED;
>   
>   	scsiback_do_resp_with_sense(NULL, err, 0, pending_req);
>   	transport_generic_free_cmd(&pending_req->se_cmd, 0);


You also want to initialize err to XEN_VSCSIIF_RSLT_RESET_FAILED.


And also looking at invocations of scsiback_do_resp_with_sense() I think those may need to be adjusted as well.


-boris