Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <df7e04d86dd64dc85125d536434d93bab3d6314d.camel@intel.com>
Subject: Re: [PATCH v1] thermal/core: change mm alloc method to avoid kernel
 warning
From:   Zhang Rui <rui.zhang@intel.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>,
        Junwen Wu <wudaemon@163.com>, rafael@kernel.org,
        amitk@kernel.org
Cc:     linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        Viresh Kumar <viresh.kumar@linaro.org>
Date:   Tue, 19 Apr 2022 21:54:26 +0800
In-Reply-To: <01f72a07-6adc-4854-eae2-286786d33aab@linaro.org>
References: <20220417125601.18535-1-wudaemon@163.com>
         <a7861e9a6a311f09c03b2e6e47dd4d3283cb58e2.camel@intel.com>
         <01f72a07-6adc-4854-eae2-286786d33aab@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

CC Viresh.

On Tue, 2022-04-19 at 11:14 +0200, Daniel Lezcano wrote:
> On 19/04/2022 10:48, Zhang Rui wrote:
> > On Sun, 2022-04-17 at 12:56 +0000, Junwen Wu wrote:
> > > Very high cooling device max state value makes cooling device
> > > stats
> > > buffer allocation fails,like below.Using kzvalloc instead of
> > > kzalloc
> > > can avoid this issue.
> > 
> > When a cooling device has big max_state, this patch can get ride of
> > the
> > warning here, but still we end up with the read failure of the
> > trans_table in sysfs because it is larger than PAGE_SIZE.
> > 
> > $ cat /sys/class/thermal/cooling_device8/stats/trans_table
> > cat: /sys/class/thermal/cooling_device8/stats/trans_table: File too
> > large
> > 
> > IMO, unless we can fix both places, I'd suggest we skip allocating
> > and
> > creating the broken trans_table attr. Like a prototype patch below
> 
> Why not create a thermal debugfs with real useful information and
> get 
> rid of this broken code ?

The idea looks good to me.

thanks,
rui