Date: Sun, 6 May 2007 19:53:26 +0200
From: Sam Ravnborg <sam@ravnborg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
       Linux Kernel ML <linux-kernel@vger.kernel.org>,
       Miles Lane <miles.lane@gmail.com>
Subject: Re: [Patch] Fix section mismatch of memory hotplug related code.
Message-ID: <20070506175326.GA9855@uranus.ravnborg.org>
References: <20070405163028.4248.Y-GOTO@jp.fujitsu.com> <20070504170421.b1ab2d16.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070504170421.b1ab2d16.akpm@linux-foundation.org>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1637
Lines: 47

On Fri, May 04, 2007 at 05:04:21PM -0700, Andrew Morton wrote:
> On Thu, 05 Apr 2007 17:01:02 +0900
> Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
> 
> > Hello.
> > 
> > This is to fix many section mismatches of code related to memory hotplug.
> > I checked compile with memory hotplug on/off on ia64 and x86-64 box.
> > 
> > ..
> >
> > ===================================================================
> > --- meminit.orig/drivers/acpi/numa.c	2007-04-04 20:15:58.000000000 +0900
> > +++ meminit/drivers/acpi/numa.c	2007-04-04 20:56:34.000000000 +0900
> > @@ -228,7 +228,7 @@ int __init acpi_numa_init(void)
> >  	return 0;
> >  }
> >  
> > -int acpi_get_pxm(acpi_handle h)
> > +int __meminit acpi_get_pxm(acpi_handle h)
> >  {
> >  	unsigned long pxm;
> >  	acpi_status status;
> > @@ -246,7 +246,7 @@ int acpi_get_pxm(acpi_handle h)
> >  }
> >  EXPORT_SYMBOL(acpi_get_pxm);
> >  
> > -int acpi_get_node(acpi_handle *handle)
> > +int __meminit acpi_get_node(acpi_handle *handle)
> >  {
> >  	int pxm, node = -1;
> 
> It doesn't make a lot of sense to export an __init symbol to modules.  I
> guess it's OK in this case, but we get warnings:

It seems wrong to me to first tell linker to discard the code after init and
next to export the symbol to make it available for any module anytime.

Both function are relatively small so better avoid playing games and
drop the __meminit tag.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/