Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2d83eab4-3ba9-6947-690e-2b0fd7de0653@collabora.com>
Date:   Wed, 20 Apr 2022 13:25:53 +0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Cc:     usama.anjum@collabora.com,
        Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>, kernel@collabora.com,
        david@redhat.com, Will Deacon <will@kernel.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH V5 2/2] selftests: vm: Add test for Soft-Dirty PTE bit
Content-Language: en-US
To:     Gabriel Krisman Bertazi <krisman@collabora.com>
References: <20220317103323.94799-1-usama.anjum@collabora.com>
 <20220317103323.94799-2-usama.anjum@collabora.com>
 <87ilsbyshs.fsf@collabora.com>
From:   Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <87ilsbyshs.fsf@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/19/22 12:23 AM, Gabriel Krisman Bertazi wrote:
>> +static void test_vma_reuse(int pagemap_fd, int pagesize)
>> +{
>> +	char *map, *map2;
>> +
>> +	map = mmap(NULL, pagesize, (PROT_READ | PROT_WRITE), (MAP_PRIVATE | MAP_ANON), -1, 0);
>> +	if (map == MAP_FAILED)
>> +		ksft_exit_fail_msg("mmap failed");
>> +
>> +	clear_softdirty();
>> +
>> +	/* Write to the page before unmapping and map the same size region again to check
>> +	 * if same memory region is gotten next time and if dirty bit is preserved across
>> +	 * this type of allocations.
>> +	 */
> This reads weird.  It should *not* be preserved across different
> mappings.  Also, we are not testing if the same region is reused, we are
> depending on it to test the sd bit.
> 
> /* Ensures the soft-dirty bit is reset accross different mappings on the
> same address.  */
Soft dirty bit is always set for new regions (reused or not). I'll
correct the comment and improve this sub test.

-- 
Muhammad Usama Anjum