Date: Sun, 6 May 2007 22:53:20 +0200
From: Wim Van Sebroeck <wim@iguana.be>
To: Dan Williams <dan.j.williams@gmail.com>
Cc: "Curt E. Bruns" <curt.e.bruns@intel.com>,
       Peter Milne <peter.milne@d-tacq.com>,
       Russell King <rmk@arm.linux.org.uk>, linux-kernel@vger.kernel.org,
       Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [2.6.22 patch] iop: combined watchdog timer driver for iop3xx and iop13xx
Message-ID: <20070506205320.GA6486@infomag.infomag.iguana.be>
References: <1177952240.12134.10.camel@dwillia2-linux.ch.intel.com> <20070506095256.GA2521@infomag.infomag.iguana.be> <e9c3a7c20705061313g2b110c4ai478bd3d345de3114@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e9c3a7c20705061313g2b110c4ai478bd3d345de3114@mail.gmail.com>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1002
Lines: 26

Hi Dan,

> >Could you split this patch into 2 patches: one that deals with the moving 
> >of
> >the architecture dependant code (and explaining why) and one with the new
> >watchdog drivers? I will continue my review today.
> >
> 
> I am one of the maintainers of this architecture, (Lennert Buytenhek
> is the other).  I will go ahead and split this up so you can sign-off
> on the watchdog specific bits.  The intent is to move all hardware
> definitions under #include <asm/hardware.h>.  You are right this
> should have been a separate patch.

I reviewed the rest of the code. Looks OK to me. One small remark though:
Can we change the ifdef's in the code as described in section 2 point 2 of
the Documentation/SubmittingPatches document?

Thanks,
Wim.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/