Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp746237pxb; Thu, 21 Apr 2022 09:25:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQiAdFWWNuBKbUdeKCfnv6fXtw8MdW0xQi95Yw7TxXyYpneApfnETim/aJVqnCnGkKV6w4 X-Received: by 2002:a17:906:2f97:b0:6ce:3ef6:94be with SMTP id w23-20020a1709062f9700b006ce3ef694bemr355433eji.136.1650558346381; Thu, 21 Apr 2022 09:25:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650558346; cv=none; d=google.com; s=arc-20160816; b=cDY8ZMOztAVu28eIrh6BeMZ9Vpmh42x0X4mpMZMoaGQQ/qhUjrYqw69/id/PdtxZUR MDWrukocWUKliRbIm3dRvm+J9WoaQvTRKRcq9eNUIb7Tr+4F69zD0drW7pKrPXlKFTId kGpQ90SK9X71KrVaQXgjQQnvOpB5HyxUDSwSJoouXspqotzLrNrJJW6Fp6l+kd1CVx8C uYWEdweN0trC/mntEFYFBt847escd8Yyqfsu8cV6zR5b+VoWe9ptcXEiTPjj20Z8aPay qcAFY4+uydpFiqYQV6z9/l1MRp2cZ9pV962aEu6ONkTQTkE4b/0tUE/WkFDTZq7TIBou zhEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=Rji2I2reAO5jVArMzNPDQCXmvUH5KKkxcntxCrD5bxY=; b=aZ6zcVThMXRqFaJp6313GTzOVWJc6qKr6O3SEYBo4xl3iPGQRZ2wM3F1RaLH9Hsaa4 Uqg0aCVNCuGNvf5zSV4AtEhmq+QZ6cSWRw6h78ZA6ZQ324B7bt11wqCzh2gSJ5pknKm+ wCfdREY4emcmIX470tP94NEUWy6lf1Ni8YnDEvl6+Y3HmnfaYh8vSL/hYhCnbjKbPGuh mUPzxfy4iATwrOT3PRPzQMw5Gkqo2VfQVQe8Nl6MhRtHDgHbMZHKeuh5hGSDvncASCXv ijIiODMHv8+gqAjwEXsWDRwskxX6ABkNJaJHtui3b4y7CbXeaO8DfIw02w1NtgYynPdo zMQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=y9qwEFHv; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b16-20020a0564021f1000b0041d850844f5si4140329edb.262.2022.04.21.09.25.22; Thu, 21 Apr 2022 09:25:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=y9qwEFHv; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386754AbiDUIkX (ORCPT + 99 others); Thu, 21 Apr 2022 04:40:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233704AbiDUIkB (ORCPT ); Thu, 21 Apr 2022 04:40:01 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92840BC1B for ; Thu, 21 Apr 2022 01:37:12 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1650530230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rji2I2reAO5jVArMzNPDQCXmvUH5KKkxcntxCrD5bxY=; b=y9qwEFHvvOljcWHtzGZe0OLEPsHfi+lWBksnqo6l9DJwjQeR17HoWbVki4lDloP5OEDq06 vGsfXtVBZDZ4ReP/K83zDR0GBiWNHGZuwMOp3qmhKFG8Dze4A5rQf30GQrZSVjaRmKkWkk mtaBo26YkJL+JDb2YzKm/ZEr32EVcxJkGad4iZHRMKWfcHZBfeQAOXRJCxSI5zroXCtog3 do4Qx8tK1CkEXhU6R3N8OYeVcplCzBuiNIpboBiYwXreJfazbH+xMRKL0KHeyKpRgj6hhN Bn6tYNuN/LMW1B+DakNZCRKdbIhAXGDsNEsZ7huIw1lD1YRTXRl0IFkNw28F7A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1650530230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Rji2I2reAO5jVArMzNPDQCXmvUH5KKkxcntxCrD5bxY=; b=VfI8yNNKGAsMu2uxgCvJ/NAdq6PSi5uXkbk+5PZa/FR26+C6AFMiFClGdIvZq7Lh7mL3h6 FL3yTJwzdg0CoyBQ== To: Ross Philipson , linux-kernel@vger.kernel.org, x86@kernel.org Cc: ross.philipson@oracle.com, dpsmith@apertussolutions.com, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com, kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com Subject: Re: [PATCH 1/2] x86: Check return values from early_memremap calls In-Reply-To: <1650035401-22855-2-git-send-email-ross.philipson@oracle.com> References: <1650035401-22855-1-git-send-email-ross.philipson@oracle.com> <1650035401-22855-2-git-send-email-ross.philipson@oracle.com> Date: Thu, 21 Apr 2022 10:37:09 +0200 Message-ID: <87a6ceu91m.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ross, On Fri, Apr 15 2022 at 11:10, Ross Philipson wrote: can you please ensure that all relevant maintainers are CC'ed on such patches? XEN and Jailhouse people might have opinions, no? > There are a number of places where early_memremap is called > but the return pointer is not checked for NULL. The call > can result in a NULL being returned so the checks must > be added. Also please follow: https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#function-references-in-changelogs Thanks, tglx