Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 20 Apr 2022 14:00:24 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: fsl: Fix error handling in pcm030_fabric_probe
Message-ID: <YmAD6MIuKdjgm7Yu@sirena.org.uk>
References: <Yh90u+E3RTuGEDWU@sirena.org.uk>
 <20220420021855.8224-1-linmq006@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="efKG2CWXr2Wpj9k0"
Content-Disposition: inline
In-Reply-To: <20220420021855.8224-1-linmq006@gmail.com>
Precedence: bulk


--efKG2CWXr2Wpj9k0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 20, 2022 at 02:18:52AM +0000, Miaoqian Lin wrote:
> This will call twice platform_device_put()
> if both platform_device_add() and snd_soc_register_card() fails.
> return early on error  to avoid duplicating the error code logic.
>=20
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> changes in v2:
> - use return statement to return early when fails
> - rebase on top of commit 559089e0a93d ("vmalloc: replace VM_NO_HUGE_VMAP=
 with VM_ALLOW_HUGE_VMAP")

Why rebase on top of that seemingly random commit?  Is there some sort
of dependency here?

--efKG2CWXr2Wpj9k0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJgA+cACgkQJNaLcl1U
h9DFwAf9GF3I/YlhSyVTcxq76mzScrKVify5IYug75y6034V/V8EfvQpAl74iFSA
j/ojJnAVUN/zwIlJArD+ODRonrsps1Ie9t44AgGOZPvRkniOTvgCjZAJAzTF5gzI
lKevcKZKOTCu30CRsLDQIpozLNGaZHqg108ppkn3pbc+tqL08oBJt4fdGTI7EVhV
eyMPbXa5DGuSSed5CY8zWiHRB7Kr31I20izJje8j92n4UkEvUMnvaUStFXHPVZWo
4z7amWIBtXixq7Kyh6APPmp6cb5jKJv3RFblBzFdbz62n5qFD1erZtzKGja70WT5
j4tg4q5ZVOWv5BVFAnI1ZpCtSSB8/A==
=wBgb
-----END PGP SIGNATURE-----

--efKG2CWXr2Wpj9k0--