Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE: [PATCH v2 4/5] scsi: ufshpb: Add handing of device reset HPB
 regions Infos in HPB device mode
Reply-To: keosung.park@samsung.com
Sender: Keoseong Park <keosung.park@samsung.com>
From:   Keoseong Park <keosung.park@samsung.com>
To:     Bean Huo <huobean@gmail.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        Daejun Park <daejun7.park@samsung.com>,
        "powen.kao@mediatek.com" <powen.kao@mediatek.com>,
        "peter.wang@mediatek.com" <peter.wang@mediatek.com>,
        cpgsproxy3 <cpgsproxy3@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <20220419183044.789065-5-huobean@gmail.com>
Message-ID: <1381713434.41650433982422.JavaMail.epsvc@epcpadp4>
Date:   Wed, 20 Apr 2022 14:31:17 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
References: <20220419183044.789065-5-huobean@gmail.com>
        <20220419183044.789065-1-huobean@gmail.com>
        <CGME20220419183934epcas2p28272bfd9167253c2d9136c60f9050c5f@epcms2p7>
Precedence: bulk

Hi Bean,

>From: Bean Huo <beanhuo@micron.com>
>=20
>In UFS HPB Spec JESD220-3A,
>=20
>"5.8. Active and inactive information upon power cycle
>...
>When the device is powered off by the host, the device may restore L2P map=
 data
>upon power up or build from the host=E2=80=99s HPB READ command. In case d=
evice powered
>up and lost HPB information, device can signal to the host through HPB Sen=
se data,
>by setting HPB Operation as =E2=80=982=E2=80=99 which will inform the host=
 that device reset HPB
>information."
>=20
>Therefore, for HPB device control mode, if the UFS device is reset via the=
 RST_N
>pin, the active region information in the device will be reset. If the hos=
t side
>receives this notification from the device side, it is recommended to inac=
tivate
>all active regions in the host's HPB cache.
>=20
>Signed-off-by: Bean Huo <beanhuo@micron.com>
>---
> drivers/scsi/ufs/ufshpb.c | 73 ++++++++++++++++++++++++++++-----------
> 1 file changed, 53 insertions(+), 20 deletions(-)
>=20
>diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
>index 4538164fc493..4b15fa862beb 100644
>--- a/drivers/scsi/ufs/ufshpb.c
>+++ b/drivers/scsi/ufs/ufshpb.c
>@@ -1143,6 +1143,39 @@ static int ufshpb_add_region(struct ufshpb_lu *hpb,=
 struct ufshpb_region *rgn)
>         spin_unlock_irqrestore(&hpb->rgn_state_lock, flags);
>         return ret;
> }
>+/**
>+ *ufshpb_submit_region_inactive() - submit a region to be inactivated lat=
er
>+ *@hpb: per-LU HPB instance
>+ *@region_index: the index associated with the region that will be inacti=
vated later
>+ */
>+static void ufshpb_submit_region_inactive(struct ufshpb_lu *hpb, int regi=
on_index)
>+{
>+        int subregion_index;
>+        struct ufshpb_region *rgn;
>+        struct ufshpb_subregion *srgn;
>+
>+        /*
>+         * Remove this region from active region list and add it to inact=
ive list
>+         */
>+        spin_lock(&hpb->rsp_list_lock);
>+        ufshpb_update_inactive_info(hpb, region_index);
How about separating the "hpb->stats.rb_inactive_cnt++" code from ufshpb_up=
date_inactive_info()?
Because I think this code should only be used in ufshpb_rsp_req_region_upda=
te().

>+        spin_unlock(&hpb->rsp_list_lock);
>+
>+        rgn =3D hpb->rgn_tbl + region_index;
>+
>+        /*
>+         * Set subregion state to be HPB_SRGN_INVALID, there will no HPB =
read on this subregion
>+         */
>+        spin_lock(&hpb->rgn_state_lock);
>+        if (rgn->rgn_state !=3D HPB_RGN_INACTIVE) {
>+                for (subregion_index =3D 0; subregion_index < rgn->srgn_c=
nt; subregion_index++) {
>+                        srgn =3D rgn->srgn_tbl + subregion_index;
>+                        if (srgn->srgn_state =3D=3D HPB_SRGN_VALID)
>+                                srgn->srgn_state =3D HPB_SRGN_INVALID;
>+                }
>+        }
>+        spin_unlock(&hpb->rgn_state_lock);
>+}
>=20
> static void ufshpb_rsp_req_region_update(struct ufshpb_lu *hpb,
>                                          struct utp_hpb_rsp *rsp_field)
>@@ -1202,25 +1235,8 @@ static void ufshpb_rsp_req_region_update(struct ufs=
hpb_lu *hpb,
>=20
>         for (i =3D 0; i < rsp_field->inactive_rgn_cnt; i++) {
>                 rgn_i =3D be16_to_cpu(rsp_field->hpb_inactive_field[i]);
>-                dev_dbg(&hpb->sdev_ufs_lu->sdev_dev,
>-                        "inactivate(%d) region %d\n", i, rgn_i);
>-
>-                spin_lock(&hpb->rsp_list_lock);
>-                ufshpb_update_inactive_info(hpb, rgn_i);
>-                spin_unlock(&hpb->rsp_list_lock);
>-
>-                rgn =3D hpb->rgn_tbl + rgn_i;
>-
>-                spin_lock(&hpb->rgn_state_lock);
>-                if (rgn->rgn_state !=3D HPB_RGN_INACTIVE) {
>-                        for (srgn_i =3D 0; srgn_i < rgn->srgn_cnt; srgn_i=
++) {
>-                                srgn =3D rgn->srgn_tbl + srgn_i;
>-                                if (srgn->srgn_state =3D=3D HPB_SRGN_VALI=
D)
>-                                        srgn->srgn_state =3D HPB_SRGN_INV=
ALID;
>-                        }
>-                }
>-                spin_unlock(&hpb->rgn_state_lock);
>-
>+                dev_dbg(&hpb->sdev_ufs_lu->sdev_dev, "inactivate(%d) regi=
on %d\n", i, rgn_i);
>+                ufshpb_submit_region_inactive(hpb, rgn_i);
>         }
>=20
> out:
>@@ -1255,7 +1271,10 @@ static void ufshpb_dev_reset_handler(struct ufs_hba=
 *hba)
>=20
>         __shost_for_each_device(sdev, hba->host) {
>                 hpb =3D ufshpb_get_hpb_data(sdev);
>-                if (hpb && hpb->is_hcm)
>+                if (!hpb)
>+                        continue;
>+
>+                if (hpb->is_hcm) {
>                         /*
>                          * For the HPB host mode, in case device powered =
up and lost HPB
For the HPB host control mode, ...

>                          * information, we will set the region flag to be=
 RGN_FLAG_UPDATE,
>@@ -1263,6 +1282,20 @@ static void ufshpb_dev_reset_handler(struct ufs_hba=
 *hba)
>                          * in the UFS device).
>                          */
>                         ufshpb_set_regions_update(hpb);
>+                } else {
>+                        /*
>+                         * For the HPB device mode, we add all active reg=
ions to inactive list,
For the HPB device control mode, ...

>+                         * they will be inactivated later in ufshpb_map_w=
ork_handler()
>+                         */
>+                        struct victim_select_info *lru_info =3D &hpb->lru=
_info;
>+                        struct ufshpb_region *rgn;
>+
>+                        list_for_each_entry(rgn, &lru_info->lh_lru_rgn, l=
ist_lru_rgn)
>+                                ufshpb_submit_region_inactive(hpb, rgn->r=
gn_idx);
>+
>+                        if (ufshpb_get_state(hpb) =3D=3D HPB_PRESENT)
>+                                queue_work(ufshpb_wq, &hpb->map_work);
>+                }
>         }
> }
>=20
>--=20
>2.34.1
>=20
>=20

Best Regards,
Keoseong Park