Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2521bf42605a16847df239c0d7405d3c1b233340.camel@intel.com>
Subject: Re: [PATCH v3 03/21] x86/virt/tdx: Implement the SEAMCALL base
 function
From:   Kai Huang <kai.huang@intel.com>
To:     Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc:     seanjc@google.com, pbonzini@redhat.com, dave.hansen@intel.com,
        len.brown@intel.com, tony.luck@intel.com,
        rafael.j.wysocki@intel.com, reinette.chatre@intel.com,
        dan.j.williams@intel.com, peterz@infradead.org, ak@linux.intel.com,
        kirill.shutemov@linux.intel.com, isaku.yamahata@intel.com
Date:   Wed, 20 Apr 2022 22:39:43 +1200
In-Reply-To: <faf366f9-a0cb-4121-e5bf-c63e6d0b14aa@linux.intel.com>
References: <cover.1649219184.git.kai.huang@intel.com>
         <1c3f555934c73301a9cbf10232500f3d15efe3cc.1649219184.git.kai.huang@intel.com>
         <dd9d6f7d-5cec-e6b7-2fa0-5bf1fdcb79b5@linux.intel.com>
         <d1b88a6e08feee137df9acd2cdf37f7685171f4b.camel@intel.com>
         <faf366f9-a0cb-4121-e5bf-c63e6d0b14aa@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2022-04-20 at 00:29 -0700, Sathyanarayanan Kuppuswamy wrote:
> 
> On 4/19/22 9:16 PM, Kai Huang wrote:
> > On Tue, 2022-04-19 at 07:07 -0700, Sathyanarayanan Kuppuswamy wrote:
> > > 
> > > On 4/5/22 9:49 PM, Kai Huang wrote:
> > > > SEAMCALL leaf functions use an ABI different from the x86-64 system-v
> > > > ABI.  Instead, they share the same ABI with the TDCALL leaf functions.
> > > 
> > > TDCALL is a new term for this patch set. Maybe add some detail about
> > > it in ()?.
> > > 
> > > > 
> > 
> > TDCALL implementation is already in tip/tdx.  This series will be rebased to it.
> > I don't think we need to explain more about something that is already in the tip
> > tree?
> 
> Since you have already expanded terms like TD,TDX and SEAM in this patch
> set, I thought you wanted to explain TDX terms to make it easy for new 
> readers. So to keep it uniform, I have suggested adding some brief 
> details about the TDCALL.
> 
> 

All right.  I can add one sentence to explain it.

-- 
Thanks,
-Kai