Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 20 Apr 2022 11:57:16 +0530
From:   Pratyush Yadav <p.yadav@ti.com>
To:     Michael Walle <michael@walle.cc>
CC:     Tudor Ambarus <tudor.ambarus@microchip.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: move SECT_4K_PMC special handling
Message-ID: <20220420062716.zhs3y4koirjpshqw@ti.com>
References: <20220418112650.2791459-1-michael@walle.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220418112650.2791459-1-michael@walle.cc>
Precedence: bulk

On 18/04/22 01:26PM, Michael Walle wrote:
> The SECT_4K_PMC flag will set a device specific opcode for the 4k sector
> erase. Instead of handling it in the core, we can move it to a
> late_init(). In that late init, loop over all erase types, look for the
> 4k size and replace the opcode.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> Please have a closer look here. This is only compile time tested. Also
> I didn't see much reason to reorder the flags.

Patch looks okay to me but I would like someone to test it on the flash 
before I apply it.

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.