Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 20 Apr 2022 12:42:20 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Rebecca Mckeever <remckee0@gmail.com>
Cc:     outreachy@lists.linux.dev,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: compare strcmp result to zero
Message-ID: <20220420094220.GD2951@kadam>
References: <20220416102434.97567-1-remckee0@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220416102434.97567-1-remckee0@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cy8MUN7IM8JLIifc5jAJUc6iaYDaFrnc3Gyr1EZAJ78+AisJRabnSwKIbF4I?=
 =?us-ascii?Q?jX2sFu6rQVkFbaxdE+tZsshTEnpf++ibxmvphXzr8jQFUUUNHo6aKPBtIinJ?=
 =?us-ascii?Q?61GTgh21oWMR4DEcekHBSULUVIo/wiOeqo6BMG1Wm5qBK81LQP/rBy+odrTx?=
 =?us-ascii?Q?y8Y0zhl9hLapzZQgINI0YEQbljA8xZ/eLPfyDC4tsB1CbDLGN327K8WEpPda?=
 =?us-ascii?Q?x2YGm6OETZeRYl/RMxLtiKUmpr+oFEWcWg2vdMVHSlyF9jPbZlKr7cKvClvy?=
 =?us-ascii?Q?CMoxsg+iHFQE5F6emM2dWiR2OM3mKB/RFQTEatGHgLrwdbjDOwyzy3x+jxc2?=
 =?us-ascii?Q?sf4GCgYS6TZc9s8JvkyLANJgKJakeH2CfWYNZRo9NjG6dGqUmCty7N6YkmTc?=
 =?us-ascii?Q?sPXn4FBHiGJ+e2pwcCZvylfjsOuszIqanzXpghIzOw7FnwXqS27NBIFsr0Ty?=
 =?us-ascii?Q?R6zzAt2iqhGYZpPlj/FAAqM/L7i0h0/7pibxDY9QcbljjVBThFJcWqoGfTg7?=
 =?us-ascii?Q?yJJrfguklIsLC8H0z/6/G2HyVAYISUWQNghrqJZ0HgM0r2dooU0w/Hy55jLk?=
 =?us-ascii?Q?IAsp4UUOaZSvJ3IUe55cHCNl/P2Tl4RbT1XaXEs33+bzsSN5DJBq7L6uqHS9?=
 =?us-ascii?Q?+oH/il1RI+HLGA5MEAFp6c6xMsHUj/RNQLxznflnJJ9wA3Aw66Q9sERlszfT?=
 =?us-ascii?Q?jxUxb7zQXPxVd/94gS+kVQYhGG9p5BLfXv+4/RSH9Z2UQ4eTMEePQEH9v5n1?=
 =?us-ascii?Q?u9wwXsDsj0BartNKUGjkJovs+oHn1M8jgvOiYfM5UVeuduNjS3QhxMs4z+vt?=
 =?us-ascii?Q?v9yB5AR62o5aObLD05aKKa9HeXrwZQEb0PrLsQnBqNeHCaKF3wLohsELSvdE?=
 =?us-ascii?Q?moEoWb1GSVMh/KyGjV9KnJTHfWuyN3GHd6atu0lCUPIzfu2wW1bHRgmbFHFm?=
 =?us-ascii?Q?tfPfVHqxAiQNt++06OSGIysrxUTnCnaIiww6pkgzHA2Dc9bUO/3xF4fTjF2D?=
 =?us-ascii?Q?9790+wIWweRzqYuJnJtmy3g5ZYkv9AgXKYkyyZrzefpAQvVXPSYZJTuWxBR6?=
 =?us-ascii?Q?vTzf+D4WqTo/lNYOZ/ns1BUkE+lJWqGo1Td9oKXqGyAtdI6HstRmFnu2KQ6K?=
 =?us-ascii?Q?rWfFrlaJpgJHj6/ZPLcxa/fqgBRrAHsUmMJPbUYbNpARTlDXploq2bZaPZqy?=
 =?us-ascii?Q?nFY1cjdBtP3H4/ahS/neq86RBmU/+wAa4TTSB5ZkoPTjx3edcTdsk8D6TTIF?=
 =?us-ascii?Q?Nts63/DyrZVlPhX/fkhg/KAkMMhJtmWP8wzJsm9uLyxDQ5ZV9/G+PrYwkgM/?=
 =?us-ascii?Q?7jrpM12Ph8sKtfaOiZtNkSFDODaHCZ6tyk5snMVXkBdUwitUVoivrWRkFQMZ?=
 =?us-ascii?Q?YGb8giGnrhnzegf3pUfztEO4Sm7jkDJOC8hjab2PzFlhanZ4415z2PL4KMa9?=
 =?us-ascii?Q?jhghlZF2RF1JW5BziSjNrNfo+YVbw7gI6zCj7JkabNi8yYnEnH+HXsaJ/pLJ?=
 =?us-ascii?Q?q7xwywAqhaw8dZ67OActJkOKpQ/XujLdUaXUi3SnH4ejs243vQHayxBpU1Nm?=
 =?us-ascii?Q?JSf9Amh7djs7nbmVI8vg6FJeQTsJv50DqcGTEHGYjrBxwAWOhsDTu7JSwMBp?=
 =?us-ascii?Q?JxxwBSebdzRvCLsb/b1UUrecfaQ4kk2qxbVYkSxZzv+44rTfCh2tyTnvbGXh?=
 =?us-ascii?Q?cIL0XTMEX72rTnOnQkhzjIDpot9rc5xONNdeTfjXsZcaHPtaEPuTRtDuXUWT?=
 =?us-ascii?Q?k9jvIcgQLspkogKzhdAirmr/KokAXwU=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6686e760-ccf0-415d-8beb-08da22b21bf2
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 09:42:40.0686
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pn1KJqG/qiuzm6MVfvDLwnZHdcgJrhlN3NygtyF1X+2RBqU7mhWq8kraRQ1RxOvW9Huz/LFzZDCtVXSJWo9GbKwtghha90NWr09q8ggt9pc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3612
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-20_02:2022-04-15,2022-04-20 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0
 adultscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204200060
X-Proofpoint-GUID: WBEpG7BrMMJvL2Mqo3Jm2ZmbR07NZ7yp
X-Proofpoint-ORIG-GUID: WBEpG7BrMMJvL2Mqo3Jm2ZmbR07NZ7yp
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Apr 16, 2022 at 05:24:34AM -0500, Rebecca Mckeever wrote:
> Add " == 0" to the condition in both else if branches to address a
> possible bug. strcmp returns 0 when its arguments are equal, which
> evaluates to false, often leading to errors when used in if statements.
> 
> Currently, the statement in the first else if branch does not execute
> when its arguments are equal, but it does execute when crypt->ops->name
> equals any string other than "WEP" or "TKIP".
> 
> Similarly, the second else if branch does not execute when its arguments
> are equal, and it only executes when crypt->ops->name equals "TKIP".
> The else branch never executes.
> 
> It is unlikely that this is working as intended.
> 
> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> ---

Looks good.  How did you find this bug?

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

> There is a similiar issue in
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> but I'm not sure if it's incorrect. The strcmp on line 2847 isn't
> negated, but the ones on lines 2851, 2853, and 2855 are.
> 
> 2845         /* IPW HW cannot build TKIP MIC, host decryption still needed. */
> 2846         if (!(ieee->host_encrypt || ieee->host_decrypt) &&
> 2847             strcmp(param->u.crypt.alg, "TKIP"))
> 2848                 goto skip_host_crypt;

You're right, but also I suspect this whole if statement is wrong.

The if statement is only triggered if both ->host_encrypt and
->host_decrypt are disabled.  (Too many negatives).  I think both are
set in alloc_ieee80211() and rtl8192_init_priv_variable() so both are
always true and the if statement is dead code.

How does the code match with the comment?

Fixing this probably requires testing.  Maybe we could add this to the
TODO list or maybe add a comment?

regards,
dan carpenter

Ps:  When you have a !(foo || bar) then it's often more readable to
write it as !foo && !bar, but in this case it doesn't really answer any
of the core questions so don't bother.