Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7ff97157-4792-c48c-a06c-ad98884f9e9b@oracle.com>
Date:   Thu, 21 Apr 2022 17:15:24 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v2] xen: Convert kmap() to kmap_local_page()
Content-Language: en-US
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>,
        outreachy@lists.linux.dev
Cc:     jgross@suse.com, sstabellini@kernel.org,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
        ira.weiny@intel.com
References: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220419234328.10346-1-eng.alaamohamedsoliman.am@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjRBK05sdkc0YU5HRE9mZTdUQk95RWkxc1NXa09ZWDIva2dmQjBlaFVkS0Fu?=
 =?utf-8?B?WXo1TitRc212TFlMUE81QnpTUjdTYm1sWnJ6RXVXQk9sbkZvZXlUNGk1VWc3?=
 =?utf-8?B?dzhEVFRZdGN6QXZEeVJnNlpYSXJ4U0x4c1dCUzdaZi9XN3ExMDZ3NFRDSUYz?=
 =?utf-8?B?Mi92NzJya3RxM0RSTnpTTFBveG5HeGVEcEtUYnJKR2hnL1QwZldZZUMveDBs?=
 =?utf-8?B?VmhxaHVoamtaVHZ5RTlQMzJWS21wZHdkZlVlN2J5UHh5SktpQlU5UnVidndk?=
 =?utf-8?B?TElzTDlGQlJiQk5DRTZBVmtXQks5RjVhNkV2bzZxdTFtM3BCTjZhYkpzUGlx?=
 =?utf-8?B?RmpGL2E1UGpvUlZJc3cxV2g1cXVEQWVnUXFnQlRzbitmc3BCMzBVMmw3N2FM?=
 =?utf-8?B?RE9zc04vRnhKVHlkVnVsa3BuR1ZFV2FZeWZhbkZCTktscy9iM08vWERHblhJ?=
 =?utf-8?B?WnpLdHlzbFJBc3JQbSt3SFQ3NllJOXJFZ2JZeWNsZ3dnSzhIRU80NjJqSDdT?=
 =?utf-8?B?TlJiRkhERUM5ZDNrbldRbWhMZnNWajExanAxRExjMUlXcnJWUllBUlQwS2tH?=
 =?utf-8?B?L0oxUW5WS3NaNlNtMCttVXlQNWx1em9FeXFYdDhTcll5V1BJWm8zTUJ6Y21P?=
 =?utf-8?B?T09MR0F3aVM3aHVwSjZRc3hoU2FKaTNhNTZoSUY2dUlQUkMxc1lWVnRCUGRr?=
 =?utf-8?B?WWtRYnJCVDd4NHBmcGlORHpxOGFSNFVFMTJWOTZiM1N0MG8ydjNMN1k0TE5C?=
 =?utf-8?B?ZVZYWUhPdnhKVHNicDZRajFnaERJYkZvRi8weTlZR2xtcEp6dlhHcXNFSXNs?=
 =?utf-8?B?c1ZRdS9nNXE4UlozVE0wM2FPZE5oSDNvSnkrL3Y0Uno4eDcvQkY2YlVrQTQ5?=
 =?utf-8?B?S0NlVUlkWkJpa0hObGRIWHBnNk5RV3ZrSE9YNFBnQy9XZ3hGTlAydVppRERP?=
 =?utf-8?B?MnYxREV2dUdtUXpPVGVJSEU3YThOQVpONWYreXgwRFJuVUFwRWtLc0pZOUtY?=
 =?utf-8?B?dlV4N3lpaG9DOFhFakYwREcwNmlmem8ySnJFdFcrL05tMGFaR0F5YzJxVm1S?=
 =?utf-8?B?b0o0S3dhSnl5Z0lkWFU5eHZoUXAza2xNSG5NU2lsVU9jMFA1a0tCVFBEa0k5?=
 =?utf-8?B?d0U3djFneHRTNGZFKzFIYnZ1anZaS0ZUdm9MOWJNRXk1VkRZRlZlN2xDUUp2?=
 =?utf-8?B?ZU9LTVA3ZUtxVW1HQ1hNTEZtUG0zZStQRGd2WEJBb0ZoR3ZyMkRYeFJsQWR2?=
 =?utf-8?B?Q2JxQ2RuMmN5R0x2eDlDU3lYU1RKTkxaMnJuS3UxZlRKTVJaRlZUWlRBYVI1?=
 =?utf-8?B?SkJneDN6TTNsYlMyaGVyZk1RTzRVaW5MaXZiMVFRaWNjK2ZDc05odThvV1di?=
 =?utf-8?B?bCtqZ3RzYVl1RXVMQXY3TFVUMHJYUEgwUVdnS3VqVGg5VzMyYTFDcStydXNn?=
 =?utf-8?B?andVbFZoTld4YkZLeFowbmw3UnVVQXRZSlVZQW1YRFJ5N2tNT0hBeldPQmJ2?=
 =?utf-8?B?Y2EzRmZUaCtvOFpUZWhnL0ZyQzJLRERXa1Jqa29DY3pRUWw0T2JudWNFVVRk?=
 =?utf-8?B?RUtKZkx6UFBsaWpNZWM3RkNMMmdpdllyQXMvSFBxN1BBaUw0RjFnU2VRdDRu?=
 =?utf-8?B?LzNMUE5oUjJqMVZzUngxNDE4NUMzUXBXM3JzaTBOdWRWOTQ5SzM1bVZEVThC?=
 =?utf-8?B?ZG44VkI4VHlyQjFVeDdsZ09Ua0xwdDZENkcwcThhaTdNYXpUT2YrY2hLUE1X?=
 =?utf-8?B?VVR4aHk1MkJJVEF4UkJOTkM5QzZKYlMzbGtxeC9VZlFMbW9EUWowWm5TUFpB?=
 =?utf-8?B?a2NIdEFiTmtKZjdyMkh5RDgyZW5xQmJzVXk1RFNMVjMwTVlUYXlveVdUR3hS?=
 =?utf-8?B?a0tQa0J1SnhuMHVic3NkN3hnRnFIQTQ1cXZDdkFRUldQV2dvcGZBODVpbWIx?=
 =?utf-8?B?TXNIdHoxT0VnVU1TZHZWY084WHpBV05XSkxZWFJPNUNMY1RIZEJ2QVJYbThY?=
 =?utf-8?B?bWp2T3J4NXJVRXA0aXVEQWIwMFJMV25qSUVTRFRsbWFoN3JFaVRCYmcvcllH?=
 =?utf-8?B?dCtOUDdBdy9naUp6MUdSQThHRDRGRlpoV3k0cTdmQXAvanVnTHRCaTJVWjBX?=
 =?utf-8?B?U3VGbU5oOW4xNVREL2laMThUK29Rd0V5d0FDS0FURFM3MnZQek1IWXV6eSs0?=
 =?utf-8?B?R2pJZlZwbVJQdXBVQ05ZTWdPdDYwN0lLUjNOam5BcmtxNXIrTHdDZmhwS1ZG?=
 =?utf-8?B?SkcyOGlTUWlOMDEyOFM3NkxOaHpxaHVYYXpEYzkyRmRvVGdOa3dROWlGK2dG?=
 =?utf-8?B?TzdkdmR3Qk5aQzJlUmJGMzNIeVJScWQvZ0RlK3prNEhRVTRqMU5QcENZWGJJ?=
 =?utf-8?Q?NRT+Iv5RPxDUF1Bk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9be7f60b-7015-4cec-2ac8-08da23dc0f9a
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 21:15:29.1791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GdGp+b2CD1/+TUUe+ITGwyza4nd450Eyb0Xk+BajYP01YLtLZL+RN2aIjLVQ5SoorybFLMobUuTMTLY9N9AFikNrb9bbb1bOHZxzoQMBNuw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1898
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-21_05:2022-04-21,2022-04-21 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0
 adultscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204210110
X-Proofpoint-GUID: o1CQ6H-WCdqYeRwAsE-c-mW-L3QnWulw
X-Proofpoint-ORIG-GUID: o1CQ6H-WCdqYeRwAsE-c-mW-L3QnWulw
X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/19/22 7:43 PM, Alaa Mohamed wrote:
> kmap() is being deprecated and these usages are all local to the thread
> so there is no reason kmap_local_page() can't be used.
>
> Replace kmap() calls with kmap_local_page().
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>


Applied to for-linus-5.18. (Juergen, I kept your R-b from v1)


-boris