Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp142885pxb; Thu, 21 Apr 2022 19:33:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYcr5xi0OragXwxCW7daqXntEiMNHYCN9DTQ5+iaIoxAHdbtN8SVfO1BGMQZXCMhhE8h8J X-Received: by 2002:a17:906:bc4f:b0:6e8:9332:547f with SMTP id s15-20020a170906bc4f00b006e89332547fmr2179375ejv.650.1650594800983; Thu, 21 Apr 2022 19:33:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650594800; cv=none; d=google.com; s=arc-20160816; b=DdC7UUsHOxwUrJTSFccBdYfhjjDpYh98Jqd70/d+iM8w7edZJLSENIfFXJwevqnwNn g67p/mol4NRXQa5jeQhwEhHUKxdyn/reUJCBdJq6YdK6KVkvb9QHMVKALV/Z/8a289YR LHFSf/kLIIpgG1+AWMrY6dHCU7+Ly+dvI2CKwc+jfloMRgCPDIO4iLg92kxceCpfI8Si GD7udEoMkfnTnvNv7v5Hx0KrBMwqu/k91xsHmnJuou52k3E3VTGUmQsxWIZA0PNAuAZ0 AXFpKlkQ6CSC7yorY2wpnr1/8IapvwpXOpsqHl7AODUpQf3grWhnKb/9otYJlcFKpabo tk1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=iKEIMwWCIhVHezEJyY90xpzc57yWuMl14wGMtIQHqeU=; b=tMr94EX+n/GWy96zIejPUkCC3Hw6gMffhOuTF5fagq1Yd0oJkPzkt19Ey15YkUMNfo +u2Rz9gQut7w+NtHTT6N/7Jpfi3KugTgxoybSbjxps8sdt5v3mIGDyFDjmSOs5ixrw5f n5Y42axjAoYTJfXxO4W4wTP7DzOwUptIkev3CYgyJMge53qJy0G3kK1jIUVZ5jjX8FgF sfgmkWIeJ2wki0l1ZF4Yett711hzAlfYvpua7mttrnahvqPK8KBDVT4800Tpt9cuSq5p v7LPpwEn75Fj9XY6Wufn2uKOZaU5rF/O4ZXNpGCbF6rZBB2dxxhSCIZNsvE9my4ABD/9 GmlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HVJthji6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v2-20020a170906292200b006df76385e7asi5918550ejd.794.2022.04.21.19.32.57; Thu, 21 Apr 2022 19:33:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HVJthji6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379709AbiDTOcw (ORCPT + 99 others); Wed, 20 Apr 2022 10:32:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231538AbiDTOcu (ORCPT ); Wed, 20 Apr 2022 10:32:50 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10722DEB5 for ; Wed, 20 Apr 2022 07:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650465004; x=1682001004; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=hQFUSFKncVrleQOWMCchXY4SxJ71Fh4LDwpgNGBlicA=; b=HVJthji6gELK0vYMsZJ1dYznpz5i4KRxH7YEYNoDPTF6hgXx9VrXGgKq MHebHZzBEWAIdsmz6M9kg2qyrdfBKzjfSFyTDWkptnbNsk25ql05APOPd Oe42i/nd0SMSeaDXAvDFKknOcg2py9HUsC0xJCxtNRv2BCoSDfrex+X/C At3RzSD6uNaZlxwNl2DUWHn1OawO0PcFRV+6QaaC2c0xN4KTnOIuRIwZa Ilq5kn/rrT7NZ++OMIvb+UFBuPEasIJqF6yqafm3jf8SMV/Xv8yFkYiZp RRWSDAeIPMmwk6crpLtqbOhJvhzTZalT+m1sLttyvYJOv98BmHKP0FH7R w==; X-IronPort-AV: E=McAfee;i="6400,9594,10323"; a="251344176" X-IronPort-AV: E=Sophos;i="5.90,276,1643702400"; d="scan'208";a="251344176" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2022 07:30:03 -0700 X-IronPort-AV: E=Sophos;i="5.90,276,1643702400"; d="scan'208";a="562124251" Received: from mileskin-mobl.amr.corp.intel.com (HELO [10.213.184.8]) ([10.213.184.8]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2022 07:30:02 -0700 Message-ID: <20356d0e-74cc-1537-71f9-1c3f81e01b9f@intel.com> Date: Wed, 20 Apr 2022 07:30:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] x86/mm/ptdump: display page encryption state Content-Language: en-US To: Mike Rapoport Cc: Borislav Petkov , Andy Lutomirski , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Mike Rapoport , Thomas Gleixner , x86@kernel.org, linux-kernel@vger.kernel.org, "Shutemov, Kirill" , Kuppuswamy Sathyanarayanan References: <20220419143545.30295-1-rppt@kernel.org> <3f27999a-35bc-3499-2bf8-afd0e8666068@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/20/22 00:17, Mike Rapoport wrote: >> _PAGE_ENC is AMD-specific. Could we do this with a new generic "cc_" >> function, maybe cc_is_enc()? >> >> Something like this would (I think) work for both SEV and TDX: >> >> bool cc_is_enc(u64 prot) >> { >> return cc_mkdec(prot) != prot; >> } > It works for SEV. I can repost with this and you'll confirm it works on > TDX? I don't have a TDX setup handy, but Kirill certainly does. I'm sure he'd be happy to give you a tested-by.