Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 20 Apr 2022 09:01:08 -0700
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     x86@kernel.org, brgerst@gmail.com, jiangshanlai@gmail.com,
        Andrew.Cooper3@citrix.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: Simplify Retpoline thunk
Message-ID: <20220420160108.w3rxf3vhmgnnpplq@treble>
References: <20220419204109.520779286@infradead.org>
 <20220419205241.280037046@infradead.org>
 <20220420152736.qzl3nikds6mq5nrr@treble>
 <20220420155116.GH2731@worktop.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220420155116.GH2731@worktop.programming.kicks-ass.net>
Precedence: bulk

On Wed, Apr 20, 2022 at 05:51:16PM +0200, Peter Zijlstra wrote:
> On Wed, Apr 20, 2022 at 08:27:36AM -0700, Josh Poimboeuf wrote:
> > On Tue, Apr 19, 2022 at 10:41:10PM +0200, Peter Zijlstra wrote:
> > > Now that we rewrite all the indirect call sites, per commit:
> > > 
> > >   750850090081 ("x86/alternative: Implement .retpoline_sites support")
> > > 
> > > it doesn't make sense to have the retpoline thunks be an ALTERNATIVE_2
> > > that still includes a 'naked' indirect jump.
> > > 
> > > (this accidentally 'defunnels' i386 by going back to full retpolines)
> > 
> > So mitigations=off no longer works on i386?
> 
> Also true I suppose... does anybody care? /me runs like heck.
> 
> I'd hate to make all this more complicated just because i386 tho :/

Not that I care... but at least the commit log should own up to it :-)

-- 
Josh