Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp292016pxb; Fri, 22 Apr 2022 00:27:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzC6SYVGmq2PXUB1Qrv5gIuC+TUbyX0vwpU3L0RVpE8INqXFc6vDjypnwOAhgNssUpJtuMc X-Received: by 2002:a05:6402:b45:b0:423:d3d0:5ed6 with SMTP id bx5-20020a0564020b4500b00423d3d05ed6mr3392007edb.139.1650612450179; Fri, 22 Apr 2022 00:27:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650612450; cv=none; d=google.com; s=arc-20160816; b=xMLn4PUERZcP1tlPVpQTfFC03XymKd7vNoM+hPRsr40+PaoGEnJPcHIOfCCvj4wAu3 djXYDrEKaoy0NgLrM3X1yilMFnE50nKtYyYe3Y/FJBOGpfMlRCwmsHlOXPEyY+hLEcz2 JJcxeBC9lCjTfwUSZbXcpNsXOO7my3wwRKFeZlhLkYTMzB66KyoRh1nRPa0VMtT2ZdBA sv4p1Rl++8KgCwbowK3I11RsE+u5iwYo5N3yma8SVKpWPzT3dl8n2GBj6Lyzu7J2FJwN 1UDzPbA5NEoNoLWgDWjs/pNDIJqovod6cxTpAKCrvhBGgFYoQwoP1nztfSaNo6RrqINy VMow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:subject :from:references:cc:to:content-language:user-agent:mime-version:date :message-id:dkim-signature; bh=UbHvWMxRdAID5b96vEmaV4ErZ2O0hnv6CdX9SBr6PBs=; b=r/E8fDrz8zTkexlW0bZ0mhg5dETOp6dLKphUuxModcW+FollB9uJMXvPgWQm2z723f 7ewzDSAqiQW48xrtqnQhbKQ5H7oqN3fl07TR8Ko3HOf1POxvpfGYD57X36ncmA628Q57 vdnH3BKbgZPq0QmZ8EDCU2LQipA9gSLkWgn0fQ0B1smdMsEDW6LcSI9D9mu0w0qNBy5P uAtad+LfdaljRS2ZbwxiYRDke0W15o/jvUNKwvdqpLLo9nnweKazRYBAZAfAntk2QeTM cXhBjw0B2ynWYkCxX1T9n0RwIG8DoTcEiHa32pbCxWa8HaHnt5xIUzO4nUKjwDQkRHrT 6XbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=TIIYG+nD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id tc15-20020a1709078d0f00b006f363c7f03dsi60511ejc.325.2022.04.22.00.27.06; Fri, 22 Apr 2022 00:27:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=TIIYG+nD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358032AbiDTFYT (ORCPT + 99 others); Wed, 20 Apr 2022 01:24:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235111AbiDTFYO (ORCPT ); Wed, 20 Apr 2022 01:24:14 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3E6F3587B; Tue, 19 Apr 2022 22:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650432089; x=1681968089; h=message-id:date:mime-version:to:cc:references:from: subject:in-reply-to:content-transfer-encoding; bh=SfesI4khtBjUJgxDq/Dosd4z9f8CYx2PpAzYtY+D6RE=; b=TIIYG+nDC/rWBPX0b5YerQduJmUL8NTK+cVTgfQrJdgeDtQS7RB+zOxy AkAY4k7Yvq6zKalYVbcbP5XONW01x+/w2qkYFH61X6cXRgeT/gAkorBNZ xVYOirFz500VlkCT97HXDGGRbo8KIqwEUg6F8KPh2tl5lNA1ijSdIZk2c LdzmGBItPRf0DykOmgW3qwqO/pMO4MhqNt+OSEwm46ONpy1aD1JuOOWRr tC64CuC7tsWuPnjT4EwgaUhsCr0ha99N3fRFV2FejWP0e87eatHA8Wb3c DZE4Xrf4FUJPXEZlNih2K3HZ8oYlX0JOW/rJonUOlPeIimL8MJtghd1C0 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="244525655" X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; d="scan'208";a="244525655" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 22:21:29 -0700 X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; d="scan'208";a="510412173" Received: from sazizi-mobl2.amr.corp.intel.com (HELO [10.212.98.167]) ([10.212.98.167]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 22:21:28 -0700 Message-ID: Date: Tue, 19 Apr 2022 22:21:27 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Kai Huang , Sathyanarayanan Kuppuswamy , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: seanjc@google.com, pbonzini@redhat.com, len.brown@intel.com, tony.luck@intel.com, rafael.j.wysocki@intel.com, reinette.chatre@intel.com, dan.j.williams@intel.com, peterz@infradead.org, ak@linux.intel.com, kirill.shutemov@linux.intel.com, isaku.yamahata@intel.com References: <32dcf4c7acc95244a391458d79cd6907125c5c29.1649219184.git.kai.huang@intel.com> From: Dave Hansen Subject: Re: [PATCH v3 04/21] x86/virt/tdx: Add skeleton for detecting and initializing TDX on demand In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/19/22 21:37, Kai Huang wrote: > On Tue, 2022-04-19 at 07:53 -0700, Sathyanarayanan Kuppuswamy wrote: >> On 4/5/22 9:49 PM, Kai Huang wrote: >>> The TDX module is essentially a CPU-attested software module running >>> in the new Secure Arbitration Mode (SEAM) to protect VMs from malicious >>> host and certain physical attacks. The TDX module implements the >> /s/host/hosts > I don't quite get. Could you explain why there are multiple hosts? This one is an arbitrary language tweak. This: to protect VMs from malicious host and certain physical attacks. could also be written: to protect VMs from malicious host attacks and certain physical attacks. But, it's somewhat more compact to do what was writen. I agree that the language is a bit clumsy and could be cleaned up, but just doing s/host/hosts/ doesn't really improve anything.