Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp322718pxb; Fri, 22 Apr 2022 01:22:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwah3CA0ukiRodld0NmWKzEkJtEwUxHKXsVSQODJzJ4sJXYje1jMtaqCbpSn0C6Tz9hlKGw X-Received: by 2002:a17:902:7d81:b0:14f:e18b:2b9e with SMTP id a1-20020a1709027d8100b0014fe18b2b9emr3197157plm.160.1650615736216; Fri, 22 Apr 2022 01:22:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650615736; cv=none; d=google.com; s=arc-20160816; b=KOWxAZ0GAIkfbhVhVrDu2B8nnOF/Z4A4Tkh2gYL1kyxOHNi0a/zXvLu+HCyU+mcEDG uCd5QDYGh8tq3Di/2RIUPT83dQ8Kc5ExdnabeU7rk7NXNnMzQME/qCusxc1EbPrMa/yh F5uPgPPRtEN4Tns1JQOxv29rO6ISCY8cLbni8EeoA7GeOryzoB4WWl0mD45yHJnjbUxK KlpbjUPVbvFKxt0LzeRP7M3Mzz3DxUs08jK5zZ8gXSmC1mtFUP8LqZO6axQO3qcKlmgp CmucSbpLsbMAfMtWJZzRmqbVsCg16pyqylOOU4mPpp1S+vDPMyq5UU4St/0sxrxRCRLN iTWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DxYVFPqhw7EnfsZEYTXHcUR3ApSQdJ6o31Q8vRA3VKw=; b=b1szeMrAwhqB8Hm50YZVptDI9sjOKrtgEj+AmsEYUpAMiNM5kX3ok++U7GrPPvGfXI RPj4WCC86myW7O+jyw3LOqJx4+sSJWWM99vlHw9PxHyPhsWIqM/DyVMUBfPyussRokYo smA8tDR0oecy/yrlxF8Ig/hSJ179CiLy9gNO+z05Z3QCoPS9BB8Mdn1MVnAogmjZi1TH bd6zefsOifKsV40vpgVoGEJwOdAXMhB3CdZRPsHYmgScewmBI7qcx76OOFjrAqpciWoX Q2SRUFuHLq+Cre3vgL8ArejXHZ2qgEC9iaIryS8a8m+RxJjrJMSNNkhF5pyC9HR8COtw tKJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=SfuV6EQA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i23-20020a63e917000000b00381facb2ec6si8110431pgh.728.2022.04.22.01.22.01; Fri, 22 Apr 2022 01:22:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=SfuV6EQA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385496AbiDUHAh (ORCPT + 99 others); Thu, 21 Apr 2022 03:00:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380886AbiDUHAR (ORCPT ); Thu, 21 Apr 2022 03:00:17 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DAD41583F; Wed, 20 Apr 2022 23:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DxYVFPqhw7EnfsZEYTXHcUR3ApSQdJ6o31Q8vRA3VKw=; b=SfuV6EQAHeinwPkf3hcym0/Xob SQ1klssE18KyBbQZ5Nh/e95MAq1KO/mLU7YLXQX8BGIDq/YyAeM8YClulitOVYqttaAkORvVmLsDZ 0SJzoBoUYgIYUVU+Dmh0XlO0T+blI+Zk7evK9t6fMpt03MzZwzCJ95njWKqHPmdEi1UEiMeuNNX8m ec3u1DQJZ+FqkjMMu/1Pr143NQW46bCDQu7RuOHjxi0kIiuPctNXC1f4CL3p0NIdzc2fQMIPoTgcW BIpm9oJl7+WOqQi6ydsJZYpB8wPDwhqRIlcSpxxW+bDog9j93yNtOjVU6vtR7P0cJsfW/Y41vZ58i U+LYdR+g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhQkd-00BuPJ-S6; Thu, 21 Apr 2022 06:57:15 +0000 Date: Wed, 20 Apr 2022 23:57:15 -0700 From: Christoph Hellwig To: Jane Chu Cc: dan.j.williams@intel.com, bp@alien8.de, hch@infradead.org, dave.hansen@intel.com, peterz@infradead.org, luto@kernel.org, david@fromorbit.com, djwong@kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, x86@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com, ira.weiny@intel.com, willy@infradead.org, vgoyal@redhat.com Subject: Re: [PATCH v8 4/7] dax: introduce DAX_RECOVERY_WRITE dax access mode Message-ID: References: <20220420020435.90326-1-jane.chu@oracle.com> <20220420020435.90326-5-jane.chu@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220420020435.90326-5-jane.chu@oracle.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + if (bb->count && > + badblocks_check(bb, sector, num, &first_bad, &num_bad)) { Weird alignment here, continuing lines for conditionals are aligned either after the opening brace: if (bb->count && badblocks_check(bb, sector, num, &first_bad, &num_bad)) { or with double tabs. I tend to prefer the version I posted above. The being said, shouldn't this change even be in this patch and not just added once we add actual recovery support?