Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 18 Apr 2022 19:00:59 +0200
From:   Heiko Carstens <hca@linux.ibm.com>
To:     Tony Krowiak <akrowiak@linux.ibm.com>
Cc:     Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>,
        Jason Herne <jjherne@linux.ibm.com>,
        linux-s390@vger.kernel.org,
        Harald Freudenberger <freude@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390: vfio-ap: Remove the superfluous
 MODULE_DEVICE_TABLE declaration
Message-ID: <Yl2ZS7lyzyit9lbk@osiris>
References: <20220413094416.412114-1-thuth@redhat.com>
 <2440b3f3-6961-4091-438f-7120b9177164@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2440b3f3-6961-4091-438f-7120b9177164@linux.ibm.com>
MIME-Version: 1.0
Precedence: bulk

On Mon, Apr 18, 2022 at 10:23:38AM -0400, Tony Krowiak wrote:
> Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
> 
> On 4/13/22 5:44 AM, Thomas Huth wrote:
> > The vfio_ap module tries to register for the vfio_ap bus - but that's
> > the interface that it provides itself, so this does not make much sense,
> > thus let's simply drop this statement now.
> > 
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >   See also my previous patch to register it for the "ap" bus instead:
> >   https://lore.kernel.org/linux-s390/20211201141110.94636-1-thuth@redhat.com/
> >   ... but since it has been decided to not auto-load the module uncondi-
> >   tionally, I'd like to suggest to rather drop this line now instead.
> > 
> >   drivers/s390/crypto/vfio_ap_drv.c | 2 --
> >   1 file changed, 2 deletions(-)

...

Applied, thanks.