Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Steve Lee <steve.lee.analog@gmail.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
CC:     "krzk@kernel.org" <krzk@kernel.org>,
        "Lee, RyanS" <RyanS.Lee@analog.com>
Subject: RE: [V4 1/2] ASoC: max98390: Add reset gpio control
Thread-Topic: [V4 1/2] ASoC: max98390: Add reset gpio control
Thread-Index: AQHYVHIA5PedYalhXkCP+ziHPq/giaz6cgPQ
Date:   Thu, 21 Apr 2022 14:39:53 +0000
Message-ID: <PH0PR03MB678610A794CC939AD3AA117999F49@PH0PR03MB6786.namprd03.prod.outlook.com>
References: <20220420044900.2989-1-steve.lee.analog@gmail.com>
In-Reply-To: <20220420044900.2989-1-steve.lee.analog@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 2
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?fRzohBXKZTjSUreAn/pWKsUZodbl1T1GkK/sOxzcu0fRsSIzG2TcvaZr1N?=
 =?iso-8859-1?Q?+wwf3E/Fq/KS+XFhNttXpmTQViyH7xBa1FVMycGYgJql6ZQEmGmx1Hl+9z?=
 =?iso-8859-1?Q?YMlyQrZqBPFTvsJPIA3AAKd6Y07tDGcTDsWp1koQ0Ey0Q+jhuf0QZAuyDn?=
 =?iso-8859-1?Q?ez/WU56PNq5zBJy1eXd4xITzo2uhrfevqCE/7C0Gfig3EX/OjjlcGcZciF?=
 =?iso-8859-1?Q?KwAobFnNwp2Ui+81qEMc/E5e7G3uKXgpKbtlanq/gEj+jTXvLCVN901wLj?=
 =?iso-8859-1?Q?6ZHQfZW22K+ZfJ4jyYfoETk2tTSG0vw9Rl4nalm9OSMuheqJFdXIijK872?=
 =?iso-8859-1?Q?kZbFsPhA2Li14o/AzKdsvrVmId/5gLSK6zv5t2hik+B3tJ00JufEf6AdY/?=
 =?iso-8859-1?Q?j9l9zbeW72tduy4h1/UB6/sLAr3jN2IDMOvwyjRsgbepyYr2M+91dYEDoa?=
 =?iso-8859-1?Q?4ETazTCALkJy8V0gvUNN5inajfXCDakZTqh8cHeavlP2/6OQuqDui4iBc3?=
 =?iso-8859-1?Q?b1RoekgI/meE/RjW18jhWEGJwjbyCKsSpe8JeVy78Px4EzaefVIt1tQC0o?=
 =?iso-8859-1?Q?aVc+YGRf5k2yXc6NDU4AkMBGefgobsNXdhg35uox2Ac1XXfhgmGOKOEyaN?=
 =?iso-8859-1?Q?ndTFq9uUpqxpfi1RoLG4YIUm9bXjl9gU2x+i1XdXF7j/249PsXKmsBbDLy?=
 =?iso-8859-1?Q?hJVXvcJJyQiKWaNTjGlT8xzI6nNxX39/IOgRFBVa5zD1TvD6QXXcUUwnSX?=
 =?iso-8859-1?Q?DUKuc4DLVU2HyCD9qPMi0phkvavwRTkebm1CfpU2afapKrr71/ita04U/M?=
 =?iso-8859-1?Q?v3//kM3cEmZfg0ZpLHsLu5EVdxq7daal+cmGKuzrFFiUzl6PLlM5BH+kW8?=
 =?iso-8859-1?Q?WUKLHEEWN6oseKsGFGpFwJywsTlOwjA8rbqlKb/zwYoJU7ENMra5sKrUee?=
 =?iso-8859-1?Q?3B3UcCK67Vrgr2jsiCxxyw54HA0BOSKrh629XC9NDJTJwI87BhbYdafy2x?=
 =?iso-8859-1?Q?ov0UV0K57FgFDjbZidyRzE+Jm3IJuFaYZx3jqmI/hURLo4KUXCEkt1shau?=
 =?iso-8859-1?Q?jAi/65OJ/usGpLqNMS0eS79WlfC+zhrnn6/i+sn3dW/OHCrG1o9yIuYauh?=
 =?iso-8859-1?Q?+qkYJ3uk/YIAa8qjD5Hy8DrWPW3giZs9KyffPJKccViLyxm8xF0jsAmZB8?=
 =?iso-8859-1?Q?DHUPdt9IDDdx7qSQI4SCbQx2RxPLudYegSY3UM/BdFVu5GF559X/G2uaz7?=
 =?iso-8859-1?Q?VoqZKypihcM7evPk7fPw7kNLOKQZiqbN+CWXiYRkzmwOptflz/f6gAsU92?=
 =?iso-8859-1?Q?S5rHF30xU1V9iw/s9vmb61ZbbB3Xie33KojgiQdClQ4n7cUCOQhA6hGOsj?=
 =?iso-8859-1?Q?JcJJZ6TK4+jNbOsqKUNGDRSWDNjOLnLAmaJx1MQC2Gn0WoIEZWClDYmd1G?=
 =?iso-8859-1?Q?mmjqtaAxiYzyvGmA16f8Jq7L7flPj6XK5oZBr7a0UveHNHZ9GgSK9j7BKU?=
 =?iso-8859-1?Q?iaicVaRa6fSnpSWl18HEXdslSn8A0xNejNHUGpErEQFxGgk9q0EaKik3Iw?=
 =?iso-8859-1?Q?myEUI5SYTAbqyesGl1m9HBJEmzgW7ofV14Gez22POUiO8JGucnuFPVJx3l?=
 =?iso-8859-1?Q?aM8xhPdbMJnIywwlPK6S7YqxQp5tDDiPqecdo0S2VrbxgXS4YsqfhpHDIi?=
 =?iso-8859-1?Q?YNXkaVXyCbJ1ONNQa89/1t7iKen/UpqpYsgIjzuvdbSJzRdwo1WHgA6l9o?=
 =?iso-8859-1?Q?ZCVp4naWqQG4um+t0z6FCAuKE793l8EtMzZNKaMnSKNgDd+mBMz5MqyhIH?=
 =?iso-8859-1?Q?B8j7POOwKhC0FzRBFomhaIK2Q/ZrRRaeqMSNOJ7q6VTmZMlV8cELdGX6GX?=
 =?iso-8859-1?Q?a0?=
x-ms-exchange-antispam-messagedata-1: vVo6qHbK1sdPgw==
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6786.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a73646b-72a9-4886-36c8-08da23a4cc4b
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 14:39:53.5280
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hYFaBfyvEqdD7bLOeTp/CqJcOQZyUMgzmYzVkIn7yoxu0vgI4IvSVQEP6dXHa5NdWEcat71aFfDdGUtWeaC3EQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5139
X-Proofpoint-GUID: 4_0jq2GtbV-C-VZcwW5VJEovHPpDBJip
X-Proofpoint-ORIG-GUID: 4_0jq2GtbV-C-VZcwW5VJEovHPpDBJip
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514
 definitions=2022-04-21_01,2022-04-21_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0
 priorityscore=1501 mlxlogscore=999 lowpriorityscore=0 impostorscore=0
 spamscore=0 malwarescore=0 suspectscore=0 mlxscore=0 bulkscore=0
 clxscore=1011 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204210079
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Steve Lee <steve.lee.analog@gmail.com>
> Sent: Wednesday, April 20, 2022 6:49 AM
> To: lgirdwood@gmail.com; broonie@kernel.org; perex@perex.cz;
> tiwai@suse.com; linux-kernel@vger.kernel.org; alsa-devel@alsa-
> project.org
> Cc: krzk@kernel.org; Sa, Nuno <Nuno.Sa@analog.com>; Lee, RyanS
> <RyanS.Lee@analog.com>; Steve Lee <steve.lee.analog@gmail.com>
> Subject: [V4 1/2] ASoC: max98390: Add reset gpio control
>=20
> [External]
>=20
>  Add reset gpio control to support RESET PIN connected to gpio.
>=20
> Signed-off-by: Steve Lee <steve.lee.analog@gmail.com>
> ---
> V3 -> V4: change reset gpio control as GPIO_ACTIVE_LOW in DT
>=20
>  sound/soc/codecs/max98390.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>=20
> diff --git a/sound/soc/codecs/max98390.c
> b/sound/soc/codecs/max98390.c
> index 40fd6f363f35..bdfd6cccc3d2 100644
> --- a/sound/soc/codecs/max98390.c
> +++ b/sound/soc/codecs/max98390.c
> @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct
> i2c_client *i2c,
>=20
>  	struct max98390_priv *max98390 =3D NULL;
>  	struct i2c_adapter *adapter =3D i2c->adapter;
> +	struct gpio_desc *reset_gpio;
>=20
>  	ret =3D i2c_check_functionality(adapter,
>  		I2C_FUNC_SMBUS_BYTE
> @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct
> i2c_client *i2c,
>  		return ret;
>  	}
>=20
> +	reset_gpio =3D devm_gpiod_get_optional(&i2c->dev,
> +					     "reset", GPIOD_OUT_HIGH);
> +
> +	/* Power on device */


I guess this comment is redundant as you already say
"bring out of reset" some lines below.

> +	if (reset_gpio) {
> +		usleep_range(1000, 2000);
> +		/* bring out of reset */
> +		gpiod_set_value_cansleep(reset_gpio, 0);
> +		usleep_range(1000, 2000);
> +	}
> +

Anyways,

Acked-by: Nuno S=E1 <nuno.sa@analog.com>