Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dce29330-e40c-860e-2c72-7ddebdd96e20@redhat.com>
Date:   Thu, 21 Apr 2022 14:47:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3] drm/gma500: depend on framebuffer
Content-Language: en-US
To:     Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
        Thomas Zimmermann <tzimmermann@suse.de>
Cc:     David Airlie <airlied@linux.ie>,
        James Hilliard <james.hilliard1@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>
References: <20220409042321.3184493-1-james.hilliard1@gmail.com>
 <b3f7e288-3341-8c6f-1b95-e553ac5ebc35@suse.de>
 <CAMeQTsbh-Fy4CORBTX=AfZ+K-fZYUQ=hY=ctLFyu9KcJ5NgFUA@mail.gmail.com>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <CAMeQTsbh-Fy4CORBTX=AfZ+K-fZYUQ=hY=ctLFyu9KcJ5NgFUA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Patrik,

On 4/21/22 14:39, Patrik Jakobsson wrote:
> On Thu, Apr 21, 2022 at 1:49 PM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>>
>> Hi
>>
>> Am 09.04.22 um 06:23 schrieb James Hilliard:
>>> Select the efi framebuffer if efi is enabled.
>>>
>>> This appears to be needed for video output to function correctly.
>>>
>>> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>>> ---
>>> Changes v2 -> v3:
>>>    - select EFI_FB instead of depending on it
>>> Changes v1 -> v2:
>>>    - use depends instead of select
>>> ---
>>>   drivers/gpu/drm/gma500/Kconfig | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
>>> index 0cff20265f97..a422fa84d53b 100644
>>> --- a/drivers/gpu/drm/gma500/Kconfig
>>> +++ b/drivers/gpu/drm/gma500/Kconfig
>>> @@ -2,11 +2,13 @@
>>>   config DRM_GMA500
>>>       tristate "Intel GMA500/600/3600/3650 KMS Framebuffer"
>>>       depends on DRM && PCI && X86 && MMU
>>> +     depends on FB
>>
>> Why do we need FB here? Framebuffer support should be hidden by DRM's
>> fbdev helpers.
> 
> It is not needed but gives him video output since it enables the drm
> fbdev emulation.
>

I'm not sure to understand this. Shouldn't depend on DRM_FBDEV_EMULATION then?
 
> I looked some more at the logs and it seems weston doesn't work on his
> system without the fbdev backend. So the question is why weston isn't
> working without fbdev? Perhaps this is just a Weston configuration
> issue?
> 

But is weston using the fbdev emulated by DRM or the one registered by
efifb? I thought that the latter from what was mentioned in this thread.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat