Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 21 Apr 2022 20:00:10 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Solomon Tan <wjsota@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net,
        phil@philpotter.co.uk
Subject: Re: [PATCH] staging: r8188eu: use in-kernel ieee channel
Message-ID: <20220421170010.GD2462@kadam>
References: <20220421015811.2745-1-wjsota@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220421015811.2745-1-wjsota@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ttuh+xY44NTIZ0v8HoXenoiZoYyVn+Rqe5duMUSi9P0q091tXNvKZFbWkONN?=
 =?us-ascii?Q?O8qd5RjsX7zF9CTK5U+srsuqucbIwp+/jkMJMbOy/K9a/NgBCZpuuSpYkmKJ?=
 =?us-ascii?Q?gzM/PbQXC+WamBi9PC21i3o1tfVIK/7CKOPuUihsZiiMcPIghD4jg5eno/+I?=
 =?us-ascii?Q?KRJLQsaATcuToW+8x5xfdeS8Pah8YYOjaxlPyJkOoM1q/ExIYQnHkuLxMjJ1?=
 =?us-ascii?Q?VcioQlsggXHgBSkATbhocW3MUaiLe2ySsWjfBXvgM+R/TkhCrTiSUw75paVE?=
 =?us-ascii?Q?5VqkF9wsoc06Dc6mgv0s3148StaDQNmmmVBvO647dkBKpTtzOj7iJzcO8HCs?=
 =?us-ascii?Q?GaQ/NF1hoeiadTN7wD4LlFDi4ZVuGMjUrvOPkm9YzdBbECiMDsV9bFDs1Zh+?=
 =?us-ascii?Q?LyklvIgxYFybpg9PeRI3C5TJWfn29mGQbY93WqjC6nNbEDHaifDYBHbsEOgS?=
 =?us-ascii?Q?2Fair6lLZEPn5QJ+ZHeef4QA1y8sGXBcrwui63lYq3Y44XzskI60Kb5ch+CV?=
 =?us-ascii?Q?rfN+pZZgtjGkvrqegP5LjgPar5hZzwaZiYX741/Va0mJHzmoi+Li6IFaiBSD?=
 =?us-ascii?Q?Gvah+CLtTV2g4fvFt5vOSaarImqdVgq1qHA6Rz1fyICJ5N3wi5uIiw6a6iZg?=
 =?us-ascii?Q?/VNJuD4UV4gp0UejPfmOmtbslJ+kRs/TDih/aPf5Qg0OEAJR+CmGVoiqa/fz?=
 =?us-ascii?Q?8TRwd+bNgf2J7Rlfb0U1HDFULA4AWThNavrTd4AE9/EpCx/QB9qFjZ3LAe8G?=
 =?us-ascii?Q?ROh+tiUsJD1ZBCz1iEt6A7cIS/GRqOhjZcbaxe1fLa9fPLrjNuYfu6hTnG+E?=
 =?us-ascii?Q?w7uEVmozXRmd6ZGXKPrteAZpxig9Y9zLoAfdMqG0d8s8tHCyYtK9SkWuqC01?=
 =?us-ascii?Q?JrFeDcI90kPf3RIKBNEIOkVhrOF0l5hwX42Todw2Q8ZyVouKxCWFaKOU5z3a?=
 =?us-ascii?Q?JpQH6WpzCDGUkNv0lbh9ngt98p45UqdAwJA7w5GNLvBKsyP7gmr4IP0hrjDh?=
 =?us-ascii?Q?aeJ5Rq34r/EeYS+pu9hhMmbgGQi4eK1kSZf9TWuCCPUFvLMHz3cRZNKZiMFs?=
 =?us-ascii?Q?+JkKLE0TfOpT1F0DsiJhc9ueZwhtYG4/CTggWPupdlNWxYCrKdrN78AB1WXI?=
 =?us-ascii?Q?S125q6rrIPkSoBXgp2v1IGIggTdjoxAeB8ve1VmmtM9JU4hjVsS4pEXt9fjn?=
 =?us-ascii?Q?k9siiR+JYfvbZe6mOyWMf/ImuZ7vDxe9ewHH0+/mArvEFgPdBRz0XqY+suUZ?=
 =?us-ascii?Q?XgBqX4Cv9riXqYAPHD/wqOCnRTQ3f+QHoGGHD8iWokZ30Ls5It5CWGezYgN4?=
 =?us-ascii?Q?8s6bDAQdPcI90KVYQ3tjaDmqDE9vDQBkn0USgz9AWjddudqxXo75VLBLgBCu?=
 =?us-ascii?Q?xMYy8GnUV1tdC5VP3Bsa3YuLzzZPawQlhEyeYSoGJVhw+oomibp2s7A7wAeZ?=
 =?us-ascii?Q?u8qR4+Jwen6kaGs8vVERWAdL0jduaymulm3yGnm+Wii0eSmv5hPXalzlsGxL?=
 =?us-ascii?Q?D2tPLyOrlXV+xLSLoYazdncx0e4rp7qsFz2TOuH5iuX7lJsijF+XYKehAN9z?=
 =?us-ascii?Q?C2AJ6xWlXySMIuRaLT26ovSj6LTYlAqtFdVJozVf0eVCUWgRYQY9KjqBlfKV?=
 =?us-ascii?Q?ZSHsh+LNNBQnO1ogtVE5G8zA4SfL3h4ebjBONm3CupvqA6FU/y3WQaCBRFrJ?=
 =?us-ascii?Q?kYHDxIWq4cq2ywfPsXSN0OEV/pVGiRbK32WQrwv999PrZzXEaFb9m8QjTWJX?=
 =?us-ascii?Q?68X8zl9USsFot7OuFhgqweNaeiIVB4s=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11992671-7232-4ed1-d64f-08da23b8771f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 17:00:40.8532
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vGAiE++oSxv0GsJJJlLeQ5X5Inw//OYKufojMAtI+7Ft9Z1iODZ99g38TicpzAao8N1vx26sKrWCyjUIQVNdepyAEnrgB3pb713bkoy3tiw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4914
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-21_03:2022-04-21,2022-04-21 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204210090
X-Proofpoint-GUID: Q5E8DJ3uiJpELCH6dmZKXODz9Yi4l_My
X-Proofpoint-ORIG-GUID: Q5E8DJ3uiJpELCH6dmZKXODz9Yi4l_My
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 21, 2022 at 09:58:12AM +0800, Solomon Tan wrote:
> The rtw_ieee80211_channel structure just duplicates the in-kernel
> ieee80211_channel structure

When you say that they are duplicates, I expected them to be the same
but they're not at all.  ieee80211_channel has a bunch more struct
members.

I don't really have a problem with the change necessarily but the commit
message should not have mislead me.

regards,
dan carpenter