Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f3ea7ee0-1cb8-6928-d0af-4c2fc63a42a4@oracle.com>
Date:   Mon, 18 Apr 2022 17:03:39 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH v7 2/8] x86/crash: Introduce new options to support cpu
 and memory hotplug
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com,
        tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com,
        hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        konrad.wilk@oracle.com, boris.ostrovsky@oracle.com
References: <20220413164237.20845-1-eric.devolder@oracle.com>
 <20220413164237.20845-3-eric.devolder@oracle.com> <Ylgot+LUDQl+G/5N@zn.tnic>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <Ylgot+LUDQl+G/5N@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGE0UzNhS0dVKzE0U1VUN1k2YVJDM1lzRHZwTnd4VklaSHYvbmtwaVF2MldY?=
 =?utf-8?B?MWsrRnFGZm5pZXNpeExLSnNGcllScEYvZkprQTRla3FVVWZCcEFRY2p6U0VD?=
 =?utf-8?B?M0pFMVZaNVpMd0RVU09RVFpCOG14OVR4NWJra0pxMGlVa3ovZU5oVExvNVVx?=
 =?utf-8?B?eHRhckU4M0VITEdtWTQrRmhHQVo4Zk1iMDkyNHpxOW1UblZHay90SWtiOUYv?=
 =?utf-8?B?Vmk2ZHFsUWd4UW8wZ3NWZXZYaFN1dGVmdUhJNk9BbU4yVkpPWldnbkYveTRU?=
 =?utf-8?B?WnhxUm1USTVHRzJtdVVRZk1yTmZVaVQzQUNUTXNtS3RuT3ltMWdhRmpJLzFQ?=
 =?utf-8?B?OWtaTmJFcmNpSGhGVXJ4RDlES3k0SWh4UGtrUmRCTllCYlZ2bUpPdHUrSk9i?=
 =?utf-8?B?L3MxVUFNNVh2YXRjMURUTUw2bDIwanhrbHZadXVjNUJNWCtvUFNyUkp2UnZm?=
 =?utf-8?B?WDVmNmpveFRBd3llM21XbE1rOUlpcnhjaE5vUkh0NHZ2ZzdOQWhUMmE3NHpI?=
 =?utf-8?B?RDVrMExmV0hKNmhHWTJPMFdqaXUzOGVxNVdXTlJtRkZSRmVCcnltRTRMb2Iy?=
 =?utf-8?B?ME0rK0NBRVd5UVppMm9Lc3FqOUNDd0NqY0VnNFRJNThhN1lUNlVtWFZVelhY?=
 =?utf-8?B?MVFlY1FOQlNQL2lFQkZrNkpOakl4MkxiMHhaMHgrdUZhZ3ZWQ2kybXFDOW05?=
 =?utf-8?B?RkVieXlxcWVxQjZFMDRoZWRzUFFsYUZCOVQwRi8vNUdFYlpEalFtdjJWNXhh?=
 =?utf-8?B?cWVleGNWYjlBa3JTZW96Wml0N3JiMW84eFFTUWtwcFBkMXAyTm56eUNMVURG?=
 =?utf-8?B?Nm5pK0pJOWNENlNaaml1bDh0UERsUVNhM0FIb3JsQ09YQnZJdVpvVUV0eFdM?=
 =?utf-8?B?RDdXaThkcVhuZHNzMGxhOURaQjExOGRQTnhITDhHK2o5aFhNRmRRd2pLQWt6?=
 =?utf-8?B?elVKeUE4Q2VqeTIwd3MyUGJraVJFc3lZN3FyUDRJUCt6V2Mya3dORGVnZDlR?=
 =?utf-8?B?dkZGU3ppeG1oQ3dMSXBqQnJhSkYvR1hENVY2K2FnQm1jQ2ozbWRBUEp6Qnpv?=
 =?utf-8?B?TDJhTDg5d0FHVWZXSVVDMjZEbWZBVkJZcEIyZHVabHZRaEJlRmlDSWpQS3BH?=
 =?utf-8?B?TzVJNjhGT2N0Um9tbHA0T0t3emxneXNTQ01vQlBIeHZvRzZKTzl2T01ZeFUw?=
 =?utf-8?B?dGc5NmZVUnl5cjhxL1JPZkNURkRveWZrR3Ficnd1ZXoyZllUL1BrbVd6WnZu?=
 =?utf-8?B?VktLazJwS3E0Tk9JTkZrVmV6T0JGbTRVbjlRbnZFWWwrdmQ1VWo0K0Nnb1Nz?=
 =?utf-8?B?cXdaMEpXOXBDSFA3ODRIbGJmZ3ByeWsrYnE0bThmcTdsTWNTNEtlYjROdmp2?=
 =?utf-8?B?S0ZlSzBEeEtvNE1qM2NXcXM1a1B4eGlsdFdwWEZobmIxUy9tbFBobFhIR01w?=
 =?utf-8?B?MTJKTUVOQmQ0NnB1YkovNnNoUFNOVCt4dXU4c1p0YUt0cUNEQTkwRzVGRnRk?=
 =?utf-8?B?ZVB2a29NcG5Tck5EZzFFTDZmNTZyeEo0UUphWmpQc3VURmExR0R6dUFZdVVS?=
 =?utf-8?B?OGQ3OXE3Q3B4c0JwVEdnNU8yU1laQnNKOFhRZFh2VW5NM0huQTJVTnNBL01y?=
 =?utf-8?B?WUNGdlIrb05xbnVublJyMndMeDQ2L2w1SVZzWmRPM0RsalZnUldneG55SVlq?=
 =?utf-8?B?K3hKcVg4ZlhldFU2VkVWL1RQMXBoSDFMMndoTEZLTXRNdVoxUm83b3BEZ1Nn?=
 =?utf-8?B?Sm81WXJLeHpyanNnZ0ZCY1RVVmZROXg4cjBnUkVSMDhjb3ZESy9jdFAzUDJQ?=
 =?utf-8?B?VVNoV0VNZGZGVzFFWlVVZFpXbnBxNUxhSHplZW41VHFpeDRiUTZMYzlDZi9U?=
 =?utf-8?B?SnBZT2NScDEvTWFRTEY3Uy9aMWpsRGZUZ0FmeVdhMnpnbmlBVGhkdXFZTzdl?=
 =?utf-8?B?b29NbFU2dzdKajRyRXZWS0lKVHhZOEtFL1NqeW9DNE5rT2xKKzhvYU9Oa0Nw?=
 =?utf-8?B?NlkvdUU5dWJzZUVVZVRnT0dvY01DZG1RTnIrMndDU0NtTHB3OFR4Qmt2cmxO?=
 =?utf-8?B?ZGVhVUk0RVU0Z0dmc2pjSVpkU00vY1k5bzlUa0ZvaWk4ZGxJcU13b3hveE1V?=
 =?utf-8?B?Y0dURzdiVklMS2FCSEUxM0F4Y0xZT2RtSENzK1VLTVk1K083aFNIMkI3NDRG?=
 =?utf-8?B?Vk55c1NXOGlXNlgyOGt3Q2djMFMxUm91REVPWjBUYWhBTlhYU3RnRlpubjZE?=
 =?utf-8?B?SXYvSStHb29LLysrbTNjSUF2ajV3bHkrckk1SERYb0YzditDa2RMZjY1eDZD?=
 =?utf-8?B?N3F1UC92SWF4WjlSOVA1ZjRaMmlNa1pzSVZ2cGlHKzFmM3FoUWF5cjgvNUtJ?=
 =?utf-8?Q?IXvb1TmcMEUppPU6JufREjWTZ+81caBAaavRi?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc336717-82cf-4260-8d5d-08da21874e02
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2022 22:03:44.1469
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LVX9hdumaRG9tLZDKVpeP6a2Zod5bHQSf7skv4vOUUlJmgVxUpZHP10RmbRR8IYYhHJv3fMDVRt1TjaD++asKFT6YDU+jIYmh0cbWhhwmTA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB2015
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-18_02:2022-04-15,2022-04-18 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 mlxscore=0
 adultscore=0 mlxlogscore=823 suspectscore=0 spamscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204180123
X-Proofpoint-ORIG-GUID: 8BdspZwm4vkAGYV0N0ekoBj8hJBVCIam
X-Proofpoint-GUID: 8BdspZwm4vkAGYV0N0ekoBj8hJBVCIam
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Boris,
Thanks for looking! I've inline comments below.
Eric

On 4/14/22 08:59, Borislav Petkov wrote:
> On Wed, Apr 13, 2022 at 12:42:31PM -0400, Eric DeVolder wrote:
>> CRASH_HOTPLUG is to enable cpu and memory hotplug support of crash.
> 
> What for?
Fair point, a new define isn't necessarily needed. I've now eliminated
CONFIG_CRASH_HOTPLUG and am using CONFIG_HOTPLUG_CPU || CONFIG_MEMORY_HOTPLUG
instead.

> 
> Why don't you put all that new code you're adding under an
> MEMORY_HOTPLUG ifdef? It seems you would need to do that when memory
> hotplug is enabled, anyway.
I think I have done that, in patch "crash: add generic infrastructure for crash
hotplug support", I do have code under MEMORY_HOTPLUG as well as HOTPLUG_CPU.
But...

> 
> Also, looking further into your patchset, you have ugly ifdeffery.
> Instead of that, pls add stubs for the !MEMORY_HOTPLUG case so that
> everything is abstracted away in the headers.

I've examined the code with this thought in mind, and I'm not exactly sure how
this code should be restructured for !HOTPLUG stubs. I'd very much appreciate
an example in order to facilitate accommodating the request!

Thanks!
eric

> 
> Thx.
>