Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751747AbXEGDzR (ORCPT ); Sun, 6 May 2007 23:55:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752393AbXEGDzR (ORCPT ); Sun, 6 May 2007 23:55:17 -0400 Received: from alnrmhc16.comcast.net ([204.127.225.96]:45792 "EHLO alnrmhc16.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751747AbXEGDzQ (ORCPT ); Sun, 6 May 2007 23:55:16 -0400 Subject: Re: [PATCH] relay: use plain timer instead of delayed work From: Tom Zanussi To: Satyam Sharma Cc: akpm@linux-foundation.org, oleg@tv-sign.ru, linux-kernel@vger.kernel.org In-Reply-To: References: <1178426780.29337.67.camel@ubuntu> Content-Type: text/plain Date: Sun, 06 May 2007 22:31:31 -0500 Message-Id: <1178508691.4534.4.camel@ubuntu> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1722 Lines: 45 On Sun, 2007-05-06 at 15:40 +0530, Satyam Sharma wrote: > Hi Tom, > > On 5/6/07, Tom Zanussi wrote: > > [...] > > relay doesn't need to use schedule_delayed_work() for waking readers > > when a simple timer will do. > > > > Signed-off-by: Tom Zanussi > > [...] > > diff --git a/include/linux/relay.h b/include/linux/relay.h > > index 759a0f9..cac0732 100644 > > --- a/include/linux/relay.h > > +++ b/include/linux/relay.h > > @@ -38,7 +38,7 @@ struct rchan_buf > > size_t subbufs_consumed; /* count of sub-buffers consumed */ > > struct rchan *chan; /* associated channel */ > > wait_queue_head_t read_wait; /* reader wait queue */ > > - struct delayed_work wake_readers; /* reader wake-up work struct */ > > + struct timer_list timer; /* reader wake-up timer */ > > struct dentry *dentry; /* channel file dentry */ > > struct kref kref; /* channel buffer refcount */ > > struct page **page_array; /* array of current buffer pages */ > > I suspect you could now safely get rid of the "#include > " at the top of relay.h too. And although timer.h comes > via #include , you might want to do that explicitly > too. > Hi Satyam, Thanks for your comments - I've updated the patch to include timer.h but wait.h would still be needed for wait_queue_head_t, so will leave that in. Tom - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/