Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp622811pxb; Fri, 22 Apr 2022 08:04:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyvelmmtKwbkokgiwACPfO+3O+Eq4p7/41FPweDvIbf1DIsVe0SLBBt4gcQ2Xzc1bqizzr X-Received: by 2002:a17:906:6dc4:b0:6e8:465d:65c3 with SMTP id j4-20020a1709066dc400b006e8465d65c3mr4380521ejt.179.1650639887817; Fri, 22 Apr 2022 08:04:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650639887; cv=none; d=google.com; s=arc-20160816; b=Ydz0/vQD+AnpDgY1laOM8pOXQL5CYM2cG68tqrVyHfxJIzIjTnLjqUIP6pU7JUYnEv Wm42xuAtn1LSFQi9Q34sC2VBxD32BIy2n8SzVkUUweINxAJmvm7ntJW7jii0HoTzb8k+ Ym3PHl5flEw22QbjvmROoXRm63qAel720Zm/vBevE5UxrOASCSHIcvdKibQo7VHLfPhU ERG+o9VEaAxv/M05PRjQMznoQ9ZjcfFJRm0EpKLyV94q0tOfbeuoZfab0J93D1TTHKSX X0jZ2zA8vmcC3ybZuZHwbjRiioLLDVOg+2soOHCA89OaKT67BNGb69snH4UcdcHOc5Zz xmrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=Z6WLrWxMZoOxNP1lz+ANyQQXD9bznYhvqy/jf70c0Rc=; b=Xo2K68XUIpclB1pD1hxN+/ZE1bT74LCy/1RQTAAJc4IQmAlql++uxrS+i5aoOLaQbc kr+5EBeKJKa28Hg0gEiqCXUb4XelGJkUQvKR7dxI8HqSugi3qMxTSvm9LDzPmuHO71QE u9XoZwpyis3ahL0ACMmoyeG4oJdClYITQDcm7ZkifJoZpvKtuxXlREbXfgHSa09i925m sNdnor121++YDLcqjMFB1rChlUr/aDO2bl1Cy8X6LRlFRxsXFKnGyvlT2QhJI2W+LnbG etGIFcFjrPC9phssv+pP+ESVpBO7InCi3vdmAcvm0PvM3kK4trdeKnZZwAsxqyKLTSB7 UxCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HKKe0iLM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gv22-20020a1709072bd600b006e7f255e307si5727740ejc.478.2022.04.22.08.04.22; Fri, 22 Apr 2022 08:04:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HKKe0iLM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386607AbiDUIW0 (ORCPT + 99 others); Thu, 21 Apr 2022 04:22:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381397AbiDUIWW (ORCPT ); Thu, 21 Apr 2022 04:22:22 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3833B5FB4; Thu, 21 Apr 2022 01:19:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DE76FB82145; Thu, 21 Apr 2022 08:19:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C228C385A1; Thu, 21 Apr 2022 08:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650529170; bh=2CZwHx4HVzYufFl2v4wil52kbsl+K8+mJxMxiPbGbnw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=HKKe0iLMEMOLR+KQriHplJvVqeBlCUMTSAYujqEQnk+q2L424QSiZW8J060T3QnLR yYk8qVmsnet32d52/RTpV15I2F0fZoMpnPByWjaq5Ak3exr5Yp3P8TI1qacnWmCwjI BuZLfmiEQZN3gfCFauHZ+HniAcQeQhcCFC9qHkKoZcfZNWMlGbNaxbLN7dHpoTK3T+ nAJd3ZlcQ8x0tIROC7vija6H6KYef9BXxlBKVr5T0J2ZVYTlIWF7Lrj1ew3on8bmG6 qZz6o/+cYTl/DhVFUXAiOdqqmDYmACmRaXcjQIpgnOdaEUSN0LacWalp+fKYKtC3vj 34oFE6nlT2pmg== Date: Thu, 21 Apr 2022 10:19:26 +0200 (CEST) From: Jiri Kosina To: Tom Rix cc: basavaraj.natikar@amd.com, benjamin.tissoires@redhat.com, nehal-bakulchandra.shah@amd.com, Shyam-sundar.S-k@amd.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: amd_sfh: change global variables to static In-Reply-To: <20220420142244.556429-1-trix@redhat.com> Message-ID: References: <20220420142244.556429-1-trix@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Apr 2022, Tom Rix wrote: > Smatch reports this representative issue > amd_sfh_hid_report_desc.h:182:10: warning: symbol 'gyro3_report_descriptor' was not declared. Should it be static? > Similar issues for comp3_report_descriptor and als_report_descriptor. > > Global variables should not be defined in header files. > This only works because amd_sfh_hid_report_desc.h in only included by > amd_sfh_hid_desc.c so change the storage-class specifiers to static. > > Signed-off-by: Tom Rix Applied, thanks Tom. -- Jiri Kosina SUSE Labs