Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 21 Apr 2022 09:32:00 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Peng Wu <wupeng58@huawei.com>
Cc:     j.neuschaefer@gmx.net, linus.walleij@linaro.org,
        openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, liwei391@huawei.com
Subject: Re: [PATCH] pinctrl: nuvoton: Add missing fwnode_handle_put in
 wpcm450_gpio_register
Message-ID: <YmEIcO5FHNvywPXH@latitude>
References: <20220421055356.8163-1-wupeng58@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pfzm36elNCLmliEt"
Content-Disposition: inline
In-Reply-To: <20220421055356.8163-1-wupeng58@huawei.com>
Precedence: bulk


--pfzm36elNCLmliEt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

thank you for your patch!

On Thu, Apr 21, 2022 at 05:53:56AM +0000, Peng Wu wrote:
> In one of the error paths of the device_for_each_child_node() loop
> in wpcm450_gpio_register, add missing call to fwnode_handle_put.

Your patch changes multiple error patches, not just one of them. Please
change the commit message accordingly.

To make it easier to understand for the unfamiliar, please also mention:
- Where fwnode is acquired (in device_for_each_child_node?)
- Where the fwnode is released or used in the success (non-error) path.
  I think (part of) the answer is: It is assigned to gpio->gc.fwnode

>=20
> Signed-off-by: Peng Wu <wupeng58@huawei.com>
> ---
>  drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 23 +++++++++++++++++------
>  1 file changed, 17 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/=
nuvoton/pinctrl-wpcm450.c
> index 0dbeb91f0bf2..de4388b512d7 100644
> --- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> +++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> @@ -1038,15 +1038,19 @@ static int wpcm450_gpio_register(struct platform_=
device *pdev,
>  		if (!fwnode_property_read_bool(child, "gpio-controller"))
>  			continue;

Does the 'continue' also need a fwnode_handle_put call?

> =20
>  		ret =3D fwnode_property_read_u32(child, "reg", &reg);
> -		if (ret < 0)
> +		if (ret < 0) {
> +			fwnode_handle_put(child);
>  			return ret;
> +		}
> =20
>  		gpio =3D &pctrl->gpio_bank[reg];
>  		gpio->pctrl =3D pctrl;
> =20
> -		if (reg >=3D WPCM450_NUM_BANKS)
> +		if (reg >=3D WPCM450_NUM_BANKS) {
> +			fwnode_handle_put(child);
>  			return dev_err_probe(dev, -EINVAL,
> -					     "GPIO index %d out of range!\n", reg);
> +					"GPIO index %d out of range!\n", reg);

Please leave the indentation as is, in this line.

> +		}
> =20
>  		bank =3D &wpcm450_banks[reg];
>  		gpio->bank =3D bank;
> @@ -1060,8 +1064,10 @@ static int wpcm450_gpio_register(struct platform_d=
evice *pdev,
>  		}
>  		ret =3D bgpio_init(&gpio->gc, dev, 4,
>  				 dat, set, NULL, dirout, NULL, flags);
> -		if (ret < 0)
> +		if (ret < 0) {
> +			fwnode_handle_put(child);
>  			return dev_err_probe(dev, ret, "GPIO initialization failed\n");
> +		}
> =20
>  		gpio->gc.ngpio =3D bank->length;
>  		gpio->gc.set_config =3D wpcm450_gpio_set_config;
> @@ -1074,8 +1080,11 @@ static int wpcm450_gpio_register(struct platform_d=
evice *pdev,
>  		girq->parent_handler =3D wpcm450_gpio_irqhandler;
>  		girq->parents =3D devm_kcalloc(dev, WPCM450_NUM_GPIO_IRQS,
>  					     sizeof(*girq->parents), GFP_KERNEL);
> -		if (!girq->parents)
> +		if (!girq->parents) {
> +			fwnode_handle_put(child);
>  			return -ENOMEM;
> +		}
> +
>  		girq->default_type =3D IRQ_TYPE_NONE;
>  		girq->handler =3D handle_bad_irq;
> =20
> @@ -1091,8 +1100,10 @@ static int wpcm450_gpio_register(struct platform_d=
evice *pdev,
>  		}
> =20
>  		ret =3D devm_gpiochip_add_data(dev, &gpio->gc, gpio);
> -		if (ret)
> +		if (ret) {
> +			fwnode_handle_put(child);
>  			return dev_err_probe(dev, ret, "Failed to add GPIO chip\n");
> +		}
>  	}
> =20
>  	return 0;
> --=20
> 2.17.1
>=20


Thanks,
Jonathan

--pfzm36elNCLmliEt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmJhCEcACgkQCDBEmo7z
X9viehAAra7S9FCE9v6tVkbZ2G7HXKr4evTu5Y6GTcaUxZNmWuq6iRDMp+ST0/X3
Rjl/kxia3tWiS3gZRufJaG3LacOcvvE7HDyBwQ9zBHDHq8Qiq9Z8OXCLonhja1HH
iQxe9pv8ZzbMqrqnkdPzJCO9sUoMnM3zIzBlUtoasbBYu1ee5QUKZS6EhTbDdXL0
f/WPnbPNLMQyTM6l5SCkL0ljiaEMnhcAzhB9p8llYIh4aaZcPm6k2whXzsy0gM81
vp2zp+5ggWfXWEnma4yoSBnjFMra5jbM0q+PnyPrT3BuvQUIkRspZbrJyOpxx0SS
kIs6kofuF7FIfivJoqwnBwVCU294ipYvauSXmCWo3iea4lLUWkgwftP1lnqAE+Gq
O08GLqe/VGMfvoSq59AncluzQ4NT5Jn+tBwglN/jzNdtzc9x3Smecob0P/XMlGaQ
4Kns4eTwv/hw0jOdzTlicAaOPRLL+r09XThBPGypuh5cHnyJbZW4KCBUs5sqQ+E8
jQNm68kHj92xiMpZ6KvvlfmTAJA5pnAOmV9eZQxodlLjDIQvGOWFnxQYfucrXsXi
QO3evrqeNUwaE1ggRnapWfCYuNEnLmeNId0FeofbUO716CXiXKCKrqfiTI+JmCE5
6mOez34G1ex7CoWMLb5qVOf2pFflnNqML2U91EAZpp3GbHykVrQ=
=5xn2
-----END PGP SIGNATURE-----

--pfzm36elNCLmliEt--