Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp712342pxb; Fri, 22 Apr 2022 09:38:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwyIzQy/CxZ+lqewfKwWNP8qyPIdD0EprfdXLCoQCqEGMlYtMkVbqzAEkjlJqu02VTLj27b X-Received: by 2002:a17:907:6d8e:b0:6f0:298f:da11 with SMTP id sb14-20020a1709076d8e00b006f0298fda11mr4906383ejc.562.1650645531696; Fri, 22 Apr 2022 09:38:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650645531; cv=none; d=google.com; s=arc-20160816; b=cOI2g8XWf7sU9YfLeCCAK4omEaLPBDodUdlTv1JyGozAlv0/90q2PxhH0mMGa44l/0 asWSuEB6KWQHAiaCPptXL6VvKh4oL7oR+awRdVpGnpKNxdrNJV2v0yDY45oLvcaqZzvo 9ZLoLTtVjVZbu+9aNfLQt8wgyHqTtKsw1RZJLHeeq+nx/iijX15l+LhhygvHl2Qb8Fj+ oUlIBeb7tA1HC6NC5Gr3xgZPia5GN1A2EcYGg7oDka7dFrwnSA9ATcr4l+AExVEon1fY oPab9JhUpBFjprcPvowfL6MNKlOeOjcfcRoOR5PaRQrdRjo/xmzJmdTblJ6qEW7ERyEF wPWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=/86MtLD8Rqj34BloE8PHRzGAy2yRZrOELTQSyGdBTJM=; b=VH3zpG3+H2/Da0Umu9pO6lWEPjfBmGx69wArNSKUHPxKk82XxpZJYqtKNlwZeh6zHI 0d87Ci3I+A/5Hy0JRxyYByHOrpxW9ym1O3yB+q6qh3TnukTWVb7et/Bs4oSpLj2fEkFZ UN3NuHfXffgHpuXhF/aGbW1XYwPFw9heh9VB8StfWPkGGCH5gYXX9N1UDe5GsshgKdYV h8PUo6+soQbctnjhJk9jZh2kj2A9nBSsJv2eMUtRmKXYl0fu3GqitXBfg6lhAqo2bx3t jq4jv+rioIJ6WQFNJ5x0FrGM1kS6GDlgrrO5HuaBRfWHQM1N6V7gsJiKsQlBRtglDwtS o6BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JhKMANox; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw9-20020a170906c78900b006e840554fdfsi6803023ejb.947.2022.04.22.09.38.26; Fri, 22 Apr 2022 09:38:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JhKMANox; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389062AbiDUORK (ORCPT + 99 others); Thu, 21 Apr 2022 10:17:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1388550AbiDUORH (ORCPT ); Thu, 21 Apr 2022 10:17:07 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 594673B54C for ; Thu, 21 Apr 2022 07:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650550457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/86MtLD8Rqj34BloE8PHRzGAy2yRZrOELTQSyGdBTJM=; b=JhKMANoxvC9vM61Zftg6OESd40fDdppiJjQly28aH0aQ8Onmg2X6GxdM6jrynAO/BU+Wb2 OJIRrpRdIvYJ2K5hIMG4r+eVSDf9qfU8+r4bjM1K5c6mSTzYhN4PFN3SuKqzV9a+uJPs7I SnlrTuFJDm6YCHLgArSCptj4DP5rjfc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-624-PbUe-qYrPDC0JBoh3a2rrw-1; Thu, 21 Apr 2022 10:14:14 -0400 X-MC-Unique: PbUe-qYrPDC0JBoh3a2rrw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 00BCE86B8A3; Thu, 21 Apr 2022 14:14:13 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id E7FBA53CE; Thu, 21 Apr 2022 14:14:06 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20220415123614.54024-6-jefflexu@linux.alibaba.com> References: <20220415123614.54024-6-jefflexu@linux.alibaba.com> <20220415123614.54024-1-jefflexu@linux.alibaba.com> To: Jeffle Xu Cc: dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com, tianzichen@kuaishou.com, fannaihao@baidu.com, zhangjiachen.jaycee@bytedance.com Subject: Re: [PATCH v9 05/21] cachefiles: implement on-demand read MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1445519.1650550446.1@warthog.procyon.org.uk> Date: Thu, 21 Apr 2022 15:14:06 +0100 Message-ID: <1445520.1650550446@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeffle Xu wrote: > A new NETFS_SREQ_ONDEMAND flag is introduced to indicate that on-demand > read should be done when a cache miss encountered. That may conflict with changes I'm making - but it's just a matter of flag renumbering. > +#define CACHEFILES_IOC_CREAD _IOW(0x98, 1, int) I wonder if CACHEFILES_IOC_READ_COMPLETE would be a better name, but apart from that: Acked-by: David Howells