Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <91ef84f9-4cac-c0aa-c717-7f1b3bc566fb@xilinx.com>
 <20220414164508.GA753109@bhelgaas> <CH2PR02MB6952D1D0E6FA89ED25110AFFA5F29@CH2PR02MB6952.namprd02.prod.outlook.com>
In-Reply-To: <CH2PR02MB6952D1D0E6FA89ED25110AFFA5F29@CH2PR02MB6952.namprd02.prod.outlook.com>
From:   Rob Herring <robh@kernel.org>
Date:   Tue, 19 Apr 2022 09:12:52 -0500
Message-ID: <CAL_JsqJynvpmdF2cBFDQ3og4zgrx9UFtj4NkGUV20f61yc+YtA@mail.gmail.com>
Subject: Re: [PATCH v1 1/3] dt-bindings: PCI: xilinx-cpm: Remove version
 number in compatible string
To:     Bharat Kumar Gogada <bharatku@xilinx.com>
Cc:     Bjorn Helgaas <helgaas@kernel.org>,
        Michal Simek <michals@xilinx.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Apr 19, 2022 at 7:22 AM Bharat Kumar Gogada <bharatku@xilinx.com> wrote:
>
> > On Thu, Apr 14, 2022 at 02:46:25PM +0200, Michal Simek wrote:
> > > On 4/14/22 11:22, Bharat Kumar Gogada wrote:
> > > > Removing unnecessary version number in compatible string.
> > >
> > > I am missing reason for this in commit message.
> >
> > Agreed.  The commit log for the pcie-xilinx-cpm.c change also needs to
> > explain why removing the version is useful and safe.
>
> HI Bjorn, Michal,
>
> The CPM block is hard block, Rob pointed out that versioning has no value here.
> Will resend patch with this detail.

I did not say to remove the existing version breaking compatibility.
Just don't continue to add new version numbers.

Rob