Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp744370pxb; Fri, 22 Apr 2022 10:14:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbEpYkfc3z7v2Iz7pgvn7oec1yrINqQWSwUwh2TwDKrUQys5NHBzSCKYazuyvrKQ7kZNxi X-Received: by 2002:a17:90b:3843:b0:1d2:b8f8:ecc8 with SMTP id nl3-20020a17090b384300b001d2b8f8ecc8mr6387472pjb.218.1650647683024; Fri, 22 Apr 2022 10:14:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650647683; cv=none; d=google.com; s=arc-20160816; b=voM/aQ+Q7t63979fbn2/0Qc4FqXwAvT/ApFZ3DUxRCvmMCaGDP2E3FHYsCPpH9AXcv GWHla2y71c19E+uyiOe0hY70Pmw0QQdRv477gJR2sMlzvdRUGGhM3VgIDRzlqXItPy1W hzdWLKyjhJdg5jRRbaWCLpqQKcV3VXRhHlbQzVN2kszLPkCpMiNRDenC+M9d+E72FHJd iPquYjHVnLg1IeCVaZ+QHVpDLQI3nCiP5f2P3wl4KfaJJhgDQ+fua0MzfuykCaam1nmj dHpS4AOXrWnsp3w6rQOE8scaxlUJSAeC5gr0RX5z1A7ug+0Ty1tLOhtanRvxJPxfiPj3 eBtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=py+QfXNJ+P5tEci1Q7kBCrWrS9LNF5KGNwCzn6aeyrQ=; b=D8j8ghrE5UL57dcfkr6MRrfPGKd8UpRL1eITsXaBSJDbfksQkuRHoyYHb0FauTek+0 u8MsI05axzCtEtOsCmozm4wnGPoQu40Lu5psBAfWecI+nWijF7XoFuWRxYD0p2t2U7AG jY5sWm9D8n3rdqCkyND+qI5ubFzlH27HV4nYYmbNDq7Q+fam/LUVLbTdx1x7ylkPPUdy oj/flvc+lMWepmzOYSB12r3X+osGLpvZqq2F7c0GPePUpUsFi/WnhMSteap2tiEhYmUz W8iAImpkZILMkQaAqyLewXe7UdvGKEwP3jypNJkaI9AXtO1KRfr5qBXInoU1i8feZSn0 jrzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=KM5gDyJu; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d186-20020a6336c3000000b003992df1385bsi8969988pga.684.2022.04.22.10.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 10:14:43 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=KM5gDyJu; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 75864A2073; Fri, 22 Apr 2022 10:13:20 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1387423AbiDUJN0 (ORCPT + 99 others); Thu, 21 Apr 2022 05:13:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1387457AbiDUJNV (ORCPT ); Thu, 21 Apr 2022 05:13:21 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 079F9B1E5; Thu, 21 Apr 2022 02:10:32 -0700 (PDT) Received: from zn.tnic (p200300ea971b58ed329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:58ed:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 64B281EC059D; Thu, 21 Apr 2022 11:10:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1650532227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=py+QfXNJ+P5tEci1Q7kBCrWrS9LNF5KGNwCzn6aeyrQ=; b=KM5gDyJuUal2/fPPCqNB8435NsyUN9MGiIuwoiXyfBZnVnK2gDr14l2yPvqndzTcASYT8l r7chl4/YvlGfGmxXfvZXWBeW/WlckipBqtIgthr59a5o4j/NrCsrgw0oV+C1LNnjyTpbBo aMWzLiLCfGiEufkNqYNqvpYAopcyIIo= Date: Thu, 21 Apr 2022 11:10:26 +0200 From: Borislav Petkov To: Sathyanarayanan Kuppuswamy Cc: Kai Huang , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, Hans de Goede , Mark Gross , "H . Peter Anvin" , "Kirill A . Shutemov" , Tony Luck , Andi Kleen , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH v3 4/4] platform/x86: intel_tdx_attest: Add TDX Guest attestation interface driver Message-ID: References: <20220415220109.282834-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220415220109.282834-5-sathyanarayanan.kuppuswamy@linux.intel.com> <9198cc36-67d6-9365-5d18-f23ba4075151@linux.intel.com> <088a3cbc-5d83-ca47-f544-087f0d59e331@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <088a3cbc-5d83-ca47-f544-087f0d59e331@linux.intel.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2022 at 03:09:44PM -0700, Sathyanarayanan Kuppuswamy wrote: > I agree with dropping the new CONFIG option. But regarding driver > location, which is preferred (platform/x86/intel/tdx or arch/x86/coco/tdx/)? Well, since this is not really a driver but the attestation part of TDX, then arch/x86/coco/tdx/ sounds like the place. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette