Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20220415123614.54024-2-jefflexu@linux.alibaba.com>
References: <20220415123614.54024-2-jefflexu@linux.alibaba.com> <20220415123614.54024-1-jefflexu@linux.alibaba.com>
To:     Jeffle Xu <jefflexu@linux.alibaba.com>
Cc:     dhowells@redhat.com, linux-cachefs@redhat.com, xiang@kernel.org,
        chao@kernel.org, linux-erofs@lists.ozlabs.org,
        torvalds@linux-foundation.org, gregkh@linuxfoundation.org,
        willy@infradead.org, linux-fsdevel@vger.kernel.org,
        joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com,
        tao.peng@linux.alibaba.com, gerry@linux.alibaba.com,
        eguan@linux.alibaba.com, linux-kernel@vger.kernel.org,
        luodaowen.backend@bytedance.com, tianzichen@kuaishou.com,
        fannaihao@baidu.com, zhangjiachen.jaycee@bytedance.com
Subject: Re: [PATCH v9 01/21] cachefiles: extract write routine
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1393748.1650547482.1@warthog.procyon.org.uk>
Date:   Thu, 21 Apr 2022 14:24:42 +0100
Message-ID: <1393749.1650547482@warthog.procyon.org.uk>
Precedence: bulk

Jeffle Xu <jefflexu@linux.alibaba.com> wrote:

> Extract the generic routine of writing data to cache files, and make it
> generally available.
> 
> This will be used by the following patch implementing on-demand read
> mode. Since it's called inside cachefiles module in this case, make the
> interface generic and unrelated to netfs_cache_resources.
> 
> It is worth noting that, ki->inval_counter is not initialized after
> this cleanup. It shall not make any visible difference, since
> inval_counter is no longer used in the write completion routine, i.e.
> cachefiles_write_complete().
> 
> Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>

Acked-by: David Howells <dhowells@redhat.com>