Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Subject: Re: [PATCH] staging: vchiq_arm: change vchiq_platform_init from
 global to static
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com,
        gregkh@linuxfoundation.org, stefan.wahren@i2se.com,
        gascoar@gmail.com, ojaswin98@gmail.com,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20220418164356.3532969-1-trix@redhat.com>
 <20220422144423.GI2462@kadam>
From:   Tom Rix <trix@redhat.com>
Message-ID: <4594e273-caae-686c-4a4e-875a7bd70e0c@redhat.com>
Date:   Fri, 22 Apr 2022 08:32:35 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20220422144423.GI2462@kadam>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 4/22/22 7:44 AM, Dan Carpenter wrote:
> On Mon, Apr 18, 2022 at 12:43:56PM -0400, Tom Rix wrote:
>> Smatch reports this issue
>> vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init'
>>    was not declared. Should it be static?
> This is a Sparse warning, not Smatch.

Yes, this is correct.

Though I am using

make CC=cgcc

And forgot which one I had installed last.

Tom

>
> Use this command for Smatch
> ~/smatch/smatch_scripts/kchecker drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>
> And this command for Sparse
> ~/smatch/smatch_scripts/kchecker --sparse drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
>
> regards,
> dan carpenter
>