Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220422014157.8200-1-ming.qian@nxp.com>
In-Reply-To: <20220422014157.8200-1-ming.qian@nxp.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Thu, 21 Apr 2022 22:51:04 -0300
Message-ID: <CAOMZO5BPjU0WCU4CMKH5wfbWrqJQS-5AcNZyUpuEpOp6gr=R6A@mail.gmail.com>
Subject: Re: [PATCH v3] media: imx-jpeg: Encoder support to set jpeg quality
To:     Ming Qian <ming.qian@nxp.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        mirela.rabulea@oss.nxp.com,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Sascha Hauer <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-media <linux-media@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Apr 21, 2022 at 10:42 PM Ming Qian <ming.qian@nxp.com> wrote:
>
> Implement V4L2_CID_JPEG_COMPRESSION_QUALITY
> to set jpeg quality
>
> ---
> v3
> - put this v3 information below the --- line
>
> v2
> - free ctrl handler if error is set and return error

Wrong placement.

>
> Signed-off-by: Ming Qian <ming.qian@nxp.com>
> ---

It is after the Signed-off-by and this --- line that you should put
the version history.