Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <b34fa2a5-58b4-6270-2d19-2ad591e3e250@amd.com>
Date:   Thu, 21 Apr 2022 10:34:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 2/2] drm/nvdla: Add driver support for NVDLA
Content-Language: en-US
To:     Thomas Zimmermann <tzimmermann@suse.de>,
        Cai Huoqing <cai.huoqing@linux.dev>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org
References: <20220419135908.39606-1-cai.huoqing@linux.dev>
 <20220419135908.39606-3-cai.huoqing@linux.dev>
 <2aeee5a2-b5a5-348e-ccf7-04f49e1119da@suse.de>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <2aeee5a2-b5a5-348e-ccf7-04f49e1119da@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXliWWV2WFNNaFVKVUdWUStTWjFLOFFIRnRYTG96MS9UVTQwc2xNRGZBa3Nh?=
 =?utf-8?B?N3ppaDhFRDQ0WGVseGhaVmNPa3k4R0VGYlUraFJyOG5Xdk5qajgrcVhnR3JF?=
 =?utf-8?B?VTd3VkxycUh1TXY5R3pTWFRUcWFIZFJMKzcxNDhVSzV2VVhjYjRZdVc5OHJh?=
 =?utf-8?B?Rmw4eVhjMk1XYzVkWXpDT3JFYllvR1J3d09HNlRaUEkyZWdVQnp1SWgzN2c4?=
 =?utf-8?B?MTJITXhCQkczc3BoclJ5QzZWeTl3TW51RXJNTVZNQTB3K1ZlOFl2Wi9aMWda?=
 =?utf-8?B?ZGlNbklPekZwOG5yajlrY1BwRkFBYUxvY2Q1QmhmQ1VLRlBFb2E0L3ovSHlk?=
 =?utf-8?B?TVdPZERMbmxYRC9LTVp2RXd0K0UvOW9GeVU0eEZ4Wk40SXdEM2JUOU52QzM4?=
 =?utf-8?B?andnQnlQOUNhWXQxc1pVRXV0NnRPbUx5Q1NQQ2dabzZqUUZsVlRXUkppa1dy?=
 =?utf-8?B?dTFqdGt1cHc5OE1lNDQ0OEI4Y01mbjR1YmllNEVGUlk1YVFpT1h2VjlZK0d4?=
 =?utf-8?B?MEVzMXpyQnhPZ0hwbXowSGVHaEwwWTFVb0VUVThyckpvQWNXRE1oaFhoRE01?=
 =?utf-8?B?USt1cXFYbjNZSUlWb2tOb1lUOGplalBMYVJHTEthSTJtODFzYmxCMjhIaFRo?=
 =?utf-8?B?MXFGMXRNalJRZk5maEgwWmRncStGbEg3K2l4Zi83UXlBNDJwdUNmaFhLRGdN?=
 =?utf-8?B?TThUQjI0eHBkM2FVeHNkZEUzZlJvYXc3WmthWjk2ZWQ0dDV2Y1picVBGSXJj?=
 =?utf-8?B?b2JydFpOZTFxSXVxeDZqTVBMNlpOZUoyTXRjMnpJdGYrU21EQTVNV2NoVXZJ?=
 =?utf-8?B?RmNCQ3F5WVo1MHlSbzhmSzNCdjFhR2dGYlVCN1pzc0tHemlEV2tOLzhJaHd4?=
 =?utf-8?B?SExoK2E5RFZnblZyTGE1QlM2UFJ3SEs4SDUvNllDazROUVBUcW43azRVTWgz?=
 =?utf-8?B?a005OTllMk9NUVRNcktkcmNyUzlsMitzQk9zdEFMY0hwdjc0TmZDcm5qdk1Z?=
 =?utf-8?B?TmNEYWJIeVBzOWhqaTdMai9tSGgrTXB1SGx1ay9aN05KczhicEp5TnN3OFVz?=
 =?utf-8?B?b0lsR1NwbUVRT3JxNWVwRTRyQUhKYjM1dXpnejVHSlQ0a2JwZ0lNR09jTjZS?=
 =?utf-8?B?R0FJNDBaTDh1WXhBemZSemNuajFXZklwZkhiakI5SXM4bzE4emptSjh6LzVJ?=
 =?utf-8?B?aTFBc0JRZTRVU1BGMSt1VlRPY043ZEgwcEpyN2ZnUkxzRkZJcWVOeGFCM3cw?=
 =?utf-8?B?cjRZdzJwLy96T3kvNGZZYkpNN09EU2M0K2lSNGpjdWtTNDZpQ1dFRGZOSEFL?=
 =?utf-8?B?UjNUMW1pMkRrdDl5cVBzQW5nVFVMNWxMQ2p4QXliNVZNS1RWTUd0V3Z1OEw2?=
 =?utf-8?B?TXJIWFc4bDM3L2hlMHFoWFlrNTVwTkJCRUJGMVV2NjJVNzJFV3JLY1E3U3Qy?=
 =?utf-8?B?LzJIUmRpUC9CMm91OFp5Y3RTUUJ0K3FGUDZ0cE5yZFVXc0ZOeTl1Nk1EbG0v?=
 =?utf-8?B?Y2NoQmFvenYyQUkwbVVldFhrLzFHOGJVRXJ5YlRzbU1YSzA0em41RnprQkxN?=
 =?utf-8?B?STJIamFZcGJyUzc1aG9Ia1ZyaXpGZndxTWlSazdjRzR6STFMUTVCTUd5RERG?=
 =?utf-8?B?OVZWVWhqTkNkTTVTV2c5SXh2NlRUbnVFeFVpUVVjSUh1VmhKUU9WZ05XVkdW?=
 =?utf-8?B?ZWZQb21WblFpWGJvRW5QVVFiZlpIY0V3TThlNno4VGpKTHBhZFpTenRiWGtK?=
 =?utf-8?B?M3VPcUl6OW1tb2ptM3NYUEtnTktyTVdIbG9SN2Rpc3d4S3pScTMwT2t5WWU2?=
 =?utf-8?B?Ym5pQ3lJRWpld1EzdkRsL2ZBN1o3c0JXblhzc3hoSGFQWFdmOGdKbFNsVjFa?=
 =?utf-8?B?MUIzQStVOVJyamxrdW1EMmIyWjdFL3dhS1ZSSW9YSTRuUExjcStWMGpYTG51?=
 =?utf-8?B?ZVUvNElZc2RNMnE0SVhac1pLdDB4SExsZzl2MldnRWJLempEdXVqNHFKNExR?=
 =?utf-8?B?SkJJTFQwVGYvSVgyNDZxaS9zNzJpUUtQQXl6NFpDRWprTWI3YUVzaGl6SWNx?=
 =?utf-8?B?UnNHeFRNNjU0Vkl2NmhveDJRRS8ybEdrZWpIVVZEV3pMaUkrSkd1aFZjRjdI?=
 =?utf-8?B?dlJKVG5HWkJxazNIanZCbmNHbUJZTkJnTm5ZNWtMU2Y2akJLcElFK2VQMWN2?=
 =?utf-8?B?VHorbFdxUnlCTVNKNkkrZ1p4QlgxSFc5U2RWZnBPVEhhRGtDaWducitzY2Q2?=
 =?utf-8?B?WFp6K0oyczU0SnFJNFdhd3c1YkhDWjJpM2tFWVVheEI0ZUpGYXhGNjFld0ZF?=
 =?utf-8?B?RlJJNCtleEY1MStiaTF6eVUrdUFQV2YrN0lPUFRvNWVVSzdKNENwUTk2cjdL?=
 =?utf-8?Q?nQ2d9QdWOMIokpgo6Y9tAWRBa0pvo8XZP3gjiExF/7oIR?=
X-MS-Exchange-AntiSpam-MessageData-1: rQR51j23UW932Q==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 02ddc887-ce5e-4103-5700-08da2371beb4
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 08:34:26.5831
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2OQncNVYniHhQlvyMN1LOjCDptY/Z8Lnew8hhOkk0N5xDzx2WV7r8fuhQyf3RBuS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6135
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 21.04.22 um 10:30 schrieb Thomas Zimmermann:
> (Resending, as some MLs didn't like the size of the origninal mail.)
>
> Hi,
>
> thanks for your submission. Some general comments:
>
>   * some functions are prefixed with dla_, others use nvdla_. It seems 
> arbitrary to me. Please use nvdla_ consistently throughout the source 
> code.
>
>   * For reporting errors, please use drm_err(), drm_warn(), etc. I 
> suggest to rearrange the error messages to not be located in the 
> innermost functions.

If you plan to have multiple instances of the driver loaded at the same 
time, using drm_dev_err(), drm_dev_warn() etc.. would be even better.

BTW: I'm still absolutely not keen to enforcing drm_* log functions. So 
if you prefer to stick with pr_err() and dev_err() we could discuss that 
once more.

Regards,
Christian.

>
>   * Could you please split this patch into smaller pieces? It 
> currently hits size limits of some mailing lists. Maybe add the 
> register constants separately.
>
> Please find more review comments below. It's not a full review, but at 
> least something to start with.
>
> Best regards
> Thomas