Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 22 Apr 2022 18:09:12 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Solomon Tan <wjsota@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: Remove space after cast
Message-ID: <20220422150912.GJ2462@kadam>
References: <20220419124318.8028-1-wjsota@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220419124318.8028-1-wjsota@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7+T9AoDoNPQsq4Ja5Y/yGtnpOlMHe4T8uVl+b78CPaEECi2FJgTLbhT6NPrd?=
 =?us-ascii?Q?lRsjMChfLNv5d4zq5sy2/vcmdg5U/INwAt4ORtN113uioXdY2OxPL5uxvSFL?=
 =?us-ascii?Q?s93XL+rDOA62n0Won2R/w7O2KgCrXrVjYgo54iYB0zCgnWGs+9gPfcV0Prib?=
 =?us-ascii?Q?rrSwSCOXFM9lsXMYC33ircYCt6An4xVAirkBXJkpzU0ufXhRF//yNoGjrJkf?=
 =?us-ascii?Q?Y1ca4wZzOi147xsJ72T9haQXEuzO2QoE+SYOgEkZP2aFlh5wSzzJRGYnU4bS?=
 =?us-ascii?Q?o3JEG2mLS1jKUgGQgdeuNs2RZCtP4TVlNFpHk5zFUDsQa1XeEi6E4WizfX12?=
 =?us-ascii?Q?B9f6tOlltBioY3SteFfnmPF7KwLfhOvOkx6re2dhYMCcDn+ZqkFay9+GW7K8?=
 =?us-ascii?Q?HwnC3aMCntGxleE5t4FdHXnRhm+JN/iq9g2IAOTjRzzpH4sIPf0HI9Ix2FY8?=
 =?us-ascii?Q?fOSUqJNQgmJ65331DrPfGOjv5aMifauRorLD/lPl+/F1vVyGSUudfbgYDvYm?=
 =?us-ascii?Q?EMY1W/wPpk83n/r4Xt7i911/qZScB/7xBoFjgjprhKopsf+4aSANF4bSqDgZ?=
 =?us-ascii?Q?w2afW3qiCwR0LpoxwqJLU2U7OLZNNrvEQh84XnZTPErCblbP7sTwQC3/HAPA?=
 =?us-ascii?Q?PCreB5gC34t9f+qXg9Refm/Fx5C0A5aF9QtlXbaNtejM2Hi4T1KPrHx7h750?=
 =?us-ascii?Q?43k0Vd0AdUi6ahp3Z/Ad+PEzDI+c25OfVEdYbpVQxdqQI5gzmmNvtrBrzK8m?=
 =?us-ascii?Q?by5gizNtDBHYiYBwUVKQwBN3YhvWfhqPEme5iIuyJUK5D9P9bOjV7WEC0JrT?=
 =?us-ascii?Q?X5/3yCQmx0JjSLj5tz41x0Kx6nfsVQTRhW75qkRcrXtsvHykqWAz2DWhdENU?=
 =?us-ascii?Q?htMYup/GB2o15P6cp/5BC42+8fD50hLh5fdCy2iGhqS8GP/JIWGlQGDGiRNR?=
 =?us-ascii?Q?wbk00s25ZHou4y68dJwpIj3ADF/vVvUG9Ipa6mJ65DkTAYIxrDZDJxAIpsj6?=
 =?us-ascii?Q?kb5AQ0zMCEM0vZgLHynjLfuOK9y3ptwpDE9Mffh4CCtcY5J2HoOc+0/4RNiq?=
 =?us-ascii?Q?Luppk7CHK32Se9MmdsU0PKfM74hV8eTFi1t43gauCc0PMhxj2LXdcJChSQS/?=
 =?us-ascii?Q?pM20dRXv3RT2Fh65u9h8XZ1vuIEvPhHVIkwJYoXJNY1/7a03ZWeghpvTLKzF?=
 =?us-ascii?Q?53cOUqsnRpGYQu0hSDCa90nVjHpgv/6zlU0LOxlcRuQ8NqYgcHEAVaX4xQjK?=
 =?us-ascii?Q?JzUF1BM1f6r0HK6QCkQ+XeNDnHrZDM1gt75CZcOeYKBu7Q8ILAgarlZHgadj?=
 =?us-ascii?Q?tgV5B5pBEzW3Jkke3N1h2RN+wdgIvCS7svparEt41NtPmiJcMFutrUM+kDso?=
 =?us-ascii?Q?bdgKoR94Iq5loS/IEWpaV020Lko+zpyg5DKDAmWVQAVGmCAuaUfhUe3bmf1b?=
 =?us-ascii?Q?Y+VLWq8h0jVWGNTJtplWgVba24OAd7k/BSiwdyiytonVTM0xyM1vMaE6+63A?=
 =?us-ascii?Q?4/UTFVd3dGu22y5HblkAuBv68bdQaupqGZOdZl2v7Kk11Qv/F9bzIlYFrwBc?=
 =?us-ascii?Q?OXhGDzH4wlLZhG6b0u5NzqiUHQUX63q3YgSNNlVE8JotxwHxnhD/bjIXo5Vm?=
 =?us-ascii?Q?FDdnBWBIBYVhWWipOere4qkTzCCePMY68RqjBIMtQu7LDE9EejhEtbJJQZDq?=
 =?us-ascii?Q?xEjCs6V1j6/43NMP1kcL1qjYQZFTtTQD9mu5llfr97m6uiS0mf4Z155P75S5?=
 =?us-ascii?Q?dTMu/OrUJLorpBDBqiXrTfK2+FDx9F8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f080b1a5-80f7-4e4f-caf4-08da24721c20
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 15:09:35.5003
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XxGJbRscDnVTvhsgbE9jAZkuOR/C3/aRkSmrjgaC66UAcRWsxwp7SaTXCTbIzkaz31zyJjo+ovFHpoNkC5iHBkGBgzp+u6k/ghM1nN1hzNs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1417
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-22_04:2022-04-22,2022-04-22 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0
 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204220067
X-Proofpoint-ORIG-GUID: NXh-vVcfYSzkBxPnVLfTgv__H2ph8Xzg
X-Proofpoint-GUID: NXh-vVcfYSzkBxPnVLfTgv__H2ph8Xzg
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 19, 2022 at 08:43:19PM +0800, Solomon Tan wrote:
> This patch addresses the checkpatch.pl flag that there should not be a
> space after a cast.
> 
> Signed-off-by: Solomon Tan <wjsota@gmail.com>
> ---
>  .../staging/rtl8192e/rtl8192e/r8192E_dev.c    |  8 ++--
>  drivers/staging/rtl8192e/rtl8192e/rtl_dm.c    |  2 +-
>  drivers/staging/rtl8192e/rtl819x_BAProc.c     |  2 +-
>  drivers/staging/rtl8192e/rtllib_crypt_ccmp.c  | 10 ++---
>  drivers/staging/rtl8192e/rtllib_crypt_tkip.c  | 38 +++++++++----------
>  drivers/staging/rtl8192e/rtllib_rx.c          | 20 +++++-----
>  drivers/staging/rtl8192e/rtllib_softmac.c     | 34 ++++++++---------
>  drivers/staging/rtl8192e/rtllib_softmac_wx.c  |  4 +-
>  drivers/staging/rtl8192e/rtllib_wx.c          |  2 +-
>  9 files changed, 60 insertions(+), 60 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index 7f9dee42a04d..a45ee95a8e6b 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -221,7 +221,7 @@ void rtl92e_set_reg(struct net_device *dev, u8 variable, u8 *val)
>  			 &priv->rtllib->current_network.qos_data.parameters;
>  		u8 pAcParam = *val;
>  		u32 eACI = pAcParam;
> -		union aci_aifsn *pAciAifsn = (union aci_aifsn *) &
> +		union aci_aifsn *pAciAifsn = (union aci_aifsn *)&
>  					      (qos_parameters->aifs[0]);

The & should go on the other line actually.

	union aci_aifsn *pAciAifsn = (union aci_aifsn *)
					&qos_parameters->aifs[0];


>  		u8 acm = pAciAifsn->f.acm;
>  		u8 AcmCtrl = rtl92e_readb(dev, AcmHwCtrl);
> @@ -811,7 +811,7 @@ bool rtl92e_start_adapter(struct net_device *dev)
>  
>  	rtl92e_config_mac(dev);
>  
> -	if (priv->card_8192_version > (u8) VERSION_8190_BD) {
> +	if (priv->card_8192_version > (u8)VERSION_8190_BD) {

This cast is unnecessary.  Just delete it.  In a separate patch.

>  		rtl92e_get_tx_power(dev);
>  		rtl92e_set_tx_power(dev, priv->chan);
>  	}
> @@ -1613,9 +1613,9 @@ static void _rtl92e_query_rxphystatus(
>  				total_rssi += RSSI;
>  
>  			if (bpacket_match_bssid) {
> -				pstats->RxMIMOSignalStrength[i] = (u8) RSSI;
> +				pstats->RxMIMOSignalStrength[i] = (u8)RSSI;
>  				precord_stats->RxMIMOSignalStrength[i] =
> -								(u8) RSSI;
> +								(u8)RSSI;

Same thing delete.

>  			}
>  		}
>  
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> index 756d8db51937..aa942d915992 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> @@ -844,7 +844,7 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(struct net_device *dev)
>  		TempCCk = rtl92e_get_bb_reg(dev, rCCK0_TxFilter1, bMaskByte2);
>  		for (i = 0; i < CCK_Table_length; i++) {
>  			if (TempCCk == (u32)CCKSwingTable_Ch1_Ch13[i][0]) {
> -				priv->CCK_index = (u8) i;
> +				priv->CCK_index = (u8)i;

Same thing.

>  				RT_TRACE(COMP_POWER_TRACKING,
>  					 "Initial reg0x%x = 0x%x, CCK_index = 0x%x\n",
>  					 rCCK0_TxFilter1, TempCCk,
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 97afea4c3511..4616ea8266b3 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -238,7 +238,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
>  			     skb->data, skb->len);
>  #endif
>  
> -	req = (struct rtllib_hdr_3addr *) skb->data;
> +	req = (struct rtllib_hdr_3addr *)skb->data;
>  	tag = (u8 *)req;
>  	dst = (u8 *)(&req->addr2[0]);
>  	tag += sizeof(struct rtllib_hdr_3addr);
> diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> index ed968c01c7ff..a8d22da8bc9a 100644
> --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> @@ -103,7 +103,7 @@ static int ccmp_init_iv_and_aad(struct rtllib_hdr_4addr *hdr,
>  	if (a4_included)
>  		aad_len += 6;
>  	if (qc_included) {
> -		pos = (u8 *) &hdr->addr4;
> +		pos = (u8 *)&hdr->addr4;
>  		if (a4_included)
>  			pos += 6;
>  		qc = *pos & 0x0f;
> @@ -130,13 +130,13 @@ static int ccmp_init_iv_and_aad(struct rtllib_hdr_4addr *hdr,
>  	 * A4 (if present)
>  	 * QC (if present)
>  	 */
> -	pos = (u8 *) hdr;
> +	pos = (u8 *)hdr;
>  	aad[0] = pos[0] & 0x8f;
>  	aad[1] = pos[1] & 0xc7;
>  	memcpy(&aad[2], &hdr->addr1, ETH_ALEN);
>  	memcpy(&aad[8], &hdr->addr2, ETH_ALEN);
>  	memcpy(&aad[14], &hdr->addr3, ETH_ALEN);
> -	pos = (u8 *) &hdr->seq_ctl;
> +	pos = (u8 *)&hdr->seq_ctl;
>  	aad[20] = pos[0] & 0x0f;
>  	aad[21] = 0; /* all bits masked */
>  	memset(aad + 22, 0, 8);
> @@ -186,7 +186,7 @@ static int rtllib_ccmp_encrypt(struct sk_buff *skb, int hdr_len, void *priv)
>  	*pos++ = key->tx_pn[1];
>  	*pos++ = key->tx_pn[0];
>  
> -	hdr = (struct rtllib_hdr_4addr *) skb->data;
> +	hdr = (struct rtllib_hdr_4addr *)skb->data;
>  	if (!tcb_desc->bHwSec) {
>  		struct aead_request *req;
>  		struct scatterlist sg[2];
> @@ -235,7 +235,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
>  		return -1;
>  	}
>  
> -	hdr = (struct rtllib_hdr_4addr *) skb->data;
> +	hdr = (struct rtllib_hdr_4addr *)skb->data;
>  	pos = skb->data + hdr_len;
>  	keyidx = pos[3];
>  	if (!(keyidx & (1 << 5))) {
> diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
> index 4a760ecbc31e..a305b79c53e7 100644
> --- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
> +++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
> @@ -136,7 +136,7 @@ static inline u16 Hi16(u32 val)
>  
>  static inline u16 Mk16(u8 hi, u8 lo)
>  {
> -	return lo | (((u16) hi) << 8);
> +	return lo | (((u16)hi) << 8);

Delete this cast.

>  }

regards,
dan carpenter