Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 20 Apr 2022 16:00:50 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Yunbo Yu <yuyunbo519@gmail.com>
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: mv_xor_v2: move spin_lock_bh to spin_lock
Message-ID: <Yl/g2uuBrvHXDxZ9@matsya>
References: <20220418141940.1241482-1-yuyunbo519@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220418141940.1241482-1-yuyunbo519@gmail.com>
Precedence: bulk

On 18-04-22, 22:19, Yunbo Yu wrote:
> It is unnecessary to call spin_lock_bh() for that you are already in a

if you are

> taselet.

tasklet

> 
> Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>
> ---
>  drivers/dma/mv_xor_v2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
> index 9c8b4084ba2f..f10b29034da1 100644
> --- a/drivers/dma/mv_xor_v2.c
> +++ b/drivers/dma/mv_xor_v2.c
> @@ -591,14 +591,14 @@ static void mv_xor_v2_tasklet(struct tasklet_struct *t)
>  		dma_run_dependencies(&next_pending_sw_desc->async_tx);
>  
>  		/* Lock the channel */
> -		spin_lock_bh(&xor_dev->lock);
> +		spin_lock(&xor_dev->lock);
>  
>  		/* add the SW descriptor to the free descriptors list */
>  		list_add(&next_pending_sw_desc->free_list,
>  			 &xor_dev->free_sw_desc);
>  
>  		/* Release the channel */
> -		spin_unlock_bh(&xor_dev->lock);
> +		spin_unlock(&xor_dev->lock);
>  
>  		/* increment the next descriptor */
>  		pending_ptr++;
> -- 
> 2.25.1

-- 
~Vinod